feat: Adjust UX of extension installs in V2 settings#1836
Merged
alexhancock merged 2 commits intomainfrom Mar 24, 2025
Merged
Conversation
matthewdiamant
approved these changes
Mar 24, 2025
| closeToast?: () => void; | ||
| } | ||
|
|
||
| export const ErrorMsg: React.FC<ErrorMsgProps> = ({ extensionName, errorMessage, closeToast }) => ( |
Contributor
There was a problem hiding this comment.
Is this file still needed? I don't see ErrorMsg used, and instead ToastError is used below.
| title: name, | ||
| msg: errorMessage, | ||
| errorMessage: data.message, | ||
| toastOptions: { autoClose: false }, |
Contributor
There was a problem hiding this comment.
FYI, ToastError will automatically be autoClose: false if there is an errorMessage passed in.
This is to allow for people to be able to have time to copy the error! Otherwise, the timeout is 5 seconds.
Collaborator
Author
|
@matthewdiamant Thanks! Feedback addressed. I had just forgotten to remove that file and didn't know about the automatic autoClose. Nice! |
tcollier
added a commit
to tcollier/goose
that referenced
this pull request
Mar 24, 2025
* origin/main: feat: Adjust UX of extension installs in V2 settings (block#1836) fix: goose modes styling (block#1833) New toasts (block#1777) feat: bring back install-link-generator which was lost in the extensions-site revamp (block#1832) feat: settings v2 extension add refactor (block#1815) fix: Update link color in chat view for user messages (block#1717) (block#1754) fix windows native uvx (block#1775) fix: correct deep link install link format (block#1830) fix(cli): multiselect visibility for light themes (block#1716) docs: Update styling (block#1831) Refactor top bar (block#1829) Docs: Revamp extensions site (block#1260) fix: extension site not rendering servers (block#1824) feat: add pdf reader (block#1818) fix: fix allowing multiple selectors in goosebench (block#1814) Fix chat width issues (block#1813)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustments to extension install UX in settings v2