feat: allowlist optionally for goosed by michaelneale · Pull Request #1848 · block/goose

michaelneale · 2025-03-25T03:45:28Z

this will load/cache a remote allowlist to prevent accidental deeplink activation of unwanted extensions

Copilot

Pull Request Overview

This PR implements an optional allowlist for extensions by fetching and caching a remote YAML file to prevent accidental activation of unwanted extensions. Key changes include:

Adding allowlist validation for extension commands in the request handler.
Implementing fetching, caching, and checking logic for allowed extensions.
Adding tests for allowlist functionality and updating Cargo.toml with a new reqwest dependency.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/goose-server/src/routes/extension.rs	Added allowlist fetching, caching, and command validation features.
crates/goose-server/Cargo.toml	Introduced reqwest dependency for remote allowlist fetching.

Comments suppressed due to low confidence (1)

crates/goose-server/src/routes/extension.rs:330

Using 'contains' for matching commands may lead to unintended partial matches. Consider replacing it with an equality check (==) to ensure only exact command matches are allowed or document the intended behavior explicitly.

extensions.extensions.iter().any(|entry| cmd_base.contains(&entry.command))

shellz-n-stuff · 2025-03-25T06:53:41Z

crates/goose-server/ALLOWLIST.md

+## How It Works
+
+1. The allowlist is fetched from a URL specified by the `GOOSE_ALLOWLIST` environment variable.
+2. The allowlist is a YAML file that contains a list of allowed extension commands.


Pairs of extension IDs + Commands?

yes it is technically that (although id doesn't carry any intrinsic meaning)

I was thinking we may want to validate both. In a world where IDs are unique I could see this being better long term validation (as you rightly point out no short term impact)

I think for now, just extension command until we know what id's are for!

crates/goose-server/ALLOWLIST.md

shellz-n-stuff · 2025-03-25T06:56:08Z

crates/goose-server/ALLOWLIST.md

+
+## Security Considerations
+
+1. **HTTPS**: Always use HTTPS URLs for your allowlist to prevent man-in-the-middle attacks.


We can probably validate this in the code too right?

shellz-n-stuff · 2025-03-25T06:57:20Z

crates/goose-server/src/routes/extension.rs

+
+/// Implementation of command allowlist checking that takes an explicit allowlist parameter
+/// This makes it easier to test without relying on global state
+fn is_command_allowed_with_allowlist(


I think we should probably compare the IDs alongside the commands. Basically checking the pair

I think id has no meaning, so it just adds more work at the moment to the person maintaining the allowlist + entering things in goose by hand (when the command is what matters)

shellz-n-stuff · 2025-03-25T07:01:30Z

Broadly I really really love this feature. It's such a huge security and trust improvement for customers

shellz-n-stuff

LGTM!

* main: ui: turn on extensions at startup (#1861) ui: models dropdown (#1860) fix: cli empty line (#1856) feat: Allow setting OpenAI timeout from config (#1819) feat: add retry for google (#1854) feat(extensions): add Java/JDK support for MCP servers (#1816) feat: extract `StdioProcessError(msg)` to try to display (#1855) fix: show window bugfix (#1840) fix: append the attachment path to the existing text in the input prompt (#1842) docs: updated docs for smart approval mode (#1853) styles: chat scroll interaction (#1837) ui: add description field to modal (#1846) feat: use temp dir for extracting goose binary (#1838) ui: remove and update extensions (#1847) fix: disappearing user text when stopped (#1839)

wendytang

what's the best way to test the allowlist?

i tried setting an allowlist in the cli, but realized it was for goosed

wendytang · 2025-03-26T22:34:20Z

crates/goose-server/ALLOWLIST.md

+Set the `GOOSE_ALLOWLIST` environment variable to the URL of your allowlist YAML file:
+
+```bash
+export GOOSE_ALLOWLIST=https://example.com/goose-allowlist.yaml


how would the env var be passed into goosed? is it going to be built into the app?

yes, built into app, similar to other ones.

michaelneale · 2025-03-26T23:08:01Z

@wendytang you have to run it from just run-ui - it does not affect the command line

wendytang

Nice! It is working very nicely

wendytang · 2025-03-27T00:24:29Z

did we want to show the error message in the notification?

michaelneale · 2025-03-27T00:36:15Z

@wendytang yeah - I think we could work on a design to present the message "not approved" as well, yes.

This reverts commit 5d2e31d.

* main: fix: handle the case sensitive in mac screenshot name (#2021) ui: better env var ux (#2006) feat: add ANTHROPIC_HOST configuration for Anthropic in cli and UI (#1776) Fix function params (#2012) revert: "feat: allowlist optionally for goosed (#1848)" (#2010) # feat(providers): Add support for generic GCP Vertex AI Claude and Gemini models (#1909) fix: fix empty result for view tool response (#2011) Blog: Top MCP servers I use (#1951) docs: MCP for Nondevs Blog (#1910) styles: update markdown styles (#2005) fix(ollama): respect ollama URL and port (#2004) ui: refresh selected model (#2002) ui: fix radio button selection (#2001) use provider display names (#2000) ui: settings v2 click anywhere to exit models bottom bar (#1997) feat: better ErrorBoundary UI (#1993) feat: check tool annotation before permission check (#1957) fix: see last msg fully in shared session view (#1994)

)

michaelneale added 2 commits March 25, 2025 13:11

checkpoint

505b2d6

adding allowlisting optionally to goosed

4450de4

michaelneale requested review from alexhancock, baxen and Copilot March 25, 2025 03:45

Copilot AI reviewed Mar 25, 2025

View reviewed changes

michaelneale added 4 commits March 25, 2025 15:17

documenting and updating logic

f61f4f4

special case for goosed for built in commands

7e97652

error message

88a4fb7

clearer message for supportablility

6234422

michaelneale mentioned this pull request Mar 25, 2025

feat: allow list of MCPs #1821

Closed

shellz-n-stuff reviewed Mar 25, 2025

View reviewed changes

michaelneale added 3 commits March 26, 2025 11:57

nearly working

4d6b997

tidy up

070877a

removing spaces and using full command

acc0967

shellz-n-stuff approved these changes Mar 26, 2025

View reviewed changes

michaelneale added 2 commits March 26, 2025 15:46

document and add one more single command test

30cdcb5

wendytang reviewed Mar 26, 2025

View reviewed changes

michaelneale requested a review from wendytang March 26, 2025 23:07

wendytang approved these changes Mar 27, 2025

View reviewed changes

michaelneale merged commit 5d2e31d into main Mar 27, 2025
6 checks passed

michaelneale deleted the micn/allowlist-goosed branch March 27, 2025 00:36

salman1993 added a commit that referenced this pull request Apr 2, 2025

Revert "feat: allowlist optionally for goosed (#1848)"

2800d0d

This reverts commit 5d2e31d.

salman1993 added a commit that referenced this pull request Apr 2, 2025

revert: "feat: allowlist optionally for goosed (#1848)" (#2010)

5ece659

lily-de pushed a commit that referenced this pull request Apr 2, 2025

revert: "feat: allowlist optionally for goosed (#1848)" (#2010)

3a9155b

lily-de pushed a commit that referenced this pull request Apr 2, 2025

revert: "feat: allowlist optionally for goosed (#1848)" (#2010)

2820714

michaelneale added a commit that referenced this pull request Apr 3, 2025

feat: allowlist optionally for goosed (#1848)

8176659

ahau-square pushed a commit that referenced this pull request May 2, 2025

feat: allowlist optionally for goosed (#1848)

17fbda5

ahau-square pushed a commit that referenced this pull request May 2, 2025

revert: "feat: allowlist optionally for goosed (#1848)" (#2010)

397279b

bwalding mentioned this pull request May 12, 2025

feat docker via scheme bwalding/goose#1

Open

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025

feat: allowlist optionally for goosed (block#1848)

02b1c6a

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025

revert: "feat: allowlist optionally for goosed (block#1848)" (block#2010

95d8f09

)


		## Security Considerations

		1. HTTPS: Always use HTTPS URLs for your allowlist to prevent man-in-the-middle attacks.

Conversation

michaelneale commented Mar 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shellz-n-stuff commented Mar 25, 2025

Uh oh!

shellz-n-stuff left a comment

Choose a reason for hiding this comment

Uh oh!

wendytang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wendytang Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Mar 26, 2025

Uh oh!

wendytang left a comment

Choose a reason for hiding this comment

Uh oh!

wendytang commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelneale commented Mar 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wendytang left a comment •

edited

Loading

wendytang Mar 26, 2025 •

edited

Loading

wendytang commented Mar 27, 2025 •

edited

Loading