Merged
Conversation
Contributor
|
I tested this out in our internal goose-releases repo and its working. Changes look good to me, will wait on @shellz-n-stuff to approve |
shellz-n-stuff
approved these changes
Apr 3, 2025
Collaborator
Author
|
@salman1993 whenever ready, good to go |
salman1993
approved these changes
Apr 4, 2025
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds back in option for allowlisting with fix for path to shims (and also -y params for npx) with much improved test coverage and allows flexibility for specifying versions as well (allowlist doesn't have to specify an exact version)
fixes: #2007