Fix: deep link extension installation to show dialog for headers configuration#4150
Merged
blackgirlbytes merged 1 commit intomainfrom Aug 22, 2025
Merged
Fix: deep link extension installation to show dialog for headers configuration#4150blackgirlbytes merged 1 commit intomainfrom
blackgirlbytes merged 1 commit intomainfrom
Conversation
blackgirlbytes
requested review from
DOsinga,
angiejones,
dianed-square and
michaelneale
michaelneale
approved these changes
Aug 18, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
not sure 100% how to test it but looks like it makes sense
DOsinga
reviewed
Aug 18, 2025
Merged
michaelneale
added a commit
that referenced
this pull request
Aug 24, 2025
* main: docs: Plan tutorial (#4309) Extensions Modal Improvements (#4293) docs: fixed cicd tutorial pipeline in docs (#4223) Read oltp config from config and env (#4292) release/1.6.0 (#4280) docs: fix broken links in Docker tutorial (#4285) Remove half-second wait, rework auto submit (#4282) Block send until extensions are ready (#4271) fix: improve OpenAI-compatible error handling and add test coverage (#4175) Move To-Do Tool to Session Scope from Agent Scope (#4157) fix: recipe params not being replaced all the time (#4207) chore: removing little-used session sharing feature (#4249) Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257) restore cli projects from accidental removal during cleanup (#4266) Fix: deep link extension installation to show dialog for headers configuration (#4150)
michaelneale
added a commit
that referenced
this pull request
Aug 25, 2025
* main: (24 commits) feat: autovisualiser of structured data with mcp-ui (#4153) docs: Plan tutorial (#4309) Extensions Modal Improvements (#4293) docs: fixed cicd tutorial pipeline in docs (#4223) Read oltp config from config and env (#4292) release/1.6.0 (#4280) docs: fix broken links in Docker tutorial (#4285) Remove half-second wait, rework auto submit (#4282) Block send until extensions are ready (#4271) fix: improve OpenAI-compatible error handling and add test coverage (#4175) Move To-Do Tool to Session Scope from Agent Scope (#4157) fix: recipe params not being replaced all the time (#4207) chore: removing little-used session sharing feature (#4249) Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257) restore cli projects from accidental removal during cleanup (#4266) Fix: deep link extension installation to show dialog for headers configuration (#4150) feat: Add message queue system with interruption handling (#4179) Start extensions concurrently (#4234) Add X-Title and referer headers on exchange to tetrate (#4250) docs: update View/Edit Recipe menu item name (#4267) ...
shellz-n-stuff
pushed a commit
to shellz-n-stuff/goose
that referenced
this pull request
Aug 27, 2025
…iguration (block#4150) Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
…iguration (block#4150) Signed-off-by: Dorien Koelemeijer <dkoelemeijer@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking deep links for extensions that include headers (like the GitHub MCP server with Authorization tokens), the extension would try to install directly without opening the configuration dialog. The user needs to see the dialog to review and edit the placeholder tokens. For example the below would just try to install and fail with the value YOUR_ACTUAL_TOKEN_HERE:
The deep link handler in addExtensionFromDeepLink only checked for environment variables (config.envs) to determine whether to show the settings dialog, but didnt account for headers.
I chatted with goose to figure out where this was happening, and I added it in.