Closed
Conversation
Collaborator
Author
…t session identifier usage - Add shutdown() method to AgentManager to properly abort cleanup task - Store AbortHandle for cleanup task to enable graceful shutdown - Add test for graceful shutdown behavior - Document session::Identifier enum variants to clarify usage: - Name(String): standard session operations (99% of cases) - Path(PathBuf): direct file access for testing/migration - Make spawn_cleanup_task async to properly store abort handle - Add shutdown method to AppState (marked as dead_code until server shutdown is implemented) These changes address PR review concerns about cleanup task lifecycle and session identifier API clarity without breaking existing functionality.
- Adapt to middleware-based authentication from PR #4338 - Remove verify_secret_key in favor of middleware auth - Update AppState initialization to match new signature - Preserve all Agent Manager functionality for per-session isolation - Keep graceful shutdown improvements for cleanup task - Fix test compilation issues with RawTextContent meta field This completes the Agent Manager POC addressing Discussion #4389: - Each session gets its own isolated agent - Extensions don't interfere between sessions - Cleanup task manages memory with graceful shutdown - Foundation laid for scheduler/recipe integration
Collaborator
Author
|
Closing in favor of #4684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rough POC. Do not review/merge