chore(mcp): convert computercontroller server to use the rust sdk by alexhancock · Pull Request #4772 · block/goose

alexhancock · 2025-09-23T17:15:01Z

The final built in MCP server conversion from our old internal mcp crates to https://github.com/modelcontextprotocol/rust-sdk. This also removes a couple modules which were simply routers to different mcp servers, and replaces it with a single module shared between goose-cli and goose-server.

michaelneale · 2025-09-24T00:13:12Z

crates/goose/src/mcp_server_runner.rs

+
+    tracing::info!("Starting MCP server");
+
+    match name {


we were missing this previously?

ah this is the replacement for run_server command

There were two copies of similar files, both with slightly different logic. One in cli and one in server. I am just deduping and improving here, but I should find a final home for it that keeps the dependency direction good. Will make an adjustment.

michaelneale · 2025-09-24T00:18:19Z

crates/goose/Cargo.toml


 arrow = "52.2"
 oauth2 = "5.0.0"
+goose-mcp = { version = "1.8.0", path = "../goose-mcp" }


hrm - there was #4681 change by @jamadeo which IIUC - this would end up circular hrm. Not sure what direction dependency would be but this seems the wrong way?

ie the core shouldn't depend on mcp but other things should depend on core?

michaelneale · 2025-09-24T01:52:18Z

@alexhancock nice - I tested it with docx, xlsx and pdf etc - all seems to perform same as previous.

however, now with main merged, if you update to main and try to compile, as expected:

error: cyclic package dependency: package `goose v1.8.0 (/Users/micn/Documents/code/goose/crates/goose)` depends on itself. Cycle:
package `goose v1.8.0 (/Users/micn/Documents/code/goose/crates/goose)`
    ... which satisfies path dependency `goose` (locked to 1.8.0) of package `goose-mcp v1.8.0 (/Users/micn/Documents/code/goose/crates/goose-mcp)`
    ... which satisfies path dependency `goose-mcp` (locked to 1.8.0) of package `goose v1.8.0 (/Users/micn/Documents/code/goose/crates/goose)`
error: Recipe `release-binary` failed on line 10 with exit code 101
error: Recipe `make-ui` failed on line 218 with exit code 101

so will need to solve that before merging it in (doesn't show up as a merge conflict but will fail), but other than that, good to go!

jamadeo · 2025-09-24T13:34:30Z

crates/goose/src/mcp_server_runner.rs

@@ -0,0 +1,45 @@
+use anyhow::{anyhow, Result};


I think you can delete this file now right? you moved it to goose-mcp?

ah yes, intended to!

…ovements * 'main' of github.com:block/goose: Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) [docs] Add gotoHuman MCP server Tutorial (#4764) fix: adjust nightly builds to first push a tag (#4704) temp file for batch issue creation fix: view can recognise a dir (#4701) goosed standalone works with providers (#4698) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688)

…-unification * 'main' of github.com:block/goose: Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) shave and code split (#4630) docs: acp support (#4793) Add Take Action for Hacktoberfest (#4791) Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) # Conflicts: # crates/goose-server/src/routes/recipe.rs # ui/desktop/openapi.json # ui/desktop/src/api/types.gen.ts # ui/desktop/src/hooks/useRecipeManager.ts # ui/desktop/src/recipe/index.ts

…se into zane/recipe-param-values-resume * 'zane/create-recipe-unification' of github.com:block/goose: fix recipe issues from upstream changes and regenerate types Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) shave and code split (#4630) docs: acp support (#4793) Add Take Action for Hacktoberfest (#4791) fix recipe instructions from session metadata not being injected Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) # Conflicts: # ui/desktop/src/hooks/useAgent.ts # ui/desktop/src/utils/providerUtils.ts

…ose into zane/create-edit-recipe-tests * 'zane/recipe-param-values-resume' of github.com:block/goose: fix recipe issues from upstream changes and regenerate types Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) shave and code split (#4630) docs: acp support (#4793) Add Take Action for Hacktoberfest (#4791) fix recipe instructions from session metadata not being injected Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776)

)

…ock#4772) Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>

alexhancock requested review from angelahning, jamadeo and michaelneale September 23, 2025 17:15

alexhancock force-pushed the alexhancock/rmcp-computercontroller branch from 975e489 to 060749a Compare September 23, 2025 20:11

michaelneale assigned michaelneale and angelahning Sep 23, 2025

michaelneale reviewed Sep 24, 2025

View reviewed changes

alexhancock force-pushed the alexhancock/rmcp-computercontroller branch 2 times, most recently from ce5c453 to 54d62dd Compare September 24, 2025 13:15

alexhancock requested a review from michaelneale September 24, 2025 13:22

jamadeo approved these changes Sep 24, 2025

View reviewed changes

chore(mcp): convert computercontroller server to use the rust sdk

6821d81

alexhancock force-pushed the alexhancock/rmcp-computercontroller branch from 54d62dd to 6821d81 Compare September 24, 2025 13:38

alexhancock merged commit dba0f4e into main Sep 24, 2025
11 checks passed

alexhancock deleted the alexhancock/rmcp-computercontroller branch September 24, 2025 14:03

tlongwell-block pushed a commit that referenced this pull request Sep 25, 2025

chore(mcp): convert computercontroller server to use the rust sdk (#4772

e5688a4

)

HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025

chore(mcp): convert computercontroller server to use the rust sdk (bl…

d4bd700

…ock#4772) Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>

This was referenced Oct 8, 2025

chore(release): release version 1.10.0 #5060

Closed

release/1.10.0 #5101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(mcp): convert computercontroller server to use the rust sdk#4772

chore(mcp): convert computercontroller server to use the rust sdk#4772
alexhancock merged 1 commit intomainfrom
alexhancock/rmcp-computercontroller

alexhancock commented Sep 23, 2025

Uh oh!

michaelneale Sep 24, 2025

Uh oh!

michaelneale Sep 24, 2025 •

edited

Loading

Uh oh!

alexhancock Sep 24, 2025

Uh oh!

michaelneale Sep 24, 2025

Uh oh!

michaelneale Sep 24, 2025

Uh oh!

michaelneale commented Sep 24, 2025 •

edited

Loading

Uh oh!

jamadeo Sep 24, 2025

Uh oh!

alexhancock Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alexhancock commented Sep 23, 2025

Uh oh!

michaelneale Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexhancock Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamadeo Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

alexhancock Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

michaelneale Sep 24, 2025 •

edited

Loading

michaelneale commented Sep 24, 2025 •

edited

Loading