fix: include file attachments in queued messages#5961
Merged
zanesq merged 3 commits intoblock:mainfrom Dec 11, 2025
Merged
Conversation
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where queued messages were losing their file attachments. Previously, when a user queued a message while another prompt was processing, file paths from pastedImages and allDroppedFiles were ignored, causing attachments to be dropped. The fix extracts and combines file paths with text content before queuing, matching the format used by performSubmit().
- Extracts file paths from
pastedImagesandallDroppedFilesarrays with proper filtering - Combines text and file paths into a unified
contentToQueuestring - Clears file-related state (
pastedImages,droppedFiles,localDroppedFiles) after queuing
Collaborator
|
thanks @Abhijay007! If its an easy fix while you are in there can you make it so the stop button changes to a send if any input is added? Confusing now that it still shows stop button but you can technically hit enter to send/queue it. |
Collaborator
Author
sure will do |
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
zanesq
approved these changes
Dec 11, 2025
Collaborator
zanesq
left a comment
zanesq
left a comment
There was a problem hiding this comment.
LGTM, Verified works locally also
katzdave
added a commit
that referenced
this pull request
Dec 12, 2025
…nses-streaming * 'main' of github.com:block/goose: Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) fix(ui): prevent incorrect provider type suffix in update dialog #5908 (#5909) docs: mcp elicitation (#6060)
zanesq
added a commit
that referenced
this pull request
Dec 15, 2025
* 'main' of github.com:block/goose: (22 commits) Disallow subagents with no extensions (#5825) chore(deps): bump js-yaml in /documentation (#6093) feat: external goosed server (#5978) fix: Make datetime info message more explicit to prevent LLM confusion about current year (#6101) refactor: unify subagent and subrecipe tools into single tool (#5893) goose repo is too big for the issue solver workflow worker (#6099) fix: use system not developer role in db (#6098) Add /goose issue solver github workflow (#6068) OpenAI responses streaming (#5837) Canonical models for Providers (#5694) feat: add Inception provider for Mercury models (#6029) fix old sessions with tool results not loading (#6094) Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) ... # Conflicts: # crates/goose-server/src/routes/agent.rs # crates/goose/src/agents/extension_manager.rs # ui/desktop/src/api/sdk.gen.ts
zanesq
added a commit
that referenced
this pull request
Dec 16, 2025
…sions * 'main' of github.com:block/goose: (22 commits) Disallow subagents with no extensions (#5825) chore(deps): bump js-yaml in /documentation (#6093) feat: external goosed server (#5978) fix: Make datetime info message more explicit to prevent LLM confusion about current year (#6101) refactor: unify subagent and subrecipe tools into single tool (#5893) goose repo is too big for the issue solver workflow worker (#6099) fix: use system not developer role in db (#6098) Add /goose issue solver github workflow (#6068) OpenAI responses streaming (#5837) Canonical models for Providers (#5694) feat: add Inception provider for Mercury models (#6029) fix old sessions with tool results not loading (#6094) Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) ... # Conflicts: # crates/goose-server/src/routes/agent.rs # crates/goose/src/agents/extension_manager.rs # ui/desktop/src/api/sdk.gen.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5866
PR Description
This PR fixes an issue where queued messages were being sent without their attached files. when a user queued a message while another prompt was still processing, any drag-and-dropped or pasted files were not included. The issue was that the
handleInterruptionAndQueue()only stored the trimmed text value and ignored file paths frompastedImagesandallDroppedFiles, causing queued messages to lose their attachments and not count it as one message, even thoughperformSubmit()handles file paths correctly.Changes made
pastedImagesandallDroppedFiles.contentToQueuethat combines text and file paths to count them as one.displayValue.trim()usage withcontentToQueue.pastedImagesanddroppedFilesafter queuing to prevent duplication.Type of Change
AI Assistance
Testing
Tested in the desktop UI by dragging and dropping file attachments while another message was in progress, confirming the queued message includes attachments correctly.
Screenshots / Demos (for UX changes)
Before:
After: