Tool reply meta by DOsinga · Pull Request #6074 · block/goose

DOsinga · 2025-12-11T17:29:42Z

Summary

Make goose keep the toolresults around

aharvard · 2025-12-11T19:02:59Z

I just tested.

Should we be seeing structured content in the tool result?

Also, should goose be aware of meta?

DOsinga · 2025-12-11T19:06:50Z

No, for now we're not changing what we are actually sending to the LLM; just what gets send to the client. we should look into that separately since it does feel like that currently we are missing some stuff.

aharvard · 2025-12-11T19:10:58Z

No, for now we're not changing what we are actually sending to the LLM; just what gets send to the client. we should look into that separately since it does feel like that currently we are missing some stuff.

Oh, I see! OK, cool.

Is there an easy way to inspect the client data in goose UI?

DOsinga · 2025-12-11T19:21:55Z

depends on what you want to see. creating a diagnostics report is probably the best thing you can do. it gives you an export of the current conversation and some jsonl files of recent stuff we sent to the providers

alexhancock

Yeah this is good, thanks!

I want to get rid of ToolResult as it's not doing much helpful any more, but I can do that in a followup

aharvard · 2025-12-11T19:30:49Z

depends on what you want to see. creating a diagnostics report is probably the best thing you can do. it gives you an export of the current conversation and some jsonl files of recent stuff we sent to the providers

Thanks! Had never clicked on the bug button before (embarrassed to admit) ... for folks following along:

Copilot

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.

Copilot · 2025-12-11T19:34:05Z

crates/goose-server/src/routes/agent.rs

+            CancellationToken::default(),
+        )
+        .await
+        .map_err(|_e| StatusCode::INTERNAL_SERVER_ERROR)?;


The error is being discarded. Consider logging it or including error details in the response to help with debugging when resource reads fail.

Copilot · 2025-12-11T19:34:06Z

crates/goose-server/src/routes/agent.rs

+        .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;
+
+    let result = tool_result
+        .result
+        .await
+        .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;


Error information is being discarded at two levels. When a tool call fails, the error details should be logged or included in the response to help with debugging.

Copilot · 2025-12-11T19:34:06Z

crates/goose/tests/providers.rs

+            Ok(rmcp::model::CallToolResult {
+                content: vec![Content::text(
+                    "
                  50°F°C
                  Precipitation: 0%
                  Humidity: 84%
                  Wind: 2 mph
                  Weather
                  Saturday 9:00 PM
                  Clear",
-            )]),
+                )],
+                structured_content: None,
+                is_error: Some(false),
+                meta: None,
+            }),


Setting is_error: Some(false) on success paths is redundant and creates unnecessary boilerplate. Consider having CallToolResult default is_error to None on success, or creating a helper method like CallToolResult::success(content) that handles this automatically.

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 1 comment.

Copilot · 2025-12-11T19:48:33Z

crates/goose-server/src/routes/agent.rs

+            CancellationToken::default(),
+        )
+        .await
+        .map_err(|_e| StatusCode::INTERNAL_SERVER_ERROR)?;


Error information is being discarded when mapping errors to StatusCode. The specific error details could be helpful for debugging. Consider logging the error before converting to a generic HTTP status code.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.

Copilot · 2025-12-11T23:05:49Z

crates/goose-server/src/routes/agent.rs

+    path = "/agent/call_tool",
+    request_body = CallToolRequest,
+    responses(
+        (status = 200, description = "Resource read successfully", body = CallToolResponse),


The error description says "Resource read successfully" but this endpoint is for calling tools, not reading resources. The description should say something like "Tool executed successfully" to match the endpoint's purpose.

Suggested change

(status = 200, description = "Resource read successfully", body = CallToolResponse),

(status = 200, description = "Tool executed successfully", body = CallToolResponse),

Copilot · 2025-12-11T23:05:50Z

crates/goose-server/src/routes/agent.rs

+        .extension_manager
+        .dispatch_tool_call(tool_call, CancellationToken::default())
+        .await
+        .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;


Error information is being discarded when converting errors to StatusCode. This makes debugging harder as the client won't know what went wrong. Consider logging the error or returning it in the response body.

Copilot · 2025-12-11T23:05:50Z

ui/desktop/openapi.json

+        },
+        "responses": {
+          "200": {
+            "description": "Resource read successfully",


The response description says "Resource read successfully" but this endpoint is for calling tools, not reading resources. The description should say something like "Tool executed successfully" to match the endpoint's purpose.

…nses-streaming * 'main' of github.com:block/goose: Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) fix(ui): prevent incorrect provider type suffix in update dialog #5908 (#5909) docs: mcp elicitation (#6060)

* 'main' of github.com:block/goose: (22 commits) Disallow subagents with no extensions (#5825) chore(deps): bump js-yaml in /documentation (#6093) feat: external goosed server (#5978) fix: Make datetime info message more explicit to prevent LLM confusion about current year (#6101) refactor: unify subagent and subrecipe tools into single tool (#5893) goose repo is too big for the issue solver workflow worker (#6099) fix: use system not developer role in db (#6098) Add /goose issue solver github workflow (#6068) OpenAI responses streaming (#5837) Canonical models for Providers (#5694) feat: add Inception provider for Mercury models (#6029) fix old sessions with tool results not loading (#6094) Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) ... # Conflicts: # crates/goose-server/src/routes/agent.rs # crates/goose/src/agents/extension_manager.rs # ui/desktop/src/api/sdk.gen.ts

…sions * 'main' of github.com:block/goose: (22 commits) Disallow subagents with no extensions (#5825) chore(deps): bump js-yaml in /documentation (#6093) feat: external goosed server (#5978) fix: Make datetime info message more explicit to prevent LLM confusion about current year (#6101) refactor: unify subagent and subrecipe tools into single tool (#5893) goose repo is too big for the issue solver workflow worker (#6099) fix: use system not developer role in db (#6098) Add /goose issue solver github workflow (#6068) OpenAI responses streaming (#5837) Canonical models for Providers (#5694) feat: add Inception provider for Mercury models (#6029) fix old sessions with tool results not loading (#6094) Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) ... # Conflicts: # crates/goose-server/src/routes/agent.rs # crates/goose/src/agents/extension_manager.rs # ui/desktop/src/api/sdk.gen.ts

Douwe Osinga added 30 commits August 5, 2025 18:27

First post

6c97adf

Merge branch 'main' into goose-apps

1a938d7

What

7191f75

Merge branch 'main' into goose-apps

7a6e6ff

Make them launchable

a63775c

At least it compiles

fd93127

Merge branch 'main' into goose-apps

424b3e8

Throw

2d34098

One step

9266aca

Spawn a recipe

9922462

Extension support -ish

b8c55ee

Merge branch 'main' into goose-apps

7af960f

Include the clock

5cf680b

I dont know

5bfe874

WIP

19ac055

WIP 3

e2c0269

WIP 5

b5f5754

Serving

01cda27

Fix image processing

514593a

Remove print

d1c36dd

Actually save

e2d242d

Merge branch 'main' into goose-apps

2c27388

Say more

14d12a6

External clock

aaa3ffa

Report errors

6082aa6

Merge branch 'main' into goose-apps

02b040c

Merge

ef4af72

Merge branch 'main' into goose-apps

2fea66d

That's a lot

ebdcc40

More

5941fe5

DOsinga requested a review from alexhancock December 11, 2025 19:07

api

4224831

alexhancock approved these changes Dec 11, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings December 11, 2025 19:30

Copilot started reviewing on behalf of DOsinga December 11, 2025 19:31 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Douwe Osinga added 2 commits December 11, 2025 14:36

recordings

63cbab6

Hmm, what?

634577e

Copilot AI review requested due to automatic review settings December 11, 2025 19:44

Copilot started reviewing on behalf of DOsinga December 11, 2025 19:45 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Maybe now?

79b3d98

Copilot AI review requested due to automatic review settings December 11, 2025 23:01

DOsinga force-pushed the tool-reply-meta branch from bbd590e to 79b3d98 Compare December 11, 2025 23:01

Copilot started reviewing on behalf of DOsinga December 11, 2025 23:02 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Also the other

43f6d58

DOsinga merged commit cdab2fc into main Dec 12, 2025
17 checks passed

DOsinga deleted the tool-reply-meta branch December 12, 2025 00:43

zanesq mentioned this pull request Dec 12, 2025

fix old sessions with tool results not loading #6094

Merged

github-actions bot mentioned this pull request Dec 16, 2025

chore(release): release version 1.17.0 (minor) #6131

Closed

aharvard mentioned this pull request Dec 16, 2025

fix: MCP UI not rendering due to CallToolResult structure change #6143

Merged

	(status = 200, description = "Resource read successfully", body = CallToolResponse),
	(status = 200, description = "Tool executed successfully", body = CallToolResponse),

Conversation

DOsinga commented Dec 11, 2025

Summary

Uh oh!

aharvard commented Dec 11, 2025

Uh oh!

DOsinga commented Dec 11, 2025

Uh oh!

aharvard commented Dec 11, 2025

Uh oh!

DOsinga commented Dec 11, 2025

Uh oh!

alexhancock left a comment

Choose a reason for hiding this comment

Uh oh!

aharvard commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants