Skip to content

fix(google): use parametersJsonSchema for full JSON Schema support#6555

Merged
DOsinga merged 1 commit intoblock:mainfrom
rabi:tool_graph
Jan 28, 2026
Merged

fix(google): use parametersJsonSchema for full JSON Schema support#6555
DOsinga merged 1 commit intoblock:mainfrom
rabi:tool_graph

Conversation

@rabi
Copy link
Contributor

@rabi rabi commented Jan 17, 2026

Summary

Google's Schema spec for 'parameters' does not support $ref/$defs in tool definitions. Gemini 3 enforced stricter validation recently, causing silent failures.

Switch to 'parametersJsonSchema' which supports full JSON Schema including $ref and $defs. This removes the need for process_map schema filtering.

Removes technical debt (custom schema sanitizers), and fixes a functional regression with newer Gemini models.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Tested with gemini models that were failing silently since yesterday.

Google's Schema spec for 'parameters' does not support $ref/$defs in tool
definitions. Gemini 3 enforced stricter validation recently, causing silent
failures.

Switch to 'parametersJsonSchema' which supports full JSON Schema including
$ref and $defs. This removes the need for process_map schema filtering.

Removes technical debt (custom schema sanitizers), and fixes a functional
regression with newer Gemini models.

Signed-off-by: rabi <ramishra@redhat.com>
@rabi
Copy link
Contributor Author

rabi commented Jan 21, 2026

@DOsinga @jamadeo Hi, PTAL code mode does not work with gemini3 models atm (silent failures) and this would fix it .

@DOsinga DOsinga merged commit b4cf0fd into block:main Jan 28, 2026
17 checks passed
lifeizhou-ap added a commit that referenced this pull request Jan 28, 2026
* main: (47 commits)
  Upgrade error handling (#6747)
  Fix/filter audience 6703 local (#6773)
  chore: re-sync package-lock.json (#6783)
  upgrade electron to 39.3.0 (#6779)
  allow skipping providers in test_providers.sh (#6778)
  fix: enable custom model entry for OpenRouter provider (#6761)
  Remove codex skills flag support (#6775)
  Improve mcp test (#6671)
  Feat/anthropic custom headers (#6774)
  Fix/GitHub copilot error handling 5845 (#6771)
  fix(ui): respect width parameter in MCP app size-changed notifications (#6376)
  fix: address compilation issue in main (#6776)
  Upgrade GitHub Actions for Node 24 compatibility (#6699)
  fix(google): preserve thought signatures in streaming responses (#6708)
  added reduce motion support for css animations and streaming text (#6551)
  fix: Re-enable subagents for Gemini models (#6513)
  fix(google): use parametersJsonSchema for full JSON Schema support (#6555)
  fix: respect GOOSE_CLI_MIN_PRIORITY for shell streaming output (#6558)
  feat: add requires_auth flag for custom providers without authentication (#6705)
  fix: normalize extension names consistently in ExtensionManager (#6529)
  ...
michaelneale added a commit that referenced this pull request Jan 29, 2026
* main: (30 commits)
  Different approach to determining final confidence level of prompt injection evaluation outcomes (#6729)
  fix: read_resource_tool deadlock causing test_compaction to hang (#6737)
  Upgrade error handling (#6747)
  Fix/filter audience 6703 local (#6773)
  chore: re-sync package-lock.json (#6783)
  upgrade electron to 39.3.0 (#6779)
  allow skipping providers in test_providers.sh (#6778)
  fix: enable custom model entry for OpenRouter provider (#6761)
  Remove codex skills flag support (#6775)
  Improve mcp test (#6671)
  Feat/anthropic custom headers (#6774)
  Fix/GitHub copilot error handling 5845 (#6771)
  fix(ui): respect width parameter in MCP app size-changed notifications (#6376)
  fix: address compilation issue in main (#6776)
  Upgrade GitHub Actions for Node 24 compatibility (#6699)
  fix(google): preserve thought signatures in streaming responses (#6708)
  added reduce motion support for css animations and streaming text (#6551)
  fix: Re-enable subagents for Gemini models (#6513)
  fix(google): use parametersJsonSchema for full JSON Schema support (#6555)
  fix: respect GOOSE_CLI_MIN_PRIORITY for shell streaming output (#6558)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants