Conversation
The Codex CLI has removed the skills feature flag in newer versions, making skills always enabled. This change removes the flag handling from the goose codex provider to simplify the code. Changes: - Remove enable_skills field from CodexProvider struct - Remove --enable/--disable skills CLI flag usage - Remove CODEX_ENABLE_SKILLS config key from metadata - Update documentation to remove skills flag references - Update all tests to remove enable_skills field Skills are now always enabled in Codex CLI, so there's no need for backwards compatibility with older CLI versions that supported the flag.
10 tasks
alexhancock
approved these changes
Jan 28, 2026
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes support for toggling Codex “skills” via goose configuration/CLI, aligning the Codex provider with newer Codex CLI behavior where skills are always enabled.
Changes:
- Removes
enable_skillsfromCodexProviderand stops passing--enable skillsto the Codex CLI. - Removes
CODEX_ENABLE_SKILLSfrom provider metadata/config-keys and updates provider tests accordingly. - Updates CLI provider documentation to remove skills-flag references.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| documentation/docs/guides/cli-providers.md | Removes user-facing docs references to Codex skills toggling/config. |
| crates/goose/src/providers/codex.rs | Deletes skills flag/config plumbing from Codex provider and updates tests/metadata. |
| crates/goose-cli/src/session/builder.rs | Removes an extra blank line (no functional behavior change). |
Comment on lines
68
to
72
| **Features:** | ||
| - Uses OpenAI's GPT-5 series models (gpt-5.2-codex, gpt-5.2, gpt-5.1-codex-max, gpt-5.1-codex-mini) | ||
| - Configurable reasoning effort levels (low, medium, high) | ||
| - Optional skills support for enhanced capabilities | ||
| - JSON output parsing for structured responses | ||
| - Automatic filtering of goose extensions from system prompts |
There was a problem hiding this comment.
This updates public documentation alongside a code change; per repo policy (.github/copilot-instructions.md:48), documentation changes that track unreleased behavior should be deferred (or hidden/unlisted) until the release that includes the change.
added 3 commits
January 28, 2026 12:30
- Remove unused import of StreamableHttpOptions from session/mod.rs - Fix type mismatch in parse_cli_flag_extensions to accept StreamableHttpOptions These were pre-existing errors on main that are now fixed.
blackgirlbytes
approved these changes
Jan 28, 2026
zanesq
added a commit
that referenced
this pull request
Jan 28, 2026
…ensions * 'main' of github.com:block/goose: chore: re-sync package-lock.json (#6783) upgrade electron to 39.3.0 (#6779) allow skipping providers in test_providers.sh (#6778) fix: enable custom model entry for OpenRouter provider (#6761) Remove codex skills flag support (#6775) Improve mcp test (#6671) Feat/anthropic custom headers (#6774) Fix/GitHub copilot error handling 5845 (#6771) fix(ui): respect width parameter in MCP app size-changed notifications (#6376) fix: address compilation issue in main (#6776)
lifeizhou-ap
added a commit
that referenced
this pull request
Jan 28, 2026
* main: (47 commits) Upgrade error handling (#6747) Fix/filter audience 6703 local (#6773) chore: re-sync package-lock.json (#6783) upgrade electron to 39.3.0 (#6779) allow skipping providers in test_providers.sh (#6778) fix: enable custom model entry for OpenRouter provider (#6761) Remove codex skills flag support (#6775) Improve mcp test (#6671) Feat/anthropic custom headers (#6774) Fix/GitHub copilot error handling 5845 (#6771) fix(ui): respect width parameter in MCP app size-changed notifications (#6376) fix: address compilation issue in main (#6776) Upgrade GitHub Actions for Node 24 compatibility (#6699) fix(google): preserve thought signatures in streaming responses (#6708) added reduce motion support for css animations and streaming text (#6551) fix: Re-enable subagents for Gemini models (#6513) fix(google): use parametersJsonSchema for full JSON Schema support (#6555) fix: respect GOOSE_CLI_MIN_PRIORITY for shell streaming output (#6558) feat: add requires_auth flag for custom providers without authentication (#6705) fix: normalize extension names consistently in ExtensionManager (#6529) ...
michaelneale
added a commit
that referenced
this pull request
Jan 29, 2026
* main: (30 commits) Different approach to determining final confidence level of prompt injection evaluation outcomes (#6729) fix: read_resource_tool deadlock causing test_compaction to hang (#6737) Upgrade error handling (#6747) Fix/filter audience 6703 local (#6773) chore: re-sync package-lock.json (#6783) upgrade electron to 39.3.0 (#6779) allow skipping providers in test_providers.sh (#6778) fix: enable custom model entry for OpenRouter provider (#6761) Remove codex skills flag support (#6775) Improve mcp test (#6671) Feat/anthropic custom headers (#6774) Fix/GitHub copilot error handling 5845 (#6771) fix(ui): respect width parameter in MCP app size-changed notifications (#6376) fix: address compilation issue in main (#6776) Upgrade GitHub Actions for Node 24 compatibility (#6699) fix(google): preserve thought signatures in streaming responses (#6708) added reduce motion support for css animations and streaming text (#6551) fix: Re-enable subagents for Gemini models (#6513) fix(google): use parametersJsonSchema for full JSON Schema support (#6555) fix: respect GOOSE_CLI_MIN_PRIORITY for shell streaming output (#6558) ...
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative for: https://github.com/block/goose/pull/6520/changes
The Codex CLI has removed the skills feature flag in newer versions, making skills always enabled. This change removes the flag handling from the goose codex provider to simplify the code.
Changes:
Skills are now always enabled in Codex CLI, so there's no need for backwards compatibility with older CLI versions that supported the flag.