Skip to content

Revert "fix(1785): enable lto and codegen-units in release build (#65…#6982

Merged
jamadeo merged 1 commit intomainfrom
jackamadeo/revert-build-change
Feb 5, 2026
Merged

Revert "fix(1785): enable lto and codegen-units in release build (#65…#6982
jamadeo merged 1 commit intomainfrom
jackamadeo/revert-build-change

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Feb 5, 2026

…86)"

This reverts commit 79088db.

Release builds are failing with SIGTERM since this change. We should look into making it work, but for now we'll revert until it does.

Copilot AI review requested due to automatic review settings February 5, 2026 15:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous optimization change that added LTO (Link Time Optimization) and reduced codegen-units to 1 for release builds. The revert is needed because release builds have been failing with SIGTERM since the optimization was introduced.

Changes:

  • Removes [profile.release] section with lto = true and codegen-units = 1 from root Cargo.toml

Copy link
Collaborator

@katzdave katzdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@jamadeo jamadeo added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 2e2462a Feb 5, 2026
22 of 23 checks passed
@jamadeo jamadeo deleted the jackamadeo/revert-build-change branch February 5, 2026 16:11
kuccello pushed a commit to kuccello/goose that referenced this pull request Feb 7, 2026
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants