test(mcp): add image tool test and consolidate MCP test fixtures by codefromthecrypt · Pull Request #7019 · block/goose

codefromthecrypt · 2026-02-06T02:26:14Z

Summary

Align provider-level tests (crates/goose/tests/providers.rs) and ACP integration tests (crates/goose-acp/tests/) around tool calling by sharing McpFixtureServer from goose-test-support and consolidating to the same prompts. Then add the missing image test (test_prompt_image) on the ACP side, which can assert an exact value since responses are recorded.

Type of Change

Tests
Refactor / Code quality

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Providers tests now use the same prompt as ACP for basic tool calling:

OLLAMA_HOST=http://localhost:11434 cargo test -p goose --test providers -- test_ollama_provider --nocapture

New ACP Image test that matches the providers test:

RUST_BACKTRACE=full RUST_LOG=debug cargo test -p goose-acp --test server_test -- --nocapture test_prompt_image

Related Issues

Pulls a lot of the diff from #6972
Recording process relates to #6969

Copilot

Pull request overview

This PR consolidates MCP test fixtures into a new shared goose-test-support crate, aligning provider-level tests and ACP integration tests around tool calling. The changes eliminate code duplication by sharing McpFixtureServer and ExpectedSessionId, and add the previously missing image test (test_prompt_image) to the ACP test suite.

Changes:

Created new goose-test-support crate with shared McpFixture, McpFixtureServer, ExpectedSessionId, and test assets
Refactored provider tests to use shared fixtures and consolidated tool/image testing via tool_roundtrip() method
Renamed and reorganized ACP tests for clarity (run_prompt_basic, run_prompt_mcp, run_prompt_image, run_prompt_codemode, run_config_mcp)
Updated Ollama tests to use qwen3-vl:2b model which supports text, tools, and vision
Updated test data files to reflect server name change from lookup to mcp-fixture

Reviewed changes

Copilot reviewed 17 out of 22 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/goose-test-support/Cargo.toml`	New crate with dependencies on axum, rmcp, base64, etc.
`crates/goose-test-support/src/lib.rs`	Exports shared test utilities
`crates/goose-test-support/src/session.rs`	`ExpectedSessionId` for session validation across tests
`crates/goose-test-support/src/mcp.rs`	`McpFixtureServer` with `get_code` and `get_screenshot` tools
`crates/goose-test-support/src/test_assets/test_image.png`	Test image asset for vision tests
`crates/goose-test-support/examples/mcp_fixture_server.rs`	Standalone example for running fixture server
`crates/goose/tests/providers.rs`	Refactored to use shared fixtures and `tool_roundtrip()` method
`crates/goose/src/providers/ollama.rs`	Added `qwen3-vl` to known models list
`crates/goose/Cargo.toml`	Added `goose-test-support` dev dependency
`crates/goose-acp/tests/fixtures/mod.rs`	Removed duplicate code, now uses shared fixtures
`crates/goose-acp/tests/common_tests/mod.rs`	Renamed and reorganized test functions
`crates/goose-acp/tests/server_test.rs`	Updated test function names
`crates/goose-acp/tests/test_data/*.txt`	Updated tool names from `lookup__` to `mcp-fixture__`
`crates/goose-acp/Cargo.toml`	Added `goose-test-support` dev dependency
`Cargo.lock`	Updated dependencies

Copilot

Pull request overview

Copilot reviewed 17 out of 22 changed files in this pull request and generated 2 comments.

crates/goose-test-support/src/mcp.rs

crates/goose/tests/providers.rs

Copilot

Pull request overview

Copilot reviewed 21 out of 26 changed files in this pull request and generated 1 comment.

crates/goose-test-support/src/mcp.rs

michaelneale

makes sense- need to untangle conflicts unfortunately now!

Signed-off-by: Adrian Cole <adrian@tetrate.io>

Copilot

Pull request overview

Copilot reviewed 21 out of 26 changed files in this pull request and generated 1 comment.

crates/goose-test-support/Cargo.toml

* origin/main: (55 commits) test(mcp): add image tool test and consolidate MCP test fixtures (#7019) fix: remove Option from model listing return types, propagate errors (#7074) fix: lazy provider creation for goose acp (#7026) (#7066) Smoke tests: split compaction test and use debug build (#6984) fix(deps): trim bat to resolve RUSTSEC-2024-0320 (#7061) feat: expose AGENT_SESSION_ID env var to extension child processes (#7072) fix: add XML tool call parsing fallback for Qwen3-coder via Ollama (#6882) Remove clippy too_many_lines lint and decompose long functions (#7064) refactor: move disable_session_naming into AgentConfig (#7062) Add global config switch to disable automatic session naming (#7052) docs: add blog post - 8 Things You Didn't Know About Code Mode (#7059) fix: ensure animated elements are visible when prefers-reduced-motion is enabled (#7047) Show recommended model on failture (#7040) feat(ui): add session content search via API (#7050) docs: fix img url (#7053) Desktop UI for deleting custom providers (#7042) Add blog post: How I Used RPI to Build an OpenClaw Alternative (#7051) Remove build-dependencies section from Cargo.toml (#6946) add /rp-why skill blog post (#6997) fix: fix snake_case function names in code_execution instructions (#7035) ... # Conflicts: # scripts/test_subrecipes.sh

* main: added build notify (#6891) test(mcp): add image tool test and consolidate MCP test fixtures (#7019) fix: remove Option from model listing return types, propagate errors (#7074)

* origin/main: (54 commits) chore: strip posthog for sessions/models/daily only (#7079) tidy: clean up old benchmark and add gym (#7081) fix: use command.process_group(0) for CLI providers, not just MCP (#7083) added build notify (#6891) test(mcp): add image tool test and consolidate MCP test fixtures (#7019) fix: remove Option from model listing return types, propagate errors (#7074) fix: lazy provider creation for goose acp (#7026) (#7066) Smoke tests: split compaction test and use debug build (#6984) fix(deps): trim bat to resolve RUSTSEC-2024-0320 (#7061) feat: expose AGENT_SESSION_ID env var to extension child processes (#7072) fix: add XML tool call parsing fallback for Qwen3-coder via Ollama (#6882) Remove clippy too_many_lines lint and decompose long functions (#7064) refactor: move disable_session_naming into AgentConfig (#7062) Add global config switch to disable automatic session naming (#7052) docs: add blog post - 8 Things You Didn't Know About Code Mode (#7059) fix: ensure animated elements are visible when prefers-reduced-motion is enabled (#7047) Show recommended model on failture (#7040) feat(ui): add session content search via API (#7050) docs: fix img url (#7053) Desktop UI for deleting custom providers (#7042) ...

* main: (125 commits) chore: add a new scenario (#7107) fix: Goose Desktop missing Calendar and Reminders entitlements (#7100) Fix 'Edit In Place' and 'Fork Session' features (#6970) Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082) Docs: require auth optional for custom providers (#7098) fix: improve text-muted contrast for better readability (#7095) Always sync bundled extensions (#7057) feat: Add tom (Top Of Mind) platform extension (#7073) chore(docs): update GOOSE_SESSION_ID -> AGENT_SESSION_ID (#6669) fix(ci): switch from cargo-audit to cargo-deny for advisory scanning (#7032) chore(deps): bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /evals/open-model-gym/suite (#7085) chore(deps): bump @modelcontextprotocol/sdk from 1.25.3 to 1.26.0 in /evals/open-model-gym/mcp-harness (#7086) fix: switch to windows msvc (#7080) fix: allow unlisted models for CLI providers (#7090) Use goose port (#7089) chore: strip posthog for sessions/models/daily only (#7079) tidy: clean up old benchmark and add gym (#7081) fix: use command.process_group(0) for CLI providers, not just MCP (#7083) added build notify (#6891) test(mcp): add image tool test and consolidate MCP test fixtures (#7019) ...

* main: (85 commits) Fix 'Edit In Place' and 'Fork Session' features (#6970) Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082) Docs: require auth optional for custom providers (#7098) fix: improve text-muted contrast for better readability (#7095) Always sync bundled extensions (#7057) feat: Add tom (Top Of Mind) platform extension (#7073) chore(docs): update GOOSE_SESSION_ID -> AGENT_SESSION_ID (#6669) fix(ci): switch from cargo-audit to cargo-deny for advisory scanning (#7032) chore(deps): bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /evals/open-model-gym/suite (#7085) chore(deps): bump @modelcontextprotocol/sdk from 1.25.3 to 1.26.0 in /evals/open-model-gym/mcp-harness (#7086) fix: switch to windows msvc (#7080) fix: allow unlisted models for CLI providers (#7090) Use goose port (#7089) chore: strip posthog for sessions/models/daily only (#7079) tidy: clean up old benchmark and add gym (#7081) fix: use command.process_group(0) for CLI providers, not just MCP (#7083) added build notify (#6891) test(mcp): add image tool test and consolidate MCP test fixtures (#7019) fix: remove Option from model listing return types, propagate errors (#7074) fix: lazy provider creation for goose acp (#7026) (#7066) ...

…ck#7019) Signed-off-by: Adrian Cole <adrian@tetrate.io>

codefromthecrypt mentioned this pull request Feb 6, 2026

migrate ACP tests to VCR style session playback #6969

Open

1 task

codefromthecrypt marked this pull request as ready for review February 6, 2026 02:27

Copilot AI review requested due to automatic review settings February 6, 2026 02:27

Copilot started reviewing on behalf of codefromthecrypt February 6, 2026 02:27 View session

codefromthecrypt mentioned this pull request Feb 6, 2026

feat: MCP support for agentic CLI providers #6972

Merged

3 tasks

Copilot AI reviewed Feb 6, 2026

View reviewed changes

codefromthecrypt force-pushed the mcp-tests branch from b6a9eb7 to 8caff81 Compare February 6, 2026 02:41

codefromthecrypt mentioned this pull request Feb 6, 2026

feat(claude-code): use stream-json protocol for persistent sessions #7029

Merged

3 tasks

codefromthecrypt enabled auto-merge February 6, 2026 10:07

Copilot AI review requested due to automatic review settings February 6, 2026 23:03

codefromthecrypt force-pushed the mcp-tests branch from 8caff81 to f8810db Compare February 6, 2026 23:03

Copilot started reviewing on behalf of codefromthecrypt February 6, 2026 23:04 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

crates/goose-test-support/src/mcp.rs Outdated Show resolved Hide resolved

crates/goose/tests/providers.rs Show resolved Hide resolved

codefromthecrypt force-pushed the mcp-tests branch from f8810db to ae7797e Compare February 7, 2026 02:50

Copilot AI review requested due to automatic review settings February 7, 2026 03:17

Copilot started reviewing on behalf of codefromthecrypt February 7, 2026 03:17 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

crates/goose-test-support/src/mcp.rs Outdated Show resolved Hide resolved

codefromthecrypt force-pushed the mcp-tests branch from f54d3c5 to d413216 Compare February 7, 2026 03:27

michaelneale approved these changes Feb 8, 2026

View reviewed changes

test(mcp): add image tool test and consolidate MCP test fixtures

4b7605c

Signed-off-by: Adrian Cole <adrian@tetrate.io>

Copilot AI review requested due to automatic review settings February 9, 2026 01:03

codefromthecrypt force-pushed the mcp-tests branch from d413216 to 4b7605c Compare February 9, 2026 01:03

Copilot started reviewing on behalf of codefromthecrypt February 9, 2026 01:04 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

crates/goose-test-support/Cargo.toml Show resolved Hide resolved

codefromthecrypt added this pull request to the merge queue Feb 9, 2026

Merged via the queue into main with commit 1371f5d Feb 9, 2026
26 checks passed

codefromthecrypt deleted the mcp-tests branch February 9, 2026 01:21

github-actions bot mentioned this pull request Feb 10, 2026

chore(release): release version 1.24.0 (minor) #7102

Open

Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026

test(mcp): add image tool test and consolidate MCP test fixtures (blo…

bf62525

…ck#7019) Signed-off-by: Adrian Cole <adrian@tetrate.io>

Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026

test(mcp): add image tool test and consolidate MCP test fixtures (blo…

c688b66

…ck#7019) Signed-off-by: Adrian Cole <adrian@tetrate.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(mcp): add image tool test and consolidate MCP test fixtures#7019

test(mcp): add image tool test and consolidate MCP test fixtures#7019
codefromthecrypt merged 1 commit intomainfrom
mcp-tests

codefromthecrypt commented Feb 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

michaelneale left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

codefromthecrypt commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

AI Assistance

Testing

Related Issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

michaelneale left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codefromthecrypt commented Feb 6, 2026 •

edited

Loading