fix: fix windows bundle random failure and optimise canary build#7105
fix: fix windows bundle random failure and optimise canary build#7105lifeizhou-ap merged 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to reduce build flakiness on Windows desktop bundling and slightly streamline release artifact collection for canary builds.
Changes:
- Remove
fetch-depth: 0from severalactions/checkoutsteps to avoid full-history clones during CI bundling/build workflows. - Adjust canary release artifact globbing for Flatpak outputs.
- Add a Windows-specific git URL rewrite to prefer GitHub HTTPS when npm installs git-based dependencies.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/canary.yml |
Aligns Flatpak artifact globbing with other packaging globs used for canary releases. |
.github/workflows/bundle-desktop.yml |
Removes full-history checkout for macOS desktop bundle workflow. |
.github/workflows/bundle-desktop-windows.yml |
Removes full-history checkout and adds git URL rewriting to mitigate npm git dependency fetch failures on Windows. |
.github/workflows/bundle-desktop-linux.yml |
Removes full-history checkout for Linux desktop bundle workflow. |
.github/workflows/bundle-desktop-intel.yml |
Removes full-history checkout for Intel macOS desktop bundle workflow. |
.github/workflows/build-cli.yml |
Removes full-history checkout for reusable CLI build workflow. |
| shell: bash | ||
| run: | | ||
| git config --global url."https://github.com/".insteadOf "ssh://git@github.com/" | ||
| git config --global url."https://github.com/".insteadOf "git@github.com:" |
There was a problem hiding this comment.
The npm lockfile contains at least one git+ssh://git@github.com/... dependency (e.g., electron/node-gyp), but this rewrite only covers ssh://git@github.com/ and git@github.com:; add an additional insteadOf rule for git+ssh://git@github.com/ so installs are resilient regardless of how npm passes the URL to git on Windows.
| git config --global url."https://github.com/".insteadOf "git@github.com:" | |
| git config --global url."https://github.com/".insteadOf "git@github.com:" | |
| git config --global url."https://github.com/".insteadOf "git+ssh://git@github.com/" |
This reverts commit 8ca46d5.
| uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 | ||
| with: | ||
| ref: ${{ inputs.ref }} | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
did you mean to do that - will make it a heavier checkout?
There was a problem hiding this comment.
the fetch-depth is heaviest. by default it is fetch-depth:1 which is the shallow fetch
michaelneale
left a comment
There was a problem hiding this comment.
ah ok - yeah fetch depth didn't do what i thought!
…tensions-deeplinks * 'main' of github.com:block/goose: [docs] update authors.yaml file (#7114) Implement manpage generation for goose-cli (#6980) docs: tool output optimization (#7109) Fix duplicated output in Code Mode by filtering content by audience (#7117) Enable tom (Top Of Mind) platform extension by default (#7111) chore: added notification for canary build failure (#7106) fix: fix windows bundle random failure and optimise canary build (#7105) feat(acp): add model selection support for session/new and session/set_model (#7112) fix: isolate claude-code sessions via stream-json session_id (#7108) ci: enable agentic provider live tests (claude-code, codex, gemini-cli) (#7088) docs: codex subscription support (#7104) chore: add a new scenario (#7107) fix: Goose Desktop missing Calendar and Reminders entitlements (#7100) Fix 'Edit In Place' and 'Fork Session' features (#6970) Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082) Docs: require auth optional for custom providers (#7098) fix: improve text-muted contrast for better readability (#7095) Always sync bundled extensions (#7057)
* origin/main: feat: add AGENT=goose environment variable for cross-tool compatibility (#7017) fix: strip empty extensions array when deeplink also (#7096) [docs] update authors.yaml file (#7114) Implement manpage generation for goose-cli (#6980) docs: tool output optimization (#7109) Fix duplicated output in Code Mode by filtering content by audience (#7117) Enable tom (Top Of Mind) platform extension by default (#7111) chore: added notification for canary build failure (#7106) fix: fix windows bundle random failure and optimise canary build (#7105) feat(acp): add model selection support for session/new and session/set_model (#7112) fix: isolate claude-code sessions via stream-json session_id (#7108) ci: enable agentic provider live tests (claude-code, codex, gemini-cli) (#7088) docs: codex subscription support (#7104) chore: add a new scenario (#7107) fix: Goose Desktop missing Calendar and Reminders entitlements (#7100) Fix 'Edit In Place' and 'Fork Session' features (#6970) Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082) # Conflicts: # crates/goose/src/agents/extension.rs
* origin/main: (30 commits) docs: GCP Vertex AI org policy filtering & update OnboardingProviderSetup component (#7125) feat: replace subagent and skills with unified summon extension (#6964) feat: add AGENT=goose environment variable for cross-tool compatibility (#7017) fix: strip empty extensions array when deeplink also (#7096) [docs] update authors.yaml file (#7114) Implement manpage generation for goose-cli (#6980) docs: tool output optimization (#7109) Fix duplicated output in Code Mode by filtering content by audience (#7117) Enable tom (Top Of Mind) platform extension by default (#7111) chore: added notification for canary build failure (#7106) fix: fix windows bundle random failure and optimise canary build (#7105) feat(acp): add model selection support for session/new and session/set_model (#7112) fix: isolate claude-code sessions via stream-json session_id (#7108) ci: enable agentic provider live tests (claude-code, codex, gemini-cli) (#7088) docs: codex subscription support (#7104) chore: add a new scenario (#7107) fix: Goose Desktop missing Calendar and Reminders entitlements (#7100) Fix 'Edit In Place' and 'Fork Session' features (#6970) Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082) Docs: require auth optional for custom providers (#7098) ...
Summary
This PR updates GitHub Actions workflows to reduce build flakiness on Windows desktop bundling with npm install and optimise the canary workflow
Changes:
Type of Change