fix: fix windows bundle random failure and optimise canary build (#7105)#7119
Merged
lifeizhou-ap merged 1 commit intorelease/1.24.0from Feb 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI/release workflows to improve reliability of Windows desktop bundling and reduce overhead in release artifact collection, while also removing the scheduled nightly workflow.
Changes:
- Add a Git config override in the Windows desktop bundling workflow to force HTTPS for GitHub-based npm git dependencies.
- Optimize canary release artifact globbing for Flatpak artifacts.
- Reduce checkout cost in multiple reusable workflows by removing
fetch-depth: 0, and delete theNightly Buildworkflow.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/nightly.yml | Removes the scheduled nightly build/release workflow. |
| .github/workflows/canary.yml | Adjusts release artifact glob for Flatpak to a non-recursive pattern. |
| .github/workflows/bundle-desktop.yml | Removes full-history checkout. |
| .github/workflows/bundle-desktop-intel.yml | Removes full-history checkout. |
| .github/workflows/bundle-desktop-linux.yml | Removes full-history checkout. |
| .github/workflows/bundle-desktop-windows.yml | Removes full-history checkout; adds HTTPS rewrite for GitHub npm git dependencies. |
| .github/workflows/build-cli.yml | Removes full-history checkout. |
Comment on lines
121
to
123
| *.rpm | ||
| **/*.flatpak | ||
| *.flatpak | ||
| download_cli.sh |
There was a problem hiding this comment.
This PR deletes the scheduled Nightly Build workflow (.github/workflows/nightly.yml), which isn’t reflected in the PR title/description and could be an unintended operational change; either restore the workflow or explicitly document/justify its removal in the PR metadata (and consider a separate PR if it’s not part of the Windows/canary fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.