Skip to content

refactor: remove allows_unlisted_models flag, always allow custom model entry#7255

Merged
codefromthecrypt merged 1 commit intoblock:mainfrom
clayarnoldg2m:refactor/7103-remove-allows-unlisted-models
Feb 22, 2026
Merged

refactor: remove allows_unlisted_models flag, always allow custom model entry#7255
codefromthecrypt merged 1 commit intoblock:mainfrom
clayarnoldg2m:refactor/7103-remove-allows-unlisted-models

Conversation

@clayarnoldg2m
Copy link
Contributor

@clayarnoldg2m clayarnoldg2m commented Feb 16, 2026

Summary

  • Removes the allows_unlisted_models field from ProviderMetadata and its with_unlisted_models() builder method
  • All providers now always allow users to enter custom model names not in the fetched list
  • Simplifies CLI configure.rs to unconditionally show "Enter a model not listed..." option
  • Updates RecipeModelSelector.tsx and SwitchModelModal.tsx to always show custom model entry
  • Regenerates OpenAPI schema and TypeScript types (field fully removed from API)
  • 16 files changed, 56 deletions, 16 insertions

Test plan

  • cargo clippy --all-targets -- -D warnings — clean
  • cargo test — passes (2 pre-existing integration failures: claude_code, xai)
  • npx tsc --noEmit — clean
  • just generate-openapi — regenerated, no allows_unlisted_models references remain

Fixes #7103

🤖 Generated with Claude Code

@clayarnoldg2m @claude
refactor: remove allows_unlisted_models flag, always allow custom mod…
6a45b47 
…el entry

Remove the allows_unlisted_models field from ProviderMetadata and its
with_unlisted_models() builder. All providers now always allow users to
enter custom model names not in the fetched list.

Changes:
- Remove field, builder, and defaults from base.rs
- Remove .with_unlisted_models() from 7 providers
- Simplify configure.rs to always show "Enter a model not listed..."
- Clean up provider_registry.rs and test mocks
- Update RecipeModelSelector.tsx and SwitchModelModal.tsx
- Regenerate OpenAPI schema and TypeScript types

Fixes block#7103

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: clayarnoldg2m <carnold@g2m.ai>
@michaelneale
Copy link
Collaborator

michaelneale commented Feb 19, 2026

I am ok with this - I can see that we have been adding the flag one by one, but why even have it? this reduces complexity, I like it, but @codefromthecrypt - you ok with it? stamp if you think so

codefromthecrypt
codefromthecrypt approved these changes Feb 22, 2026
View reviewed changes
Copy link
Collaborator

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@codefromthecrypt codefromthecrypt added this pull request to the merge queue Feb 22, 2026
Merged via the queue into block:main with commit aa05308 Feb 22, 2026
19 checks passed
michaelneale added a commit that referenced this pull request Feb 23, 2026
@michaelneale
Merge branch 'main' into gateway-abstraction
2146e6d 
* main: (27 commits)
  dev: add cmake to hermitized env (#7399)
  refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255)
  feat: expose context window utilization to agent via MOIM (#7418)
  Small model naming (#7394)
  chore(deps): bump ajv in /documentation (#7416)
  doc: groq models (#7404)
  Client settings (#7381)
  Fix settings tabs getting cut off in narrow windows (#7379)
  docs: voice dictation updates (#7396)
  [docs] Add Excalidraw MCP App Tutorial (#7401)
  Post release checklist as a comment on release PRs (#7307)
  unique api key (#7391)
  fix: use correct colors for download progress bar (#7390)
  Add local model settings access from bottom bar model menu (#7378)
  Change Recipe Security Scanner API key (#7387)
  switch Ask AI Discord bot from openrouter to anthropic (#7386)
  feat(ui): show token counts directly for "free" providers (#7383)
  Update creator note (#7384)
  Remove display_name from local model API and use model ID everywhere (#7382)
  fix(summon): stop MOIM from telling models to sleep while waiting for tasks (#7377)
  ...
lifeizhou-ap added a commit that referenced this pull request Feb 23, 2026
@lifeizhou-ap
Merge branch 'main' into lifei/simplify_onboarding_flow
500f7d6 
* main: (73 commits)
  dev: add cmake to hermitized env (#7399)
  refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255)
  feat: expose context window utilization to agent via MOIM (#7418)
  Small model naming (#7394)
  chore(deps): bump ajv in /documentation (#7416)
  doc: groq models (#7404)
  Client settings (#7381)
  Fix settings tabs getting cut off in narrow windows (#7379)
  docs: voice dictation updates (#7396)
  [docs] Add Excalidraw MCP App Tutorial (#7401)
  Post release checklist as a comment on release PRs (#7307)
  unique api key (#7391)
  fix: use correct colors for download progress bar (#7390)
  Add local model settings access from bottom bar model menu (#7378)
  Change Recipe Security Scanner API key (#7387)
  switch Ask AI Discord bot from openrouter to anthropic (#7386)
  feat(ui): show token counts directly for "free" providers (#7383)
  Update creator note (#7384)
  Remove display_name from local model API and use model ID everywhere (#7382)
  fix(summon): stop MOIM from telling models to sleep while waiting for tasks (#7377)
  ...
zanesq added a commit that referenced this pull request Feb 23, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into zane/hide-voice-pr…
d2c28d5 
…oviders

* 'main' of github.com:block/goose:
  New navigation settings layout options and styling (#6645)
  refactor: MCP-compliant theme tokens and CSS class rename (#7275)
  Redirect llama.cpp logs through tracing to avoid polluting CLI stdout/stderr (#7434)
  refactor: change open recipe in new window to pass recipe id (#7392)
  fix: handle truncated tool calls that break conversation alternation (#7424)
  streamline some github actions (#7430)
  Enable bedrock prompt cache (#6710)
  fix: use BEGIN IMMEDIATE to prevent SQLite deadlocks (#7429)
  Display working dir (#7419)
  dev: add cmake to hermitized env (#7399)
  refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255)
  feat: expose context window utilization to agent via MOIM (#7418)
  Small model naming (#7394)
  chore(deps): bump ajv in /documentation (#7416)
  doc: groq models (#7404)
  Client settings (#7381)
  Fix settings tabs getting cut off in narrow windows (#7379)

# Conflicts:
#	ui/desktop/src/components/settings/dictation/DictationSettings.tsx
michaelneale added a commit that referenced this pull request Feb 23, 2026
@michaelneale
Merge remote-tracking branch 'origin/main' into micn/simpler-local-te…
1880cf3 
…xt-edit

* origin/main: (35 commits)
  docs: generate manpages (#7443)
  Blog/goose v1 25 0 release (#7433)
  fix: detect truncated LLM responses in apps extension (#7354)
  fix: removed unnecessary version for goose acp macro dependency (#7428)
  add flag to hide select voice providers (#7406)
  New navigation settings layout options and styling (#6645)
  refactor: MCP-compliant theme tokens and CSS class rename (#7275)
  Redirect llama.cpp logs through tracing to avoid polluting CLI stdout/stderr (#7434)
  refactor: change open recipe in new window to pass recipe id (#7392)
  fix: handle truncated tool calls that break conversation alternation (#7424)
  streamline some github actions (#7430)
  Enable bedrock prompt cache (#6710)
  fix: use BEGIN IMMEDIATE to prevent SQLite deadlocks (#7429)
  Display working dir (#7419)
  dev: add cmake to hermitized env (#7399)
  refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255)
  feat: expose context window utilization to agent via MOIM (#7418)
  Small model naming (#7394)
  chore(deps): bump ajv in /documentation (#7416)
  doc: groq models (#7404)
  ...
aharvard added a commit that referenced this pull request Feb 24, 2026
@aharvard
Merge remote-tracking branch 'origin/main' into aharvard/display-modes
15f9097 
* origin/main: (49 commits)
  add flag to hide select voice providers (#7406)
  New navigation settings layout options and styling (#6645)
  refactor: MCP-compliant theme tokens and CSS class rename (#7275)
  Redirect llama.cpp logs through tracing to avoid polluting CLI stdout/stderr (#7434)
  refactor: change open recipe in new window to pass recipe id (#7392)
  fix: handle truncated tool calls that break conversation alternation (#7424)
  streamline some github actions (#7430)
  Enable bedrock prompt cache (#6710)
  fix: use BEGIN IMMEDIATE to prevent SQLite deadlocks (#7429)
  Display working dir (#7419)
  dev: add cmake to hermitized env (#7399)
  refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255)
  feat: expose context window utilization to agent via MOIM (#7418)
  Small model naming (#7394)
  chore(deps): bump ajv in /documentation (#7416)
  doc: groq models (#7404)
  Client settings (#7381)
  Fix settings tabs getting cut off in narrow windows (#7379)
  docs: voice dictation updates (#7396)
  [docs] Add Excalidraw MCP App Tutorial (#7401)
  ...

# Conflicts:
#	ui/desktop/src/components/McpApps/McpAppRenderer.tsx
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees

@codefromthecrypt codefromthecrypt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove allows_unlisted_models — always allow custom model entry

3 participants

@clayarnoldg2m @michaelneale @codefromthecrypt