fix: detect truncated LLM responses in apps extension#7354
Merged
DOsinga merged 2 commits intoblock:mainfrom Feb 23, 2026
Merged
fix: detect truncated LLM responses in apps extension#7354DOsinga merged 2 commits intoblock:mainfrom
DOsinga merged 2 commits intoblock:mainfrom
Conversation
Contributor
Author
|
should return a meaninful error message now @DOsinga |
DOsinga
approved these changes
Feb 23, 2026
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
thanks. can you remove the tests?
Signed-off-by: Cody <166262726+kowirth@users.noreply.github.com> Signed-off-by: Cody <251773092+fresh3nough@users.noreply.github.com>
Signed-off-by: Cody <251773092+fresh3nough@users.noreply.github.com>
fresh3nough
force-pushed
the
fix/7239-cli-progress-max-tokens
branch
from
369cf86 to
ef69782
Compare
Contributor
Author
|
removed @DOsinga |
Collaborator
|
thanks @fresh3nough ! |
Contributor
Author
|
np :) |
michaelneale
added a commit
that referenced
this pull request
Feb 23, 2026
…xt-edit * origin/main: (35 commits) docs: generate manpages (#7443) Blog/goose v1 25 0 release (#7433) fix: detect truncated LLM responses in apps extension (#7354) fix: removed unnecessary version for goose acp macro dependency (#7428) add flag to hide select voice providers (#7406) New navigation settings layout options and styling (#6645) refactor: MCP-compliant theme tokens and CSS class rename (#7275) Redirect llama.cpp logs through tracing to avoid polluting CLI stdout/stderr (#7434) refactor: change open recipe in new window to pass recipe id (#7392) fix: handle truncated tool calls that break conversation alternation (#7424) streamline some github actions (#7430) Enable bedrock prompt cache (#6710) fix: use BEGIN IMMEDIATE to prevent SQLite deadlocks (#7429) Display working dir (#7419) dev: add cmake to hermitized env (#7399) refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255) feat: expose context window utilization to agent via MOIM (#7418) Small model naming (#7394) chore(deps): bump ajv in /documentation (#7416) doc: groq models (#7404) ...
lifeizhou-ap
added a commit
that referenced
this pull request
Feb 24, 2026
* main: Simplified custom model flow with canonical models (#6934) feat: simplify the text editor to be more like pi (#7426) docs: add YouTube short embed to Neighborhood extension tutorial (#7456) fix: flake.nix build failure and deprecation warning (#7408) feat(claude-code): add permission prompt routing for approve mode (#7420) docs: generate manpages (#7443) Blog/goose v1 25 0 release (#7433) fix: detect truncated LLM responses in apps extension (#7354) fix: removed unnecessary version for goose acp macro dependency (#7428) add flag to hide select voice providers (#7406) New navigation settings layout options and styling (#6645) refactor: MCP-compliant theme tokens and CSS class rename (#7275) Redirect llama.cpp logs through tracing to avoid polluting CLI stdout/stderr (#7434) refactor: change open recipe in new window to pass recipe id (#7392) fix: handle truncated tool calls that break conversation alternation (#7424) streamline some github actions (#7430) Enable bedrock prompt cache (#6710) fix: use BEGIN IMMEDIATE to prevent SQLite deadlocks (#7429) Display working dir (#7419)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds truncation detection to the apps extension's inner LLM calls. When the LLM response hits the token limit before generating complete app content, users now get a clear error message instead of the cryptic
missing field \html`` serde error.Closes #7239
Changes
generate_new_app_content()andgenerate_updated_app_content(), check ifoutput_tokens >= max_tokensafter the LLM call and return a descriptive error when truncation is detectedextract_tool_responsecovering both truncated (missinghtml) and complete responsesNote: the
max_tokens = Some(16384)fix for the inner LLM calls was already merged to main via #7247.How to test
cargo test -p goose -- agents::platform_extensions::apps::testsReproduction
databricks-claude-opus-4-6)Error: Failed to parse tool response: missing field \html``App content generation was truncated because the response hit the token limiterror