Skip to content

Comments

fix(summon): restore skill supporting files and directory path in load output#7457

Merged
angiejones merged 1 commit intomainfrom
fix/summon-skill-supporting-files
Feb 24, 2026
Merged

fix(summon): restore skill supporting files and directory path in load output#7457
angiejones merged 1 commit intomainfrom
fix/summon-skill-supporting-files

Conversation

@angiejones
Copy link
Collaborator

Summary

When the unified summon extension replaced skills_extension in v1.25.0 (#6964), skill loading stopped communicating the skill directory path and supporting files (scripts, templates, etc.) to the agent. This caused the agent to load the skill content successfully but then have no idea where bundled scripts live, leading it to search the entire filesystem.

Restores the old behavior by collecting supporting files during skill discovery and including the skill directory + file listing in the load output.

Type of Change

  • Bug fix
  • Feature
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

  • All 9 existing summon unit tests pass
  • New test_skill_supporting_files_discovered test verifies skills with bundled files get their directory path and supporting files populated correctly

Related Issues

Regression introduced in #6964

…d output

When the unified summon extension replaced skills_extension in v1.25.0,
the skill directory path and supporting files (scripts, templates, etc.)
were no longer communicated to the agent on load. This caused the agent
to not know where bundled scripts live, leading it to search the filesystem.

- Add supporting_files field to Source
- Collect supporting files when scanning skill directories
- Store skill_dir (not SKILL.md path) as the source path
- Include directory and file listing in handle_load_source output
Copilot AI review requested due to automatic review settings February 24, 2026 00:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression introduced in #6964 where skill loading stopped communicating the skill directory path and supporting files to the agent. After the unified summon extension replaced the old skills_extension, skills would load successfully but the agent wouldn't know where bundled scripts and templates were located.

Changes:

  • Added supporting_files field to Source struct to track supplementary files (scripts, templates, etc.)
  • Implemented find_supporting_files() to discover supporting files in skill directories (recursing one level into subdirectories)
  • Modified skill discovery to store the skill directory path instead of the SKILL.md file path, and populate supporting files list
  • Updated load output to display skill directory path and list of available supporting files
  • Added comprehensive test coverage for the new functionality

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @angiejones.

I wonder what other agents do - I guess it is convenient to list them in one go like this (could also just put it to root of dir and let whatever FS tool find it - pi does that, but this way is probably snappier, as long as we don't blow up the context with content of files but it should be reading them progressively on demand still).

@angiejones
Copy link
Collaborator Author

good catch @angiejones.

I wonder what other agents do - I guess it is convenient to list them in one go like this (could also just put it to root of dir and let whatever FS tool find it - pi does that, but this way is probably snappier, as long as we don't blow up the context with content of files but it should be reading them progressively on demand still).

yeah, followed the spec to do the 3 tier progressive disclosure. load output would be something like

## Supporting Files

Skill directory: /path/to/.goose/skills/my-skill

The following supporting files are available:
- myscript.sh
- templates/report.txt

Use the file tools to read these files or run scripts as directed.

@angiejones angiejones added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 359c5fb Feb 24, 2026
24 checks passed
@angiejones angiejones deleted the fix/summon-skill-supporting-files branch February 24, 2026 02:57
lifeizhou-ap added a commit that referenced this pull request Feb 24, 2026
* main: (171 commits)
  fix: TLDR CLI tab in Neighborhood MCP docs (#7461)
  fix(summon): restore skill supporting files and directory path in load output (#7457)
  Simplified custom model flow with canonical models (#6934)
  feat: simplify the text editor to be more like pi (#7426)
  docs: add YouTube short embed to Neighborhood extension tutorial (#7456)
  fix: flake.nix build failure and deprecation warning (#7408)
  feat(claude-code): add permission prompt routing for approve mode (#7420)
  docs: generate manpages (#7443)
  Blog/goose v1 25 0 release (#7433)
  fix: detect truncated LLM responses in apps extension (#7354)
  fix: removed unnecessary version for goose acp macro dependency (#7428)
  add flag to hide select voice providers (#7406)
  New navigation settings layout options and styling (#6645)
  refactor: MCP-compliant theme tokens and CSS class rename (#7275)
  Redirect llama.cpp logs through tracing to avoid polluting CLI stdout/stderr (#7434)
  refactor: change open recipe in new window to pass recipe id (#7392)
  fix: handle truncated tool calls that break conversation alternation (#7424)
  streamline some github actions (#7430)
  Enable bedrock prompt cache (#6710)
  fix: use BEGIN IMMEDIATE to prevent SQLite deadlocks (#7429)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants