Conversation
Add ENABLE_TOOL_PAIR_SUMMARIZATION constant set to false to disable the tool call/response summarization feature. The code is preserved and can be re-enabled by setting the flag back to true.
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the tool-pair summarization path in goose context management as a hotfix, while leaving the existing summarization implementation in place for later re-enablement.
Changes:
- Introduces a module-level
ENABLE_TOOL_PAIR_SUMMARIZATIONconstant set tofalse. - Adds an early return in
maybe_summarize_tool_pair()so summarization becomes a no-op when disabled.
Comment on lines
+517
to
+521
| // Tool pair summarization is currently disabled via feature flag. | ||
| // See ENABLE_TOOL_PAIR_SUMMARIZATION constant above. | ||
| if !ENABLE_TOOL_PAIR_SUMMARIZATION { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Because ENABLE_TOOL_PAIR_SUMMARIZATION is a const set to false, the if !ENABLE_TOOL_PAIR_SUMMARIZATION { return None; } makes the rest of this async block statically unreachable, which will trigger an unreachable_code warning (and likely fail CI with -D warnings). Consider gating the code with #[cfg(feature = ...)]/#[cfg(not(...))] or making the flag non-const (e.g., env/config-driven, or an AtomicBool load) so the compiler doesn’t treat the remainder as unreachable.
michaelneale
approved these changes
Feb 24, 2026
zanesq
added a commit
that referenced
this pull request
Feb 26, 2026
…m-cache * 'main' of github.com:block/goose: fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) Disable tool pair summarization (#7481)
benthecarman
pushed a commit
to benthecarman/goose
that referenced
this pull request
Feb 27, 2026
tlongwell-block
added a commit
that referenced
this pull request
Feb 27, 2026
…patible * origin/main: (70 commits) feat: allow goose askai bot to search goose codebase (#7508) Revert "Reapply "fix: prevent crashes in long-running Electron sessions"" Reapply "fix: prevent crashes in long-running Electron sessions" Revert "fix: prevent crashes in long-running Electron sessions" fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) fix: prevent crashes in long-running Electron sessions Disable tool pair summarization (#7481) fix: New Recipe Warning does not close on cancel (#7524) The client is not the source of truth (#7438) feat: support Anthropic adaptive thinking (#7356) copilot instructions: reword no prerelease docs (#7101) fix(acp): don't fail session creation when model listing is unavailable (#7484) feat: simplify developer extension (#7466) feat: add goose-powered release notes generator workflow (#7503) ... # Conflicts: # Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the tool pair summarization feature via a feature flag while keeping all the code intact.
Changes
ENABLE_TOOL_PAIR_SUMMARIZATIONconstant (set tofalse) incrates/goose/src/context_mgmt/mod.rsmaybe_summarize_tool_pair()that checks the flag, making the function a no-op when disabledtrueWhy
Hotfix to turn off tool summarization until stability issues are resolved.