fix: New Recipe Warning does not close on cancel#7524
Merged
Conversation
angiejones
approved these changes
Feb 26, 2026
auto-merge was automatically disabled
February 26, 2026 16:59
Pull request was closed
tlongwell-block
added a commit
that referenced
this pull request
Feb 27, 2026
…patible * origin/main: (70 commits) feat: allow goose askai bot to search goose codebase (#7508) Revert "Reapply "fix: prevent crashes in long-running Electron sessions"" Reapply "fix: prevent crashes in long-running Electron sessions" Revert "fix: prevent crashes in long-running Electron sessions" fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) fix: prevent crashes in long-running Electron sessions Disable tool pair summarization (#7481) fix: New Recipe Warning does not close on cancel (#7524) The client is not the source of truth (#7438) feat: support Anthropic adaptive thinking (#7356) copilot instructions: reword no prerelease docs (#7101) fix(acp): don't fail session creation when model listing is unavailable (#7484) feat: simplify developer extension (#7466) feat: add goose-powered release notes generator workflow (#7503) ... # Conflicts: # Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7523
Summary
Issue #7523 Fix Summary: New Recipe Warning does not close on cancel
Problem
The New Recipe Warning dialog did not close when clicking the Cancel button. The background page would reset, but the dialog would persist on screen.
Root Cause
The
RecipeWarningModal.tsxcomponent was missing theonOpenChangehandler on its<Dialog>component. Without this handler, the dialog's internal state changes (triggered by user interaction) were not propagating to the parent component's state.Solution
Added the
onOpenChangehandler to the Dialog component inRecipeWarningModal.tsx:This pattern matches how other modal components in the codebase handle dialog state (e.g.,
ConfirmationModal.tsx).Files Changed
ui/desktop/src/components/ui/RecipeWarningModal.tsx- AddedonOpenChangehandlerVerification
npm run typecheck)npm test)npm run lint)Generated by goose Issue Solver