Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load shell automatically from env for GUI #948

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

michaelneale
Copy link
Collaborator

@michaelneale michaelneale commented Jan 30, 2025

Shell should be loaded to be the same as an interactive shell for goose - not hard coded to zsh. This is a fiddly one to test, need to try it both dev time and bundled, so took a few iterations (the command will run an interactive shell to capture env the first time, vs just sourcing ~/.zshrc - as not everyone puts vars in there, and not everyone uses zsh)

fixes:

#948

* main:
  chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959)
  chore: remove o1-mini suggestion from UI add model view (#957)
  fix: missing field in request (#956)
  docs: update provider docs, fix rate limit link (#943)
  fix: clarify linux cli install only (#927)
  feat: update ui for ollama host (#912)
  feat: add CONFIGURE=false option in install script (#920)
  fix: truncation agent token calculations (#915)
  fix: request payload for o1 models (#921)
@michaelneale
Copy link
Collaborator Author

.bundle

Copy link

⚠️ Cannot proceed with operation

  • reviewDecision: skip_reviews
  • commitStatus: PENDING

Reviews are not required for this operation but CI checks must be passing in order to continue

Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I knew it would be something like this, but couldn't put my finger on the solution. Thanks @michaelneale!

@michaelneale
Copy link
Collaborator Author

.bundle

2 similar comments
@michaelneale
Copy link
Collaborator Author

.bundle

@michaelneale
Copy link
Collaborator Author

.bundle

@michaelneale michaelneale merged commit 928dc3d into main Jan 31, 2025
4 checks passed
@michaelneale michaelneale deleted the micn/fix-load-shell-gui branch January 31, 2025 00:38
michaelneale added a commit that referenced this pull request Jan 31, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* main:
  chore: bump patch version to 1.0.3 (#967)
  fix: load shell automatically from env for GUI (#948)
michaelneale added a commit that referenced this pull request Jan 31, 2025
* main: (28 commits)
  ci: per semver build metadata should be after + (#971)
  fix: temp fix to make CI workflow pass (#970)
  chore: bump patch version to 1.0.3 (#967)
  fix: load shell automatically from env for GUI (#948)
  fix: update versions in release and canary workflows (#911)
  docs: fix typo, name (#963)
  docs: typo fix (#961)
  chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959)
  chore: remove o1-mini suggestion from UI add model view (#957)
  fix: missing field in request (#956)
  docs: update provider docs, fix rate limit link (#943)
  fix: clarify linux cli install only (#927)
  feat: update ui for ollama host (#912)
  feat: add CONFIGURE=false option in install script (#920)
  fix: truncation agent token calculations (#915)
  fix: request payload for o1 models (#921)
  Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888)
  fix: improve configure process with error message (#919)
  docs: Goose on Windows via WSL (#901)
  fix: more graceful handling of missing usage in provider response (#907)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants