fix: update versions in release and canary workflows #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lily-de I wish github would report when workflows syntax is wrong: https://github.com/block/goose/actions/runs/13040105120 is a silent failure otherwise |
kalvinnchau
reviewed
Jan 29, 2025
There was a problem hiding this comment.
should we evaluate something like https://github.com/crate-ci/cargo-release for helping with cargo version changes (instead of sed?)
.github/workflows/release.yml
Outdated
| run: | | ||
| git config --global user.name "github-actions" | ||
| git config --global user.email "github-actions@github.com" | ||
| git commit -am "Update versions to ${{ needs.prepare-version.outputs.version }}" |
There was a problem hiding this comment.
nit: should we be more explicit and select the exact files we're committing (Cargo.toml and ui/desktop/package.json) just in case other things change
salman1993
changed the title
kalvinnchau
reviewed
Jan 30, 2025
Comment on lines
+31
to
+34
| # Something like "1.0.0-canary.<short sha>" | ||
| SHORT_SHA=$(echo "${GITHUB_SHA}" | cut -c1-7) | ||
| VERSION="1.0.0-canary.${SHORT_SHA}" | ||
| echo "version=$VERSION" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
we can use the git describe method to get the latest tag
❯ git describe --tags --abbrev=0
v1.0.2
something like
SHORT_SHA=$(echo "${GITHUB_SHA}" | cut -c1-7)
LATEST_TAG=$(git describe --tags --abbrev=0)
# Strip the leading 'v' if it exists
CLEAN_TAG=${LATEST_TAG#v}
VERSION="${CLEAN_TAG}-canary.${SHORT_SHA}"
echo "version=$VERSION" >> $GITHUB_OUTPUT
* origin/main: fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921) Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888) fix: improve configure process with error message (#919) docs: Goose on Windows via WSL (#901) fix: more graceful handling of missing usage in provider response (#907) feat: rm uv.lock cause it points to square artifactory (#917) feat: Update issue templates for bug report for goose (#913) fix: post endpoint url on sse endpoint event (#900)
kalvinnchau
approved these changes
Jan 31, 2025
michaelneale
added a commit
that referenced
this pull request
Jan 31, 2025
* main: (28 commits) ci: per semver build metadata should be after + (#971) fix: temp fix to make CI workflow pass (#970) chore: bump patch version to 1.0.3 (#967) fix: load shell automatically from env for GUI (#948) fix: update versions in release and canary workflows (#911) docs: fix typo, name (#963) docs: typo fix (#961) chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959) chore: remove o1-mini suggestion from UI add model view (#957) fix: missing field in request (#956) docs: update provider docs, fix rate limit link (#943) fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921) Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888) fix: improve configure process with error message (#919) docs: Goose on Windows via WSL (#901) fix: more graceful handling of missing usage in provider response (#907) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
workflow succeeded: https://github.com/block/goose/actions/runs/13045348906
test release (draft) - tagged it as
test.1.0.1: https://github.com/block/goose/releases/tag/untagged-fe0426d4b3b96b1ddc30downloaded the CLI and App. looks like the version injections worked:
