Skip to content

Commit

Permalink
Merge pull request #734 from blue-yonder/bugfix/coveralls-pr-action
Browse files Browse the repository at this point in the history
Change the coveralls github action to fix missing coveralls in PRs
  • Loading branch information
nils-braun authored Jul 18, 2020
2 parents 535de97 + 096e53a commit 384b719
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 32 deletions.
18 changes: 3 additions & 15 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- name: Test with pytest
run: |
pytest --junitxml=junit/test-results-${{ matrix.python-version }}-${{ matrix.installation }}.xml tests
pytest --junitxml=junit/test-results-${{ matrix.python-version }}-${{ matrix.installation }}.xml --cov-report=xml tests
- name: Upload pytest test results
uses: actions/upload-artifact@v1
Expand All @@ -96,17 +96,5 @@ jobs:
# Use always() to always run this step to publish test results when there are test failures
if: ${{ always() }}

- name: Coveralls
uses: AndreMiras/coveralls-python-action@develop
with:
parallel: true

coveralls_finish:
name: Coveralls Finished
needs: test
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: AndreMiras/coveralls-python-action@develop
with:
parallel-finished: true
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
18 changes: 3 additions & 15 deletions .github/workflows/test_all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
run: |
# Include notebook tests
export TEST_NOTEBOOKS=y
pytest --junitxml=junit/test-results.xml tests
pytest --junitxml=junit/test-results.xml --cov-report=xml tests
- name: Upload pytest test results
uses: actions/upload-artifact@v1
Expand All @@ -49,17 +49,5 @@ jobs:
# Use always() to always run this step to publish test results when there are test failures
if: ${{ always() }}

- name: Coveralls
uses: AndreMiras/coveralls-python-action@develop
with:
parallel: true

coveralls_finish:
name: Coveralls Finished
needs: test
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: AndreMiras/coveralls-python-action@develop
with:
parallel-finished: true
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ We changed the default branch from "master" to "main".
- Fix spark and dask after #705 and for non-id named id columns (#712)
- Fix in the forecasting notebook (#729)
- Let tsfresh choose the value column if possible (#722)
- Move from coveralls github action to codecov (#734)

Version 0.16.0
==============
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

[![Documentation Status](https://readthedocs.org/projects/tsfresh/badge/?version=latest)](https://tsfresh.readthedocs.io/en/latest/?badge=latest)
[![Build Status](https://github.com/blue-yonder/tsfresh/workflows/Test%20Default%20Branch/badge.svg)](https://github.com/blue-yonder/tsfresh/actions)
[![Coverage Status](https://coveralls.io/repos/github/blue-yonder/tsfresh/badge.svg?branch=main)](https://coveralls.io/github/blue-yonder/tsfresh?branch=main)
[![codecov](https://codecov.io/gh/blue-yonder/tsfresh/branch/main/graph/badge.svg)](https://codecov.io/gh/blue-yonder/tsfresh)
[![license](https://img.shields.io/github/license/mashape/apistatus.svg)](https://github.com/blue-yonder/tsfresh/blob/main/LICENSE.txt)
[![Gitter chat](https://badges.gitter.im/tsfresh/Lobby.svg)](https://gitter.im/tsfresh/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link)
[![py352 status](https://img.shields.io/badge/python3.5.2-supported-green.svg)](https://github.com/blue-yonder/tsfresh/issues/8)
Expand Down
1 change: 0 additions & 1 deletion test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ seaborn>=0.7.1
ipython>=5.3.0
notebook>=4.4.1
pandas-datareader>=0.5.0
coveralls

0 comments on commit 384b719

Please sign in to comment.