Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the coveralls github action to fix missing coveralls in PRs #734

Merged
merged 4 commits into from
Jul 18, 2020

Conversation

nils-braun
Copy link
Collaborator

@nils-braun nils-braun commented Jul 18, 2020

I moved from coveralls to codecov, as it has better support for forked branches (to help solving #732) and because it has a nicer UI ;-)

@github-actions
Copy link

github-actions bot commented Jul 18, 2020

Result of Benchmark Tests

Benchmark Min Max Mean Mean on Repo HEAD
tests/benchmark.py::test_benchmark_small_data 11.45 12.53 12.05 +- 0.55 12.66 +- 0.25
tests/benchmark.py::test_benchmark_large_data 6.12 6.22 6.17 +- 0.04 6.15 +- 0.08
tests/benchmark.py::test_benchmark_with_selection 8.16 8.25 8.20 +- 0.04 8.45 +- 0.07

@nils-braun nils-braun force-pushed the bugfix/coveralls-pr-action branch 2 times, most recently from fe4779f to 3568793 Compare July 18, 2020 17:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@535de97). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage        ?   96.28%           
=======================================
  Files           ?       18           
  Lines           ?     1695           
  Branches        ?      322           
=======================================
  Hits            ?     1632           
  Misses          ?       31           
  Partials        ?       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535de97...c239860. Read the comment docs.

@nils-braun nils-braun force-pushed the bugfix/coveralls-pr-action branch from 3568793 to d3f5df0 Compare July 18, 2020 17:07
@nils-braun nils-braun merged commit 384b719 into main Jul 18, 2020
@nils-braun nils-braun deleted the bugfix/coveralls-pr-action branch July 18, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants