Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: implement EIP-2935 (#1354)" #1424

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented May 16, 2024

This reverts to commit 3e089f3.

Ref to: https://notes.ethereum.org/@rudolf/2935-gas-cost
Option2 is chosen so these changes need to be removed.

Copy link
Contributor

github-actions bot commented May 16, 2024

Valgrind Results:

==3808== Cachegrind, a cache and branch-prediction profiler
==3808== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3808== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3808== Command: target/release/snailtracer
==3808== 
--3808-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.794201531s
==3808== 
==3808== I   refs:      429,370,602
==3808== I1  misses:          3,114
==3808== LLi misses:          2,791
==3808== I1  miss rate:        0.00%
==3808== LLi miss rate:        0.00%
==3808== 
==3808== D   refs:      206,204,679  (133,650,395 rd   + 72,554,284 wr)
==3808== D1  misses:        320,920  (    181,328 rd   +    139,592 wr)
==3808== LLd misses:        137,579  (      4,273 rd   +    133,306 wr)
==3808== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==3808== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3808== 
==3808== LL refs:           324,034  (    184,442 rd   +    139,592 wr)
==3808== LL misses:         140,370  (      7,064 rd   +    133,306 wr)
==3808== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit f07c0ef into main May 16, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request May 16, 2024
rakita added a commit that referenced this pull request May 16, 2024
gakonst pushed a commit that referenced this pull request May 16, 2024
This was referenced May 17, 2024
This was referenced Jun 3, 2024
@rakita rakita deleted the rakita/revert_eip2935 branch June 10, 2024 16:55
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant