Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat: implement EIP-2935 (#1354)" (#1424)" #1426

Merged
merged 1 commit into from
May 16, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented May 16, 2024

This reverts commit f07c0ef.

Copy link
Contributor

Valgrind Results:

==3802== Cachegrind, a cache and branch-prediction profiler
==3802== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3802== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3802== Command: target/release/snailtracer
==3802== 
--3802-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.847590979s
==3802== 
==3802== I   refs:      429,371,746
==3802== I1  misses:          3,144
==3802== LLi misses:          2,820
==3802== I1  miss rate:        0.00%
==3802== LLi miss rate:        0.00%
==3802== 
==3802== D   refs:      206,205,182  (133,650,673 rd   + 72,554,509 wr)
==3802== D1  misses:        344,877  (    204,798 rd   +    140,079 wr)
==3802== LLd misses:        137,634  (      4,274 rd   +    133,360 wr)
==3802== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3802== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3802== 
==3802== LL refs:           348,021  (    207,942 rd   +    140,079 wr)
==3802== LL misses:         140,454  (      7,094 rd   +    133,360 wr)
==3802== LL miss rate:          0.0% (        0.0%     +        0.2%  )

Copy link
Collaborator

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Blockhash devnet-0 post Pari's PR:

  • 20 gas always
  • has access to to 8192 blocks behind, which is unsound but it's fine for devnet-0
  • does the backfill method

The EIP behavior will be re-specified for devnet-1, and we'll work off the new EIP specification for the upcoming changes in that opcode's behavior, if any.

@gakonst gakonst merged commit eed27d9 into main May 16, 2024
25 checks passed
@gakonst gakonst deleted the rakita/revert_of_revert branch May 16, 2024 14:29
@rakita
Copy link
Member Author

rakita commented May 16, 2024

This shouldn't be merged. @gakonst please leave revm PR merging to me.

This was referenced May 16, 2024
This was referenced Jun 8, 2024
This was referenced Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants