chore: implement Default for other databases
#691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Sep 6, 2023
DaniPopes
commented
Sep 6, 2023
DaniPopes
force-pushed
the
db-default-2
branch
from
48e7326 to
c8cfdf4
Compare
rakita
reviewed
Sep 6, 2023
| use crate::AccountInfo; | ||
| use crate::U256; | ||
| use crate::{Account, Bytecode}; | ||
| use crate::{B160, B256}; | ||
| use auto_impl::auto_impl; | ||
| use hashbrown::HashMap as Map; | ||
|
|
||
| pub mod components; |
There was a problem hiding this comment.
Why this style and not moving pub used componnets behind pub mod?
There was a problem hiding this comment.
I don't think there's a style guide for this, but I like when it's mod x; use x::*; groups, like: https://github.com/alloy-rs/core/blob/d9d0ded3ca4e2dde992dad1afe6410015158d6b1/crates/syn-solidity/src/lib.rs
There was a problem hiding this comment.
I would prefer a little bit of a different order.
// use if needed. or maybe even put reexports.
use std::..
// list all modules in one place
mod components;
mod tests;
// reexport module items here.
pub use components::*
Something like this is easier to my eyes: https://github.com/bluealloy/revm/blob/main/crates/revm/src/db/states.rs
having mod * grouped together.
Just bikesheding, this change in general is nice
rakita
reviewed
Sep 6, 2023
DaniPopes
force-pushed
the
db-default-2
branch
2 times, most recently
from
ada3361 to
cc7fd5e
Compare
rakita
approved these changes
Sep 7, 2023
DaniPopes
force-pushed
the
db-default-2
branch
from
cc7fd5e to
06ae1c8
Compare
rakita
approved these changes
Sep 7, 2023
mikelodder7
pushed a commit
to LIT-Protocol/revm
that referenced
this pull request
Sep 12, 2023
* chore: implement `Default` for other databases * chore: impl EmptyDB traits manually
Evalir
pushed a commit
to Evalir/revm
that referenced
this pull request
Sep 14, 2023
* chore: implement `Default` for other databases * chore: impl EmptyDB traits manually
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some code cleanup and docs