-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump revm #5792
chore: bump revm #5792
Conversation
Just to link the original change: bluealloy/revm#71 . it seems that the problem was with returning U256::ZERO so returning just a number back seems okay. |
c7bac6d
to
325dd33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm!
what was the issue with the change that dragan posted?
@Evalir this discussion: bluealloy/revm#691 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g2g @DaniPopes ?
Yes |
* chore: bump revm * chore: update env chain ID to u64 * chore: drop fork * fix tests * bump
Motivation
Bump to latest master
Also to run tests for bluealloy/revm#691
Relevant PRs:
CfgEnv.chain_id
should beu64
bluealloy/revm#693Solution