Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump revm #5792

Merged
merged 6 commits into from
Sep 11, 2023
Merged

chore: bump revm #5792

merged 6 commits into from
Sep 11, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 6, 2023

@rakita
Copy link
Contributor

rakita commented Sep 7, 2023

Just to link the original change: bluealloy/revm#71 . it seems that the problem was with returning U256::ZERO so returning just a number back seems okay.

@DaniPopes DaniPopes force-pushed the bump-revm branch 3 times, most recently from c7bac6d to 325dd33 Compare September 7, 2023 22:30
@DaniPopes DaniPopes marked this pull request as ready for review September 8, 2023 00:08
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm!

what was the issue with the change that dragan posted?

@DaniPopes
Copy link
Member Author

@Evalir this discussion: bluealloy/revm#691 (comment)

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g2g @DaniPopes ?

@DaniPopes
Copy link
Member Author

Yes

@Evalir Evalir merged commit 7e89653 into foundry-rs:master Sep 11, 2023
@DaniPopes DaniPopes deleted the bump-revm branch September 11, 2023 13:05
mikelodder7 pushed a commit to LIT-Protocol/foundry that referenced this pull request Sep 12, 2023
* chore: bump revm

* chore: update env chain ID to u64

* chore: drop fork

* fix tests

* bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants