Skip to content

Commit

Permalink
[M117] Revert "Reland "Enable CrOS Touch Text Editing Redesign.""
Browse files Browse the repository at this point in the history
This reverts commit 015a6b6.

Reason for revert: Need to implement some new metrics before launch.

Original change's description:
> Reland "Enable CrOS Touch Text Editing Redesign."
>
> This is a reland of commit 009f951
>
> The original CL was reverted in CL:4705504 because of TextfieldTest
> failures. These should now be fixed by CL:4707111.
>
> Original change's description:
> > Enable CrOS Touch Text Editing Redesign.
> >
> > Design doc: go/cros-touch-text-editing
> >
> > Bug: b:244116654
> > Change-Id: I767baa1c59a0a539c0e537667166f8ee83ef031e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4699361
> > Commit-Queue: Michelle Chen <michellegc@google.com>
> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1173315}
>
> Bug: b:244116654
> Change-Id: I803a2f6d7e87df8652635b694e30c579f368eb3d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713725
> Commit-Queue: Michelle Chen <michellegc@google.com>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1174727}

(cherry picked from commit fd3bb8a)

Bug: b:295762269
Change-Id: Ib90b41b6739b6ed3236875d874db6dde2630d111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4772594
Commit-Queue: Michelle Chen <michellegc@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182842}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4778026
Cr-Commit-Position: refs/branch-heads/5938@{#128}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
  • Loading branch information
Michelle Chen authored and Chromium LUCI CQ committed Aug 15, 2023
1 parent cf097ce commit 86405c7
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions ui/base/ui_base_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -299,12 +299,7 @@ bool IsDeprecateAltBasedSixPackEnabled() {
// TODO(b/262297017): Clean up after touch text editing redesign ships.
BASE_FEATURE(kTouchTextEditingRedesign,
"TouchTextEditingRedesign",
#if BUILDFLAG(IS_CHROMEOS)
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
#endif
);
base::FEATURE_DISABLED_BY_DEFAULT);

bool IsTouchTextEditingRedesignEnabled() {
return base::FeatureList::IsEnabled(kTouchTextEditingRedesign);
Expand Down

0 comments on commit 86405c7

Please sign in to comment.