Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium Crashed On A Url #128

Open
scrutinizer11 opened this issue Dec 27, 2022 · 2 comments
Open

Chromium Crashed On A Url #128

scrutinizer11 opened this issue Dec 27, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@scrutinizer11
Copy link

Describe the bug
See the subject. It happened out of nowhere.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.newsmax.com/newsmax-tv/blaine-holt-russia-ukraine/2022/12/25/id/1101849/
  2. Highlight any word and perform a 3-finger tap to open the Dictionary pop-up.
  3. Presumably, it's when the crash may happen or not. I have no other clues. I'm not confident the URL could be a culprit nor that the gesture was the trigger.

Desktop:

  • OS: OS X Mavericks
  • Build 108.0.5359.124.1

Logs
Chromium_crash_MacBookPro.txt

Extensions

  • Wayback Machine
  • iCloud dashboard
  • Click to Shorten URL
  • Grammarly
  • Enhancer for YouTube
  • Stylus
  • Mate Translate
  • File Converter by Convert-Online.com
  • DNS Checker
  • Adguard
@scrutinizer11 scrutinizer11 added the bug Something isn't working label Dec 27, 2022
@Wowfunhappy
Copy link

Wowfunhappy commented Dec 29, 2022 •
edited
Loading

Based on the crash report, this is actually a duplicate of #44. Clearly, you have KQueueScanContinuePatch.kext installed; without it, this crash would have been a full-on kernel panic!

This instance is slightly unusual in that the main IOThread crashed, instead of ChildIOThread, which is more common. This is why the crash brought down the entire browser. However, the fundamental problem is the same.

blueboxd pushed a commit that referenced this issue Feb 8, 2023
Fix failing DataDrivenHeuristics/AllForms.109 test
a1c66df 
The heuristic here expects the current and two following years:
https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/form_parsing/credit_card_field.cc;l=368;drc=b1873cad20e18ff8afc0db995c4ac580ba051e42

(cherry picked from commit f147dde)

Fixed: 1404366
Change-Id: I8bfa521f4acf9d7ff8bf9610659e62953ec382ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4128297
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Owners-Override: Greg Thompson <grt@google.com>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1087982}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4136432
Auto-Submit: Christoph Schwering <schwering@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#128}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
@julietlevesque
[Merge M111] Reland "Reland "[Fast Pair] Prevent invalid iterators wh…
2ea9fdd 
…en removing expired devices""

This is a reland of commit ec3b59b
Instead of using a char[] array, changed to use a string literal to
avoid breaking due to buffer overflow when representing the
invalid UTF8 string. Verified that this passes the CQ asan bot.

Original change's description:
> Reland "[Fast Pair] Prevent invalid iterators when removing expired devices"
>
> This is a reland of commit 6b6ced5
> This change fixes the global buffer overflow by explicitly saying
> the test address bytes size is 6.
>
> Original change's description:
> > [Fast Pair] Prevent invalid iterators when removing expired devices
> >
> > When iterating over the list of devices, we want to also remove from
> > this list, however this can invalidate the iterator we are using to
> > parse over them. This change uses the classic approach of loop over
> > the map and collect the keys you want to remove in the vector, the
> > loop over the vector and removes them.
> >
> > tested on DUT that retroactive pairing and removing expired devices
> > works as expected.
> >
> > Test: Recreated the crash with unit tests and verified it works,
> > Fixed: b/266753250
> > Change-Id: If1e36070facf5d599b248d29ed944bc581668a05
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195321
> > Reviewed-by: Daniel Classon <dclasson@google.com>
> > Commit-Queue: Juliet Lévesque <julietlevesque@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1097185}
>
> Change-Id: I71be79695548f7caf930219196c49201bd35f064
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4197855
> Commit-Queue: Juliet Lévesque <julietlevesque@google.com>
> Reviewed-by: Daniel Classon <dclasson@google.com>
> Cr-Commit-Position: refs/heads/main@{#1097447}

(cherry picked from commit 4aadc25)

Change-Id: If223c3c3abdb6b47e9f92fa2fac4ff8fc5588e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198835
Reviewed-by: Daniel Classon <dclasson@google.com>
Commit-Queue: Juliet Lévesque <julietlevesque@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1097686}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220260
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#128}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
[M112] Reland "[fyfre] Implement long-term cohort tracking for FRE st…
33429e8 
…udy"

This reverts commit 6b9e4ce.

Reason for revert: Fixed and re-landed the parent CL

Original change's description:
> Revert "[fyfre] Implement long-term cohort tracking for FRE study"
>
> This reverts commit 1b15ffb.
>
> Reason for revert: Linux ASan failures caused by parent CL (crrev.com/c/4280190). Example: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/112172/overview
>
> Original change's description:
> > [fyfre] Implement long-term cohort tracking for FRE study
> >
> > Makes clients start registering with a study cohort (name of
> > the cohort obtained via a new param of the ForYouFreStudy feature)
> > when they attempt to run the FRE. The cohort and its name don't
> > affect the behaviour of the client by themselves, this is done
> > through the ForYouFre feature and its params.
> >
> > The cohort registration is done through a synthetic trial, where
> > the group gets pulled from prefs, so that we can  annotate sessions
> > with the group name in subsequent startups to be able to track the
> > outcome of a specific first run config in the long run.
> >
> > See http://go/for-you-fre-exp for more details.
> >
> > Bug: 1402712
> > Change-Id: I4d392cc9aaaaf31385fadda569d621d086611900
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4244081
> > Reviewed-by: David Roger <droger@chromium.org>
> > Reviewed-by: Alex Ilin <alexilin@chromium.org>
> > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1109150}
>
> Bug: 1402712
> Change-Id: Ib5ff82fb95f39e6805fa52c2624e281994e8db3f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4284865
> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
> Auto-Submit: Igor Ruvinov <igorruvinov@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Igor Ruvinov <igorruvinov@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1109206}

(cherry picked from commit 56a5a10)

Bug: 1402712
Change-Id: I74274882373486d864ab634e8eecb0133e7b3473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291113
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1109564}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300632
Auto-Submit: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{#128}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
[lacros skew tests] Refresh skew tests for M114 M113 M111
1bf3d7f 
This CL updates the ash version ['114.0.5683.0', '113.0.5672.6', '111.0.5563.118'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.

If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: I7db0509808af6fa17f79f21b9f376d63760a97af
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4381953
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#128}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
@Arcank
[5735] Remove unnecessary command
d014b43 
This command is no longer necessary. Indeed, if the pref is changed to
Never Move, the web state list observing methods will propagate 0
inactive tabs, which will trigger the pop here:
https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/ui/tab_switcher/tab_grid/inactive_tabs/inactive_tabs_coordinator.mm;l=369;drc=6d1cea7beaa59224731827cc6d03fcd07fb878e4

(cherry picked from commit 9b10395)

Bug: 1440728
Change-Id: I189097fa0a5410714a9c8fd9676cb8a978a0b8d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482093
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Louis Romero <lpromero@google.com>
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136576}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495250
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/5735@{#128}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
blueboxd pushed a commit that referenced this issue Sep 10, 2023
[M117] Revert "Reland "Enable CrOS Touch Text Editing Redesign.""
86405c7 
This reverts commit 015a6b6.

Reason for revert: Need to implement some new metrics before launch.

Original change's description:
> Reland "Enable CrOS Touch Text Editing Redesign."
>
> This is a reland of commit 009f951
>
> The original CL was reverted in CL:4705504 because of TextfieldTest
> failures. These should now be fixed by CL:4707111.
>
> Original change's description:
> > Enable CrOS Touch Text Editing Redesign.
> >
> > Design doc: go/cros-touch-text-editing
> >
> > Bug: b:244116654
> > Change-Id: I767baa1c59a0a539c0e537667166f8ee83ef031e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4699361
> > Commit-Queue: Michelle Chen <michellegc@google.com>
> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1173315}
>
> Bug: b:244116654
> Change-Id: I803a2f6d7e87df8652635b694e30c579f368eb3d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713725
> Commit-Queue: Michelle Chen <michellegc@google.com>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1174727}

(cherry picked from commit fd3bb8a)

Bug: b:295762269
Change-Id: Ib90b41b6739b6ed3236875d874db6dde2630d111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4772594
Commit-Queue: Michelle Chen <michellegc@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182842}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4778026
Cr-Commit-Position: refs/branch-heads/5938@{#128}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
blueboxd pushed a commit that referenced this issue Nov 6, 2023
@chlily1
[M119][ExclusiveAccessBubble] notify_overriden_: check if animation i…
6d5a6c9 
…s showing

This checks if the animation is showing, not just whether the bubble is
visible. This is a speculative fix for a potential race condition in
setting notify_overridden_.

(cherry picked from commit 6611247)

Bug: 1488157
Change-Id: I3e00d020458ccae4b3567ac0665ef48f4b5ce918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903710
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1204642}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916491
Cr-Commit-Position: refs/branch-heads/6045@{#128}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
@Wowfunhappy
Copy link

This should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wowfunhappy @scrutinizer11