Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability: compact the interface? #196

Open
RJVB opened this issue Nov 24, 2023 · 6 comments
Open

Usability: compact the interface? #196

RJVB opened this issue Nov 24, 2023 · 6 comments

Comments

@RJVB
Copy link

RJVB commented Nov 24, 2023

Hi,

Most cross-platform applications look "bloated" when built/run on Mac without specific adaptation, but I find that particularly noticeable in Chromium. I can imagine that this is because the code officially supports only newer versions of the OS that will probably be used on systems with retina and other crazy-high-res screens. But among us legacy users there are probably a significant number of people whose screens are older or of "lowly" normal-resolution design.
I hate maximising windows (I didn't buy a "2-Up" screen for that!) and with the window size that worked well enough in the last official Google Chrome build (and in Firefox) most sites are cramped. There's too much vertical screen wastage in particular.

Is there an existing way to scale down the interface? Other thoughts would be to not show a tab(bar) in windows with only a single tab open (wasn't there a setting for that once?) and to use a unified tab/titlebar as exists on Linux and as Firefox also uses on Mac. Could the latter setting be made available in Chromium Legacy builds, for instance?

@Wowfunhappy
Copy link

Wowfunhappy commented Nov 24, 2023

Some history: the non-unified titlebar was added as a workaround for a bug: #4

I actually appreciate being able to see the full page title of my current tab in the title bar. I also think the title bar acts as a nice visual bridge between Chromium's flat UI and the 3D UI of Aqua, making the whole system feel more unified. However, I agree that Chromium's overall UI has gotten absurdly tall, moreso within the past year following Google's 2023 design refresh.

I wonder if the WebUI code has any simple constants for height, which could be tweaked without increasing the overall maintenance burden?

@RJVB
Copy link
Author

RJVB commented Nov 24, 2023 via email

@krackers
Copy link

krackers commented Nov 24, 2023

has anyone tried if its fix is still required?

It's still required, see the last two comments on that issue. If you're comfortable building chrome, you could try investigating those two commits i mentioned at the end, but I suspect you'd need to be decently comfortable with Cocoa UI stuff to get this working.

And I suspect with the recent material v3 refresh it's going to be even more annoying. I haven't looked at how drastically the stuff is changed. Ideally it'd just be some constant for height or whatever that you could revert/patch, but maybe they redesigned that entire piece.

@RJVB
Copy link
Author

RJVB commented Nov 24, 2023 via email

@RJVB
Copy link
Author

RJVB commented Nov 25, 2023 via email

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 23, 2024

FYI: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/layout_constants.cc

The sizes of various UI elements are defined here. They can probably be changed without breaking things.

I would recommend starting with LOCATION_BAR_HEIGHT on line 73. It's already different depending on whether the Omnibox Steady State Height flag is enabled.

blueboxd pushed a commit that referenced this issue May 16, 2024
This patch makes sure the extra space on iPad goes at the bottom of
the view instead of the top.
There is no changes on iPhone.

This also fix a small issue on constraint. The bottom of the scroll
view should be attached to the top of the separator (the one that is
just above the button).

This patch needs to be merge into M124.

Before:
https://drive.google.com/file/d/1Qj5tL14SlxPe7JHVpnyXVVGfyKKA8n4Q/view?resourcekey=0-3f86qDsn2XQwZlYjURMnVQ
After:
https://drive.google.com/file/d/1oOu7n7-MXDvsxv4NJg4ZjgfkbfYjVquR/view?resourcekey=0-NP-f-bJY_RhD3yslI92V-Q


(cherry picked from commit e97c43d)

Fixed: 330713313
Change-Id: Iaca0fd933c676c8f18529931ad6e81930d17fb89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383437
Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1276304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388680
Cr-Commit-Position: refs/branch-heads/6367@{#196}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants