Title bar & min/max/close buttons #4
Labels
bug
Something isn't working
Comments
blueboxd
pushed a commit
that referenced
this issue
Dec 2, 2020
... until the respective XDG surface is initialized. The current call to WaylandToplevelWindow::InitializeAuraShell() is not effective on Exo. Basically, this method was being called prior to the respective XDG surface got properly initialized on Exo. Problem: 1) Lacros calls aura_surface_set_fullscreen_mode(), and Exo should processes the call like below: #1 exo::ShellSurfaceBase::SetUseImmersiveForFullscreen() #2 exo::Surface::SetUseImmersiveForFullscreen() #3 exo::wayland::AuraSurface::SetFullscreenMode() #4 exo::wayland::(anonymous namespace)::aura_surface_set_fullscreen_mode() 2) However, on frame #2, |exo::Surface::delegate_| was still NIL, and the call got bailed out. 3) |exo::Surface::delegate_| only gets assigned when Exo processes the call to xdg_wm_base_get_xdg_surface(), from the client side. #1 0x5563f0dbb100 exo::Surface::SetSurfaceDelegate() #2 0x5563f0dc1e33 exo::SurfaceTreeHost::SetRootSurface() #3 0x5563f0e02a23 exo::ShellSurfaceBase::ShellSurfaceBase() #4 0x5563f0dfdc65 exo::ShellSurface::ShellSurface() #5 0x5563f0e0f47f exo::XdgShellSurface::XdgShellSurface() #6 0x5563f0d95561 exo::Display::CreateXdgShellSurface() #7 0x5563ecbed19a exo::wayland::(anonymous namespace)::xdg_wm_base_get_xdg_surface() CL fixes this by making the call to InitializeAuraShell() only take place once the respective XDGSurface is initialized. This is a fixup! of https://crrev.com/c/2353116. BUG=1113900 R=msisov@igalia.com Change-Id: I4169d30545238abf2ad46eaef9677a846d58c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566346 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#832825}
|
Sorry for late reply. Chromium code is still strange to me, and window related UI code structure is drastically changed between version for 10.9 and for 10.10+. |
blueboxd
pushed a commit
that referenced
this issue
Dec 12, 2020
This reverts commit 3da5569. Reason for revert: Suspected to be causing widespread failures in PPAPI/Pepper tests on Win and Linux dbg bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/87226 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93584 Sample failure output: [ RUN ] OutOfProcessPPAPITest.Instance_ExecuteScript [18698:18698:1211/141847.386588:INFO:content_main_runner_impl.cc(1027)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:37739/devtools/browser/565ba965-de40-4715-8905-11c22e1cfcca [18698:18811:1211/141848.175888:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18811:1211/141848.265958:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18698:1211/141848.839793:INFO:CONSOLE(1)] "Uncaught Error: plugin exception", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.844552:INFO:CONSOLE(1)] "Uncaught TypeError: document.doesntExist is not a function", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.855716:INFO:CONSOLE(176)] "ExecuteScript finished in 0.073 seconds.", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (176) Received signal 11 <unknown> 000000000000 #0 0x7f89c0dca89f base::debug::CollectStackTrace() #1 0x7f89c0b5409a base::debug::StackTrace::StackTrace() #2 0x7f89c0b54055 base::debug::StackTrace::StackTrace() #3 0x7f89c0dca36b base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f8993ea2390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #5 0x7f89b142c419 std::__Cr::default_delete<>::operator()() #6 0x7f89b142c3ea std::__Cr::unique_ptr<>::reset() #7 0x7f89b142c379 std::__Cr::unique_ptr<>::~unique_ptr() #8 0x7f89b142c16d mojo::internal::AssociatedInterfacePtrState<>::~AssociatedInterfacePtrState() #9 0x7f89b142cb95 mojo::AssociatedRemote<>::~AssociatedRemote() #10 0x7f89b142afab content::PepperPluginInstance::~PepperPluginInstance() #11 0x7f89b2587d8e content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #12 0x7f89b2587e69 content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #13 0x7f89b25350f8 base::RefCounted<>::DeleteInternal<>() #14 0x7f89b25350c5 base::DefaultRefCountedTraits<>::Destruct() #15 0x7f89b25350a3 base::RefCounted<>::Release() #16 0x7f89b2535069 scoped_refptr<>::Release() #17 0x7f89b253020a scoped_refptr<>::~scoped_refptr() #18 0x7f89b25ce3f3 scoped_refptr<>::reset() #19 0x7f89b25cd8dd _ZN13scoped_refptrIN7content24PepperPluginInstanceImplEEaSEDn #20 0x7f89b25cbe83 content::PepperWebPluginImpl::Destroy() #21 0x7f89a7414e41 blink::WebPluginContainerImpl::Dispose() #22 0x7f89a593f32d blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::PerformDeferredPluginDispose() #23 0x7f89a4f5d292 blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::~PluginDisposeSuspendScope() #24 0x7f89a4f58862 blink::ContainerNode::RemoveChild() #25 0x7f89a5111cbb blink::Node::removeChild() #26 0x7f89a70daabe blink::(anonymous namespace)::RemoveChildOperationCallback() #27 0x7f899e0c0780 v8::internal::FunctionCallbackArguments::Call() #28 0x7f899e0bedcd v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #29 0x7f899e0bcfe5 v8::internal::Builtin_Impl_HandleApiCall() #30 0x7f899e0bcaa9 v8::internal::Builtin_HandleApiCall() #31 0x7f899dae513f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit r8: 00000f84ee181f88 r9: 0000000000000000 r10: 0000000000000259 r11: 00007f8996194690 r12: 00007f89a70da600 r13: 0000132400000000 r14: 00007ffc8c8eef10 r15: 00007ffc8c8eef10 di: 00007f89b3e98918 si: 00007f89b3e98918 bp: 00007ffc8c8ee710 bx: 00007f89c0f52440 dx: 00000f84ee181f90 ax: 00007f89b2587db0 cx: 0000000000000000 sp: 00007ffc8c8ee6f0 ip: 00007f89b142c419 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x55ec1877d394 content::NoRendererCrashesAssertion::Observe() #1 0x7f3d4cf1ead6 content::NotificationServiceImpl::Notify() #2 0x7f3d4d3a3986 content::RenderProcessHostImpl::ProcessDied() #3 0x7f3d4d3a46be content::RenderProcessHostImpl::OnChannelError() #4 0x7f3d60fa392d IPC::ChannelProxy::Context::OnDispatchError() #5 0x7f3d60fa987f base::internal::FunctorTraits<>::Invoke<>() #6 0x7f3d60fa97c1 base::internal::InvokeHelper<>::MakeItSo<>() #7 0x7f3d60fa9742 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIS7_NSt4__Cr5tupleIJS9_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE #8 0x7f3d60fa96ec base::internal::Invoker<>::RunOnce() #9 0x7f3d5ca3c0d1 _ZNO4base12OnceCallbackIFvvEE3RunEv #10 0x7f3d5cc03df2 base::TaskAnnotator::RunTask() #11 0x7f3d5cc49eba base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #12 0x7f3d5cc49685 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x7f3d5cc4a119 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #14 0x7f3d5caf69f1 base::MessagePumpGlib::HandleDispatch() #15 0x7f3d5caf7141 base::(anonymous namespace)::WorkSourceDispatch() #16 0x7f3d2f683197 g_main_context_dispatch #17 0x7f3d2f6833f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef) #18 0x7f3d2f68349c g_main_context_iteration #19 0x7f3d5caf6b00 base::MessagePumpGlib::Run() #20 0x7f3d5cc4a740 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #21 0x7f3d5cb95d75 base::RunLoop::Run() #22 0x55ec187b836a content::RunThisRunLoop() #23 0x55ec187b831f content::RunMessageLoop() #24 0x55ec18760320 content::JavascriptTestObserver::Run() #25 0x55ec16a8b567 content::PPAPITestBase::RunTestURL() #26 0x55ec16a8b48e content::PPAPITestBase::RunTest() #27 0x55ec16a84f2a content::(anonymous namespace)::OutOfProcessPPAPITest_Instance_ExecuteScript_Test::RunTestOnMainThread() #28 0x55ec18719264 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #29 0x55ec1871cf2a base::internal::FunctorTraits<>::Invoke<>() #30 0x55ec1871cea1 base::internal::InvokeHelper<>::MakeItSo<>() #31 0x55ec1871ce37 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #32 0x55ec1871cddc base::internal::Invoker<>::RunOnce() #33 0x55ec157bbac1 _ZNO4base12OnceCallbackIFvvEE3RunEv #34 0x55ec18a331cc content::ShellBrowserMainParts::PreMainMessageLoopRun() #35 0x7f3d4c5f5282 content::BrowserMainLoop::PreMainMessageLoopRun() chromium#36 0x7f3d4c5ff18a base::internal::FunctorTraits<>::Invoke<>() #37 0x7f3d4c5ff0a1 base::internal::InvokeHelper<>::MakeItSo<>() #38 0x7f3d4c5ff027 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE chromium#39 0x7f3d4c5fefcc base::internal::Invoker<>::RunOnce() #40 0x7f3d4c9d5b31 _ZNO4base12OnceCallbackIFivEE3RunEv #41 0x7f3d4d812b16 content::StartupTaskRunner::RunAllTasksNow() chromium#42 0x7f3d4c5f3b8a content::BrowserMainLoop::CreateStartupTasks() #43 0x7f3d4c602df0 content::BrowserMainRunnerImpl::Initialize() #44 0x7f3d4c5f0d64 content::BrowserMain() #45 0x7f3d4e7bcbc6 content::RunBrowserProcessMain() #46 0x7f3d4e7be1e9 content::ContentMainRunnerImpl::RunBrowser() #47 0x7f3d4e7bdad7 content::ContentMainRunnerImpl::Run() #48 0x7f3d4e7bae05 content::RunContentProcess() #49 0x7f3d4e7bb79d content::ContentMain() #50 0x55ec18718d5a content::BrowserTestBase::SetUp() #51 0x55ec1865a9ac content::ContentBrowserTest::SetUp() #52 0x55ec16a8ba95 content::OutOfProcessPPAPITest::SetUp() #53 0x55ec17363a6b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #54 0x55ec173547f7 testing::internal::HandleExceptionsInMethodIfSupported<>() Note the ~AssociatedRemote from ~PepperPluginInstanceImpl, which I think was introduced in this CL. This also seems to be the only plugin-related change in the blamelist (https://chromium.googlesource.com/chromium/src/+log/6828ef78f2200e4bac3280186c7520ab65b2d7f8%5E..21468f4304510a432e3376d9d72ec67962f39723?pretty=fuller&n=) Original change's description: > Add mojo interfaces for pepper plugins. > > This adds some base plumbing for pepper plugin instance handling. The > pepper renderer code allocates and manages the PepperPluginInstanceImpl, > this creates the correct encapsulation moving code out of RenderFrameImpl. > > On the browser side a PepperPluginInstance is created to handle the > messages and relay them to the WebContentsImpl which use to handle > the processing of Pepper messages. > > BUG=1157519 > > Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836239} TBR=dcheng@chromium.org,bbudge@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iddd93694ebe0611abef6c74b57667554b51e26fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587769 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836330}
blueboxd
pushed a commit
that referenced
this issue
Dec 12, 2020
…ility bubbles." This reverts commit 7ffd10d. Reason for revert: [Sheriff] Suspected to be causing widespread accessibility test failures on MSAN bots due to use of uninitialized value in code that was added to CreateOrUpdateLayer in this CL (line 73, presumably for `stack_at_top`) Build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21677 Sample failure: [ RUN ] AccessibilityFocusRingControllerTest.FocusRingWorksOnMultipleDisplays 2020-12-11T22:10:55.266324Z 8322331852 ERROR ash_unittests[24691:24691]: [cras_audio_handler.cc(1611)] Failed to retrieve WBS mic deprioritized flag ==24691==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5653d294dffa in ash::AccessibilityLayer::CreateOrUpdateLayer(aura::Window*, char const*, gfx::Rect const&, bool) ./../../ash/accessibility/accessibility_layer.cc:73:7 #1 0x5653d294788e in ash::AccessibilityFocusRingLayer::Set(ash::AccessibilityFocusRing const&) ./../../ash/accessibility/accessibility_focus_ring_layer.cc:116:3 #2 0x5653d29383cb in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:82:25 #3 0x5653d293baa9 in ash::AccessibilityFocusRingGroup::UpdateFocusRing(std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >, ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:152:3 #4 0x5653d2932f04 in ash::AccessibilityFocusRingControllerImpl::SetFocusRing(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >) ./../../ash/accessibility/accessibility_focus_ring_controller_impl.cc:67:25 #5 0x5653cda0dbe2 in ash::AccessibilityFocusRingControllerTest_FocusRingWorksOnMultipleDisplays_Test::TestBody() ./../../ash/accessibility/accessibility_focus_ring_controller_unittest.cc:106:15 #6 0x5653d24cc4a7 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5653d24cc4a7 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2689:5 #8 0x5653d24ceb57 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5653d24d0e64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #10 0x5653d24fb28a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #11 0x5653d24fa26c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #12 0x5653d24fa26c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #13 0x5653d3c13224 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #14 0x5653d3c13224 in base::TestSuite::Run() ./../../base/test/test_suite.cc:480:16 #15 0x5653d3c1addf in Run ./../../base/callback.h:101:12 #16 0x5653d3c1addf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:179:38 #17 0x5653d3c1a853 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:249:10 #18 0x5653cf8bc976 in main ./../../ash/test/ash_unittests.cc:25:10 #19 0x7fe4936dd83f in __libc_start_main ??:0:0 #20 0x5653cd7f7409 in _start ??:0:0 Uninitialized value was created by a heap allocation #0 0x5653cd86a7c9 in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:45:35 #1 0x5653d2938051 in make_unique<ash::AccessibilityFocusRingLayer, ash::AccessibilityLayerDelegate *&> ./../../buildtools/third_party/libc++/trunk/include/memory:3043:28 #2 0x5653d2938051 in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:69:11 #3 0x5653d293baa9 in ash::AccessibilityFocusRingGroup::UpdateFocusRing(std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >, ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:152:3 #4 0x5653d2932f04 in ash::AccessibilityFocusRingControllerImpl::SetFocusRing(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >) ./../../ash/accessibility/accessibility_focus_ring_controller_impl.cc:67:25 #5 0x5653cda0dbe2 in ash::AccessibilityFocusRingControllerTest_FocusRingWorksOnMultipleDisplays_Test::TestBody() ./../../ash/accessibility/accessibility_focus_ring_controller_unittest.cc:106:15 #6 0x5653d24cc4a7 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5653d24cc4a7 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2689:5 #8 0x5653d24ceb57 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5653d24d0e64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #10 0x5653d24fb28a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #11 0x5653d24fa26c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #12 0x5653d24fa26c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #13 0x5653d3c13224 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #14 0x5653d3c13224 in base::TestSuite::Run() ./../../base/test/test_suite.cc:480:16 #15 0x5653d3c1addf in Run ./../../base/callback.h:101:12 #16 0x5653d3c1addf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:179:38 #17 0x5653d3c1a853 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:249:10 #18 0x5653cf8bc976 in main ./../../ash/test/ash_unittests.cc:25:10 #19 0x7fe4936dd83f in __libc_start_main ??:0:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/ash_unittests+0x65feffa) Original change's description: > Re-land: Move focus rings and highlight layers under accessibility bubbles. > > Original patch: http://crrev.com/c/2568547 > Revert: http://crrev.com/c/2583106 > > Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel. > > Original description: > > Move focus rings and highlight layers under accessibility bubbles. > > Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. > > Bug: 1157261, 1143814 > Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Joel Riley <joelriley@google.com> > Cr-Commit-Position: refs/heads/master@{#836222} TBR=xiyuan@chromium.org,dmazzoni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,shannc@google.com,joelriley@google.com Change-Id: I08b819849d13fb5d01f67c5bbd3083ed0e445e7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157261 Bug: 1143814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587604 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836386}
blueboxd
pushed a commit
that referenced
this issue
Jan 13, 2021
This change enables Chrome OS Chrome builds running on non-cros linux to work with Espeak-ng. On linux builds, dcheck always triggers an error in mojo. Consequently, in TtsService, where the service makes mojo calls on a Remote within the audio thread, a DCHECK was hit: 2021-01-11T22:46:32.666960Z FATAL chrome[2743839:2743847]: [sequence_checker.h(120)] Check failed: checker.CalledOnValidSequence(). #0 0x7f7ee68c681f base::debug::CollectStackTrace() #1 0x7f7ee665fd8a base::debug::StackTrace::StackTrace() #2 0x7f7ee665fd45 base::debug::StackTrace::StackTrace() #3 0x7f7ee66a9057 logging::LogMessage::~LogMessage() #4 0x7f7ee66a9769 logging::LogMessage::~LogMessage() #5 0x7f7ee6620c1b logging::CheckError::~CheckError() #6 0x7f7ee564e09c base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #7 0x7f7ee566c068 mojo::InterfaceEndpointClient::SendMessage() #8 0x7f7ee566c99f mojo::InterfaceEndpointClient::Accept() #9 0x565159b53c29 chromeos::tts::mojom::TtsEventObserverProxy::OnStart() #10 0x56515c4e3a5a chromeos::tts::TtsService::Render() #11 0x7f7ed8648f02 media::AudioOutputDeviceThreadCallback::Process() #12 0x7f7ed861fe9d media::AudioDeviceThread::ThreadMain() #13 0x7f7ee68fb1ab base::(anonymous namespace)::ThreadFunc() #14 0x7f7ea303fea7 start_thread #15 0x7f7ea2baad8f clone Fix this by queueing up already rendered audio buffers and processing them on the main thread's task runner. Test: manually on a linux chromeos build. Verify that web speech produces speech through Espeak. Change-Id: I4b1e5b0a6e72e4e571b5a26fde731acc57936894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621983 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842622}
blueboxd
pushed a commit
that referenced
this issue
Jan 14, 2021
This reverts commit 8aca3b4. Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview [ RUN ] WindowOpenApiTest.PopupBlockingExtension 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure Expected equality of these values: num_browsers Which is: 4 chrome::GetBrowserCount(browser->profile()) Which is: 2 Google Test trace: ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 Stack trace: #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #6 0x563646f2068c base::internal::Invoker<>::RunOnce() #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() #20 0x7fb5dc82a804 content::BrowserMain() #21 0x7fb5de9aae56 content::RunBrowserProcessMain() #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() #24 0x7fb5de9a9106 content::RunContentProcess() #25 0x7fb5de9a9a3d content::ContentMain() #26 0x563646f1cb13 content::BrowserTestBase::SetUp() #27 0x563645acb283 InProcessBrowserTest::SetUp() #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() Original change's description: > Support multiple receivers for Cros APIs. > > With this CL, most of Cros API starts to support multiple receivers. > AshChromeService and LacrosChromeService are exceptions. > > Bug: 1148448 > Test: Build and run Lacros on a DUT. > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842869} TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842943}
blueboxd
pushed a commit
that referenced
this issue
Jan 14, 2021
…vice" This reverts commit 85753b0. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() chromium#36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() chromium#39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() chromium#42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842980}
blueboxd
pushed a commit
that referenced
this issue
Jan 20, 2021
This reverts commit 640009e. Reason for revert: The original CL looks wrongly identified as a cause of test breakage. Even without this CL, the test is flaky. Original change's description: > Revert "Support multiple receivers for Cros APIs." > > This reverts commit 8aca3b4. > > Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview > > [ RUN ] WindowOpenApiTest.PopupBlockingExtension > 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. > 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag > 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. > 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user > 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. > 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. > 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry > 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. > 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found > 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files > 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als > 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. > 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files > 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure > Expected equality of these values: > num_browsers > Which is: 4 > chrome::GetBrowserCount(browser->profile()) > Which is: 2 > Google Test trace: > ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 > Stack trace: > #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() > #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() > #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() > #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() > #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #6 0x563646f2068c base::internal::Invoker<>::RunOnce() > #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv > #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() > #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() > #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() > #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() > #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() > #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv > #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() > #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() > #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() > #20 0x7fb5dc82a804 content::BrowserMain() > #21 0x7fb5de9aae56 content::RunBrowserProcessMain() > #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() > #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() > #24 0x7fb5de9a9106 content::RunContentProcess() > #25 0x7fb5de9a9a3d content::ContentMain() > #26 0x563646f1cb13 content::BrowserTestBase::SetUp() > #27 0x563645acb283 InProcessBrowserTest::SetUp() > #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() > #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() > #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() > > > > Original change's description: > > Support multiple receivers for Cros APIs. > > > > With this CL, most of Cros API starts to support multiple receivers. > > AshChromeService and LacrosChromeService are exceptions. > > > > Bug: 1148448 > > Test: Build and run Lacros on a DUT. > > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842869} > > TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1148448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842943} TBR=jamescook@chromium.org,hidehiko@chromium.org,kolos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148448 Change-Id: Ic2ec65fa476b9b67a705497aad1cf3f1bffa0da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633482 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844778}
blueboxd
pushed a commit
that referenced
this issue
Jan 21, 2021
2 tests in this test suite seem inconsistent: test#2 asserts that tbody.height=10px > tr.height=1px > td.height=1px implies td.offsetHeight = 1px test#4 asserts that tbody.height=10px > tr > td.height=1px implies td.offsetHeight = 10px Edge 17 is the only browser that agrees with #2 and #4 FF agrees with #2, but not #4 Chrome agrees with #4, but not #2 Safari agrees with #4, but not #2 To me, #2 and #4 seem to be in conflict. Either tbody height propagates to rows, or it does not. The problem is that #2 is overconstrained. My suggestion is that tbody height always propagates to tr. Bug: 958381 Change-Id: I28bfd108c67968d31d0372b536c316c997d2d958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586097 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845515}
blueboxd
pushed a commit
that referenced
this issue
Jan 22, 2021
This reverts commit 17801e4. Reason for revert: Fixes to the internal scripts that broke have landed. Original change's description: > Revert "Reland "Force Python 3 to be used in build."" > > This reverts commit 6ea5c38. > > Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview > > Original change's description: > > Reland "Force Python 3 to be used in build." > > > > This reverts commit b617219. > > > > Reason for revert: We rolled GN to a new version with a fix for > > the win dev issues, so hopefully is good to go now. > > > > Original change's description: > > > Revert "Force Python 3 to be used in build." > > > > > > This reverts commit bb97ab9. > > > > > > Reason for revert: Various breakages. > > > > > > Original change's description: > > > > Force Python 3 to be used in build. > > > > > > > > This CL makes Python 3 be the default script executable used by Ninja > > > > to run action() and action_foreach()'s during the build. > > > > > > > > This does *not* mean that everything works with Python3; many targets > > > > may still use Python 2 via the python2_action() and > > > > python2_action_foreach() targets or via custom logic. > > > > > > > > However, it does mean that it should prevent regressions from > > > > creeping in. > > > > > > > > This CL should not be taken to imply that we can start to write > > > > Python3-specific code that can run during the build; we should > > > > still be trying to ensure that everything is compatible with Python2. > > > > > > > > Also, this CL does not enable the use of vpython in actions; we should > > > > still avoid that because vpython is slower than direct Python > > > > invocations. > > > > > > > > Bug: 1112471 > > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Cr-Commit-Position: refs/heads/master@{#836234} > > > > > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1112471 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576 > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#836284} > > > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1112471 > > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#844885} > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112471 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844986} TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1112471 Change-Id: Icbefaa2cb23b1bf9e54bbd674cb5ab564dae3785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643157 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#846193}
blueboxd
pushed a commit
that referenced
this issue
Jan 23, 2021
This reverts commit bba4dc0. Reason for revert: Breaks v8 generation script for at least linux and linux-chromeos. FAILED: gen/v8/include/v8-gn.h python3 ../../v8/tools/gen-v8-gn.py -o gen/v8/include/v8-gn.h -p V8_COMPRESS_POINTERS -p V8_31BIT_SMIS_ON_64BIT_ARCH -p V8_DEPRECATION_WARNINGS -p CPPGC_CAGED_HEAP -n V8_ENABLE_CHECKS -n V8_COMPRESS_ZONES -n V8_HEAP_SANDBOX -n V8_IMMINENT_DEPRECATION_WARNINGS -n V8_NO_ARGUMENTS_ADAPTOR -n V8_USE_PERFETTO -n CPPGC_SUPPORTS_OBJECT_NAMES -n CPPGC_YOUNG_GENERATION Traceback (most recent call last): File "../../v8/tools/gen-v8-gn.py", line 80, in <module> main() File "../../v8/tools/gen-v8-gn.py", line 63, in main header_stream = BytesIO("") TypeError: a bytes-like object is required, not 'str' Original change's description: > Reland #4 (?) of "Force Python 3 to be used in build." > > This reverts commit 17801e4. > > Reason for revert: Fixes to the internal scripts that broke > have landed. > > Original change's description: > > Revert "Reland "Force Python 3 to be used in build."" > > > > This reverts commit 6ea5c38. > > > > Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview > > > > Original change's description: > > > Reland "Force Python 3 to be used in build." > > > > > > This reverts commit b617219. > > > > > > Reason for revert: We rolled GN to a new version with a fix for > > > the win dev issues, so hopefully is good to go now. > > > > > > Original change's description: > > > > Revert "Force Python 3 to be used in build." > > > > > > > > This reverts commit bb97ab9. > > > > > > > > Reason for revert: Various breakages. > > > > > > > > Original change's description: > > > > > Force Python 3 to be used in build. > > > > > > > > > > This CL makes Python 3 be the default script executable used by Ninja > > > > > to run action() and action_foreach()'s during the build. > > > > > > > > > > This does *not* mean that everything works with Python3; many targets > > > > > may still use Python 2 via the python2_action() and > > > > > python2_action_foreach() targets or via custom logic. > > > > > > > > > > However, it does mean that it should prevent regressions from > > > > > creeping in. > > > > > > > > > > This CL should not be taken to imply that we can start to write > > > > > Python3-specific code that can run during the build; we should > > > > > still be trying to ensure that everything is compatible with Python2. > > > > > > > > > > Also, this CL does not enable the use of vpython in actions; we should > > > > > still avoid that because vpython is slower than direct Python > > > > > invocations. > > > > > > > > > > Bug: 1112471 > > > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > > > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > > Cr-Commit-Position: refs/heads/master@{#836234} > > > > > > > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > > > > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 1112471 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576 > > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Cr-Commit-Position: refs/heads/master@{#836284} > > > > > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1112471 > > > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725 > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#844885} > > > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1112471 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844986} > > TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1112471 > Change-Id: Icbefaa2cb23b1bf9e54bbd674cb5ab564dae3785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643157 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#846193} TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic21ef3e38758d295dac893a02f8d206a67e49d52 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645206 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#846218}
blueboxd
pushed a commit
that referenced
this issue
Jan 23, 2021
This reverts commit d2adbc5. Reason for revert: causing ~600 html failures on tests Example stack trace STDERR: Received signal 11 SEGV_MAPERR 000000000099 STDERR: #0 0x56419ad17d39 base::debug::CollectStackTrace() STDERR: #1 0x56419ac8fc63 base::debug::StackTrace::StackTrace() STDERR: #2 0x56419ad178e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f96ed01d390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) STDERR: #4 0x56419c8a9228 WTF::StaticSingleton<>::StaticSingleton<>() STDERR: #5 0x56419c8a90cc blink::CounterStyleMap::GetUACounterStyleMap() STDERR: #6 0x56419c8da407 blink::StyleEngine::FindCounterStyleAcrossScopes() STDERR: #7 0x56419ce564a7 blink::ListMarker::GetCounterStyle() STDERR: #8 0x56419ce5640e blink::ListMarker::GetListStyleCategory() STDERR: #9 0x56419ce56d3e blink::ListMarker::InlineMarginsForInside() STDERR: #10 0x56419c8846ae blink::StyleAdjuster::AdjustComputedStyle() STDERR: #11 0x56419c877f3c blink::StyleResolver::PseudoStyleForElement() STDERR: #12 0x56419c964063 blink::Element::StyleForPseudoElement() STDERR: #13 0x56419c9a6bd9 blink::PseudoElement::CustomStyleForLayoutObject() STDERR: #14 0x56419c95b52f blink::Element::StyleForLayoutObject() etc see e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/22892/test-results Original change's description: > Refactor counter style updates > > Currently, counter style updates is a phase in UpdateActiveStyles. This > patch moves it out as a standalone phase of UpdateStyleAndLayoutTree, > so that we update counter styles only when needed. > > This patch also adds MarkCounterStylesNeedUpdate() to indicate whether > counter style updates are needed. > > Note: After refactoring, the framework of counter style updates looks > almost identical to font updates. This is intentional. We will try to > unify them in the future. > > Bug: 687225 > Change-Id: If07de2878ae5faa6800644a967029a569bef566a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846203} TBR=xiaochengh@chromium.org,futhark@chromium.org,andruud@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3c1e09dce14cd4edb366b911d3aaf5da66b2b100 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 687225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644742 Reviewed-by: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#846262}
blueboxd
pushed a commit
that referenced
this issue
Jan 27, 2021
This reverts commit 0eb6b1e. Reason for revert: Suspect causing ash_unittests failure on linux-chromeos-dbg Builder: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg First build failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22344 Sample stacktrace: [1/5610] AcceleratorCommandsTest.ToggleMinimized (1848 ms) [ RUN ] AcceleratorCommandsTest.ToggleMaximized [capture_mode_controller.cc(307)] Check failed: !message_center::MessageViewFactory::HasCustomNotificationViewFactory( kScreenCaptureNotificationType). #0 0x7f29bf492bbf base::debug::CollectStackTrace() #1 0x7f29bf22770a base::debug::StackTrace::StackTrace() #2 0x7f29bf2276c5 base::debug::StackTrace::StackTrace() #3 0x7f29bf270d17 logging::LogMessage::~LogMessage() #4 0x7f29bf271419 logging::LogMessage::~LogMessage() #5 0x7f29bf1e80bb logging::CheckError::~CheckError() #6 0x7f29c3a68b49 ash::CaptureModeController::CaptureModeController() #7 0x7f29c3e2eceb std::__Cr::make_unique<>() #8 0x7f29c3e1fa8b ash::Shell::Init() #9 0x7f29c3e1f5de ash::Shell::CreateInstance() #10 0x55fa098eea0e ash::AshTestHelper::SetUp() #11 0x55fa098ebdc8 ash::AshTestBase::SetUp() #12 0x55fa098ebc0e ash::AshTestBase::SetUp() Original change's description: > capture mode: implement customized image capture notification. > > Bug: 1159111 > Change-Id: I5a96480a929a05a7782f51ae6baea8ddc7c9df10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632390 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846957} TBR=estade@chromium.org,xdai@chromium.org,afakhry@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id535618e328a75dbc829d8b662c8dc99dfe25f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648987 Reviewed-by: Takashi Sakamoto <tasak@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#847060}
|
As a temporary stop-gap measure, this dumb code mostly fixes the problem. I'm just repositioning the buttons so they appear in the non-covered area of the toolbar.
|
|
Wow!Thank you very much for your idea! |
blueboxd
pushed a commit
that referenced
this issue
Jan 28, 2021
Use SequenceChecker::EnableStackLogging() to enable this logging. When DCHECK() fails for a ThreadChecker or SequenceChecker, if the error is not at the site of checking, it takes a great amount of knowledge and persistence to figure out where the erroroneous thread/sequence- attachment occurred. This is especially fun for a WeakPtr, which if checked on the wrong thread becomes bound to the thread. Then if the WeakPtrFactory is invalidated later, it's difficult to determine why it believes it is on the wrong thread. This adds a copy of the StackTrace in SequenceChecker and ThreadChecker that is set whenever they are bound to a thread/sequence. Then on failure the DCHECK() callers will get back a copy of the StackTrace and include it in the log message. WeakPtr calls the SequenceChecker manually instead of using the macros, since it has an additional condition so we also add the StackTrace to the message there. The StackTrace logging slows things down a bit, enough that we'd slow bots down without good reason, so the logging is optional. You may use SequenceChecker::EnableStackLogging() to enable this logging, or the equivalent alias ThreadChecker::EnableStackLogging(). Example output with stack logging enabled: [890744:1:1201/174351.878197:FATAL:weak_ptr.cc(23)] Check failed: sequence_checker_.CalledOnValidSequence(&bound_at) || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread as where they are bound. This was bound at: #0 0x7fd813c8d369 base::debug::CollectStackTrace() #1 0x7fd813b94103 base::debug::StackTrace::StackTrace() #2 0x7fd813c70aef base::ThreadCheckerImpl::ThreadCheckerImpl() #3 0x7fd813c02155 base::SequenceCheckerImpl::CalledOnValidSequence() #4 0x7fd813ba4f55 base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #5 0x7fd813bbfa4f base::internal::WeakReference::IsValid() #6 0x7fd80acd0f36 blink::FrameWidgetInputHandlerImpl::FrameWidgetInputHandlerImpl() [...] Check failed at: #0 0x7fd813c8d369 base::debug::CollectStackTrace() #1 0x7fd813b94103 base::debug::StackTrace::StackTrace() #2 0x7fd813bb3c53 logging::LogMessage::~LogMessage() #3 0x7fd813bb45ae logging::LogMessage::~LogMessage() #4 0x7fd813bbf91c base::internal::WeakReference::Flag::Invalidate() #5 0x7fd813bbfc8c base::internal::WeakReferenceOwner::Invalidate() #6 0x7fd80ca6eda7 blink::WebFrameWidgetImpl::Close() #7 0x7fd80ff22359 content::RenderWidget::Close() #8 0x7fd80ff21eff content::RenderWidget::CloseForFrame() [...] R=thakis@chromium.org Change-Id: Id89c12eaedfba9788b3cd2624447c6a1616f0afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568446 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#847805}
Just a heads up, that may not be enough, because the buttons like to revert to their original positions whenever the window is resized. So you will probably need to detect that. What I'm still annoyed about is that I couldn't figure out how to actually change the height of the window toolbar. It's too damn tall (albeit normally covered by the window's contentView), and I suspect that's the core problem.
|
|
Thank you again! |
|
Hi again! I actually had the opportunity to hack on this a bit more today, and I think I have a much better, permanent fix! Before I go any further, please let me apologize for:
If you're busy, there's certainly no hurry to implement any of this—I can't make use it myself until that Mavericks font issue is resolved, anyway. That said: as I suspected, the actual problem was the height and position of that title bar, which turns out to be controlled in NSThemeFrame. All I had to do was: This is the result:
Unlike last time, the buttons won't jump around while resizing the window. It's not quite how Chrome is supposed to look, but it doesn't feel broken anymore, and IMO it actually makes Chrome's flat UI feel a bit less alien. There is one thing that is still really bothering me—if Chromium is going to have that gray Cocoa title bar, it really ought to show the page title! Something is setting NSWindow's But, I did do a quick search of Chromium's source code, and I think there's a good chance the culprit is here: https://github.com/chromium/chromium/blob/dabc4a8b666ddcb5c7cff5ed4ee04a938613b524/extensions/shell/browser/shell_native_app_window_mac.mm#L36. I would recommend flipping that to |
|
Thank you so much again for the great key! FYI, actual _titlebarHeight is located at BrowserWindowFrame, and _isTitleHidden is at NativeWidgetMacNSWindow. |
|
This issue should be considered solved by a simple classical title bar. |
blueboxd
pushed a commit
that referenced
this issue
Feb 3, 2021
…by default" This reverts commit ba96414. Reason for revert: failing unit_tests on linux-chromeos-chrome with NOTREACHED(). Failing tests: MediaToolbarButtonControllerTest.DoesNotDisableButtonIfDialogIsOpen MediaToolbarButtonControllerTest.DoesNotHideIfMediaStartsPlayingWithinTimeout MediaToolbarButtonControllerTest.HidesAfterTimeoutAndShowsAgainOnPlay Example: RUN ] MediaToolbarButtonControllerTest.HidesAfterTimeoutAndShowsAgainOnPlay 2021-02-03T04:04:47.546579Z 564170770 ERROR unit_tests[2535:2535]: [pref_change_registrar.cc(40)] NOTREACHED() hit. Received signal 11 SEGV_MAPERR 000000000038 #0 0x5611b0dbfe29 base::debug::CollectStackTrace() #1 0x5611b0d2f4d3 base::debug::StackTrace::StackTrace() #2 0x5611b0dbf9d1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9eb128f390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x5611ac59c5fe std::__1::__hash_table<>::find<>() #5 0x5611b1c25762 PrefService::FindPreference() #6 0x5611b11a2169 media_router::GetCastAllowAllIPsPref() #7 0x5611b2fd159b media_router::CastMediaSinkService::CreateImpl() #8 0x5611b2fd138f media_router::CastMediaSinkService::Start() #9 0x5611b2fad704 media_router::DualMediaSinkService::DualMediaSinkService() #10 0x5611b2fad539 media_router::DualMediaSinkService::GetInstance() #11 0x5611b2f93b44 media_router::MediaRouterDesktop::MediaRouterDesktop() #12 0x5611b2f93030 media_router::ChromeMediaRouterFactory::BuildServiceInstanceFor() #13 0x5611b2bdb30f BrowserContextKeyedServiceFactory::BuildServiceInstanceFor() #14 0x5611b1cd2837 KeyedServiceFactory::GetServiceForContext() #15 0x5611b37297b6 CastMediaNotificationProvider::CastMediaNotificationProvider() #16 0x5611b372c274 MediaNotificationService::MediaNotificationService() #17 0x5611abdba814 MediaToolbarButtonControllerTest::SetUp() first failing build: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/11825/overview Original change's description: > Enable GlobalMediaControlsForCast and CastMediaRouteProvider by default > > The features were enabled via a config change in M87 (CastMRP on CrOS > will soon be enabled in M88). This change enables them by default. > > Bug: 1042330, 869214 > Change-Id: I111bd1f6d13bf70cf7557004205e7de1dc3e23ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631191 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: John Williams <jrw@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#849910} TBR=pkasting@chromium.org,mlamouri@chromium.org,takumif@chromium.org,jrw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I215a231257e91dd81348577221892fb6b297677d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042330 Bug: 869214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2671781 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#850027}
blueboxd
pushed a commit
that referenced
this issue
Feb 17, 2021
… Text"
This reverts commit 87004c0941db2881991388cd6c72cf4a3d1f31c2.
Reason for revert:
As Sheriff, I'm reverting this change on suspicion of causing the MSan ChromeOS buildbot to think that we are referencing uninitialized memory.
Failing build
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/22528/overview
Flakiness Dashboard
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FSharesheetBubbleViewBrowserTest.InvokeUi_Default%2F0&testType=browser_tests
Test failure:
[ RUN ] All/SharesheetBubbleViewBrowserTest.InvokeUi_Default/0
2021-02-16T12:29:26.782807Z WARNING browser_tests[26720:26720]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
2021-02-16T12:29:26.796127Z ERROR browser_tests[26720:26720]: [cras_audio_handler.cc(1628)] Failed to retrieve WBS mic deprioritized flag
2021-02-16T12:29:26.796914Z WARNING browser_tests[26720:26813]: [statistics_provider.cc(320)] Finished loading statistics.
2021-02-16T12:29:27.204718Z ERROR browser_tests[26720:26720]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
2021-02-16T12:29:27.576009Z WARNING browser_tests[26720:26720]: [remote_commands_service.cc(183)] Client is not registered.
2021-02-16T12:29:27.621032Z WARNING browser_tests[26720:26720]: [wallpaper_controller_client.cc(376)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
2021-02-16T12:29:28.217682Z ERROR browser_tests[26720:26720]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
2021-02-16T12:29:28.404958Z ERROR browser_tests[26720:26720]: [account_manager_migrator.cc(268)] Could not find a refresh token for the Device Account.
2021-02-16T12:29:28.421207Z INFO browser_tests[26720:26720]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found
2021-02-16T12:29:28.421880Z INFO browser_tests[26720:26720]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0.
2021-02-16T12:29:28.734078Z ERROR browser_tests[26720:26817]: [als_reader.cc(52)] Missing num of als
2021-02-16T12:29:28.742218Z ERROR browser_tests[26720:26817]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files
2021-02-16T12:29:28.841649Z WARNING browser_tests[26720:26720]: [drivefs_session.cc(62)] DriveFs mount failed with error: 3
2021-02-16T12:29:28.936983Z INFO browser_tests[26720:26720]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0.
==26720==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x5598549f2288 in views::NativeWidgetAura::CenterWindow(gfx::Size const&) ./../../ui/views/widget/native_widget_aura.cc:415:57
#1 0x5598549793f1 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:0:0
#2 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#3 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#4 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#5 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#6 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#7 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#8 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#9 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#10 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#11 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#12 0x559851c52f7a in Run ./../../base/callback.h:101:12
#13 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#14 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#15 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#16 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#17 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#18 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#19 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#20 0x559850dc31ed in Run ./../../base/callback.h:101:12
#21 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#22 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#23 0x55983fce3e6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#24 0x5598460cf517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#25 0x5598475f80ac in Run ./../../base/callback.h:101:12
#26 0x5598475f80ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
#27 0x5598460ca995 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:854:25
#28 0x5598460d6b64 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
#29 0x5598460c37f2 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
#30 0x55984a9b393f in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:517:10
#31 0x55984a9b7a37 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1001:10
#32 0x55984a9b68b0 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:876:12
#33 0x55984a9ae481 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36
#34 0x55984a9aebb0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10
#35 0x5598526f81ea in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:683:3
#36 0x5598506cda3f in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:348:20
#37 0x5598418d8c23 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#38 0x5598418d8c23 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:3
#39 0x5598418db9f9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11
#40 0x5598418dda84 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28
#41 0x559841907c54 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44
#42 0x559841906c4e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
#43 0x559841906c4e in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10
#44 0x559850c79fd4 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46
#45 0x559850c79fd4 in base::TestSuite::Run() ./../../base/test/test_suite.cc:481:16
#46 0x5598506276e3 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:35:23
#47 0x5598527f8a74 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:376:31
#48 0x559850633db9 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:269:10
#49 0x5598506274ff in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:47:10
#50 0x7f9a676ee83f in __libc_start_main ??:0:0
#51 0x55983729bd49 in _start ??:0:0
Uninitialized value was stored to memory at
#0 0x55985497952f in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#1 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#2 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#3 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#4 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#5 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#6 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#7 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#8 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#9 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#10 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#11 0x559851c52f7a in Run ./../../base/callback.h:101:12
#12 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#13 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#14 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#15 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#16 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#17 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#18 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#19 0x559850dc31ed in Run ./../../base/callback.h:101:12
#20 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#21 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#22 0x55983fce3e6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#23 0x5598460cf517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#24 0x5598475f80ac in Run ./../../base/callback.h:101:12
#25 0x5598475f80ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
Uninitialized value was stored to memory at
#0 0x5598546b68a3 in Rect ./../../ui/gfx/geometry/rect.h:43:47
#1 0x5598546b68a3 in views::BubbleBorder::GetBounds(gfx::Rect const&, gfx::Size const&) const ./../../ui/views/bubble/bubble_border.cc:90:15
#2 0x5598546d7ad3 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:186:26
#3 0x5598549b8119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#4 0x5598549b8119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#5 0x559854928c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#6 0x559854979468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#7 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#8 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#9 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#10 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#11 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#12 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#13 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#14 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#15 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#16 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#17 0x559851c52f7a in Run ./../../base/callback.h:101:12
#18 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#19 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#20 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#21 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#22 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#23 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#24 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#25 0x559850dc31ed in Run ./../../base/callback.h:101:12
#26 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
Uninitialized value was stored to memory at
#0 0x5598546d7ae7 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:185:18
#1 0x5598549b8119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#2 0x5598549b8119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#3 0x559854928c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#4 0x559854979468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#5 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#6 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#7 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#8 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#9 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#10 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#11 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#12 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#13 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#14 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#15 0x559851c52f7a in Run ./../../base/callback.h:101:12
#16 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#17 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#18 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#19 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#20 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#21 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#22 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#23 0x559850dc31ed in Run ./../../base/callback.h:101:12
#24 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#25 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
Uninitialized value was created by an allocation of 'retval' in the stack frame of function '_ZNK5views15BubbleFrameView25GetFrameSizeForClientSizeERKN3gfx4SizeE'
#0 0x5598546d7b2a in views::BubbleFrameView::GetFrameSizeForClientSize(gfx::Size const&) const ./../../ui/views/bubble/bubble_frame_view.cc:834:0
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/browser_tests+0x24ac3288)
Exiting
[ RUN ] All/SharesheetBubbleViewBrowserTest.InvokeUi_Default/0
2021-02-16T12:36:26.583543Z WARNING browser_tests[30386:30386]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
2021-02-16T12:36:26.592586Z ERROR browser_tests[30386:30386]: [cras_audio_handler.cc(1628)] Failed to retrieve WBS mic deprioritized flag
2021-02-16T12:36:26.593289Z WARNING browser_tests[30386:30401]: [statistics_provider.cc(320)] Finished loading statistics.
2021-02-16T12:36:26.860265Z ERROR browser_tests[30386:30386]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
2021-02-16T12:36:27.035171Z WARNING browser_tests[30386:30386]: [remote_commands_service.cc(183)] Client is not registered.
2021-02-16T12:36:27.064652Z WARNING browser_tests[30386:30386]: [wallpaper_controller_client.cc(376)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
2021-02-16T12:36:27.364592Z ERROR browser_tests[30386:30386]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
2021-02-16T12:36:27.421165Z ERROR browser_tests[30386:30386]: [account_manager_migrator.cc(268)] Could not find a refresh token for the Device Account.
2021-02-16T12:36:27.481536Z INFO browser_tests[30386:30386]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0.
2021-02-16T12:36:27.484870Z INFO browser_tests[30386:30386]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found
2021-02-16T12:36:27.638922Z ERROR browser_tests[30386:30401]: [als_reader.cc(52)] Missing num of als
2021-02-16T12:36:27.638945Z WARNING browser_tests[30386:30386]: [drivefs_session.cc(62)] DriveFs mount failed with error: 3
2021-02-16T12:36:27.644456Z ERROR browser_tests[30386:30401]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files
2021-02-16T12:36:27.699898Z INFO browser_tests[30386:30386]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0.
==30386==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x560b2e64a288 in views::NativeWidgetAura::CenterWindow(gfx::Size const&) ./../../ui/views/widget/native_widget_aura.cc:415:57
#1 0x560b2e5d13f1 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:0:0
#2 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#3 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#4 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#5 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#6 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#7 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#8 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#9 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#10 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#11 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#12 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12
#13 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#14 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#15 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#16 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#17 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#18 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#19 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#20 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12
#21 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#22 0x560b2aa183c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#23 0x560b1993be6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#24 0x560b1fd27517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#25 0x560b212500ac in Run ./../../base/callback.h:101:12
#26 0x560b212500ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
#27 0x560b1fd22995 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:854:25
#28 0x560b1fd2eb64 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
#29 0x560b1fd1b7f2 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
#30 0x560b2460b93f in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:517:10
#31 0x560b2460fa37 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1001:10
#32 0x560b2460e8b0 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:876:12
#33 0x560b24606481 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36
#34 0x560b24606bb0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10
#35 0x560b2c3501ea in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:683:3
#36 0x560b2a325a3f in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:348:20
#37 0x560b1b530c23 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#38 0x560b1b530c23 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:3
#39 0x560b1b5339f9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11
#40 0x560b1b535a84 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28
#41 0x560b1b55fc54 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44
#42 0x560b1b55ec4e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
#43 0x560b1b55ec4e in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10
#44 0x560b2a8d1fd4 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46
#45 0x560b2a8d1fd4 in base::TestSuite::Run() ./../../base/test/test_suite.cc:481:16
#46 0x560b2a27f6e3 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:35:23
#47 0x560b2c450a74 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:376:31
#48 0x560b2a28bdb9 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:269:10
#49 0x560b2a27f4ff in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:47:10
#50 0x7f0d2d9dd83f in __libc_start_main ??:0:0
#51 0x560b10ef3d49 in _start ??:0:0
Uninitialized value was stored to memory at
#0 0x560b2e5d152f in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#1 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#2 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#3 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#4 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#5 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#6 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#7 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#8 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#9 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#10 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#11 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12
#12 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#13 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#14 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#15 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#16 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#17 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#18 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#19 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12
#20 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#21 0x560b2aa183c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#22 0x560b1993be6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#23 0x560b1fd27517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#24 0x560b212500ac in Run ./../../base/callback.h:101:12
#25 0x560b212500ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
Uninitialized value was stored to memory at
#0 0x560b2e30e8a3 in Rect ./../../ui/gfx/geometry/rect.h:43:47
#1 0x560b2e30e8a3 in views::BubbleBorder::GetBounds(gfx::Rect const&, gfx::Size const&) const ./../../ui/views/bubble/bubble_border.cc:90:15
#2 0x560b2e32fad3 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:186:26
#3 0x560b2e610119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#4 0x560b2e610119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#5 0x560b2e580c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#6 0x560b2e5d1468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#7 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#8 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#9 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#10 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#11 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#12 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#13 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#14 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#15 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#16 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#17 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12
#18 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#19 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#20 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#21 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#22 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#23 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#24 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#25 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12
#26 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
Uninitialized value was stored to memory at
#0 0x560b2e32fae7 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:185:18
#1 0x560b2e610119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#2 0x560b2e610119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#3 0x560b2e580c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#4 0x560b2e5d1468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#5 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#6 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#7 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#8 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#9 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#10 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(shareshee…
blueboxd
pushed a commit
that referenced
this issue
Mar 3, 2021
This reverts commit 8cd3185. Reason for revert: suspect causing browser_tests failure on linux-chromeos-rel Failing tests: AccessibilityPolicyTest.AutoclickEnabled All/GestureNavigationScreenTest.ScreenSkippedWithAutoclickEnabled/1 AutoclickE2ETest.HighlightsRootWebAreaIfNotScrollable AutoclickE2ETest.RemovesAndAddsAutoclick ChromeOSInfoPrivateTest.TestGetAndSet First test failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/45848 Sample log: BrowserTestBase received signal: Segmentation fault. Backtrace: ... #3 0x7fa7483ba4c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5598f0b6ecce ash::CaptureModeController::IsActive() #5 0x5598f0d32b28 ash::CollisionDetectionUtils::AvoidObstacles() #6 0x5598f0d32296 ash::CollisionDetectionUtils::GetRestingPosition() #7 0x5598f0c73a68 ash::AutoclickMenuBubbleController::SetPosition() #8 0x5598f0d8c661 ash::WorkspaceLayoutManager::NotifySystemUiAreaChanged() Original change's description: > capture_mode: Capture bar does not intersect autoclick. > > Adds capture mode on the collision course for bubbles like PIP and > autoclick, and triggers repositioning of the autoclick on enter or exit > capture mode. > > Fixed: 1149758 > Test: manual > Change-Id: I800b2b265374627718cd944d39d76dc4e94be7fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597219 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#859045} Change-Id: I2ee7dbd24ed3006a494b59b8dd93cbef86b0353a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2730374 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#859248}
blueboxd
pushed a commit
that referenced
this issue
Mar 15, 2021
…m_gtests This CL moves the check that verifies readiness of x11::Connection to InitializeUI that should be sufficient to stop execution of the browser if it's not possible to connect to XDisplay. In own turn, this allows to run such tests as vr_pixeltests, which do not actually require XDisplay. Otherwise, the following callstack results in a crash (when vr_pixeltests run). [FATAL:ozone_platform_x11.cc(277)] Check failed: x11::Connection::Get()->Ready(). Missing X server or $DISPLAY #0 0x557d0bc225f9 base::debug::CollectStackTrace() #1 0x557d0bba3a53 base::debug::StackTrace::StackTrace() #2 0x557d0bbad33f logging::LogMessage::~LogMessage() #3 0x557d0bbadcee logging::LogMessage::~LogMessage() #4 0x557d0bb0d498 ui::(anonymous namespace)::OzonePlatformX11::InitializeCommon() #5 0x557d0bb0d2bc ui::(anonymous namespace)::OzonePlatformX11::InitializeGPU() #6 0x557d0c358dd6 gl::GLImageTestSupport::InitializeGL() Bug: 1177253 Change-Id: I435d03b4688e72b37c10f16d12ac2130cff90f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2700032 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#862870}
blueboxd
pushed a commit
that referenced
this issue
Mar 23, 2021
This CL fixes a segfault when a WaylandScreen is created after a WaylandWindow.. Basically, when WaylandScreen is created, it gets the list of existing outputs, which it uses to create displays. In its own turn, it also checks what WaylandWindows are on those displays and calls WaylandWindow::UpdateBufferScale. This operation also results in SetBounds to be called, which calls to PlatformWindowDelegate::GetMinimumSizeForWindow, which requires ScreenOzone instance to have PlatformScreen (WaylandScreen in this case) to be set. But as long as creation of the screen, updating buffer scale, and setting updated bounds based on new scale value happens in the same sequence of calls, ScreenOzone just doesn't have the PlatformScreen set, and it results in a crash. See the stacktrace below - #3 0x7f9c30bba4c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x556900be4bad aura::ScreenOzone::GetPrimaryDisplay() #5 0x5568ff6aebff views::DesktopWindowTreeHostPlatform::GetRootTransform() #6 0x5568ff6af1ba views::DesktopWindowTreeHostPlatform::GetMinimumSizeForWindow() #7 0x5568faeb9aaf ui::WaylandWindow::SetBounds() #8 0x5568faeb961e ui::WaylandWindow::UpdateBufferScale() #9 0x5568faeb473d ui::WaylandScreen::AddOrUpdateDisplay() #10 0x5568faeb3023 ui::WaylandOutputManager::CreateWaylandScreen() #11 0x5568faec7fa2 ui::(anonymous namespace)::OzonePlatformWayland::CreateScreen() #12 0x556900be480a aura::ScreenOzone::ScreenOzone() #13 0x5568ff6aa10e views::DesktopScreenOzone::DesktopScreenOzone() This only happens in test environments (interactive_ui_tests, when Ozone is initialized, WaylandWindows are created, but the screen instance is created and set a bit later. Thus, make WaylandWindow use existing information about preferred outputs that it has. Bug: 1134495 Change-Id: I3f2f9349adc85684d5cf4f5e2bca8497c326bb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2773276 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#865569}
blueboxd
pushed a commit
that referenced
this issue
Mar 25, 2021
…est" This is a reland of 39b25a5; the root problem seems to have been trying to run `dirmd` on Win7, and we've upgraded the Win7 builders to be Win10, so in theory we won't have this issue this time. Original change's description: > Add test directory -> monorail component metadata to test invocations. > > The new ResultDB system has the ability to associate test results with > Monorail components and teams, but in order to do that, we need to > upload the mapping information contained in the testing/DIR_METADATA > files along with the test results. > > This CL adds a gclient hook to generate the metadata in a > ResultDB-friendly format that can be accessed by `rdb` and uploaded > as part of a test invocation, and makes the generated data a > dependency of the bin/run_* test scripts, to ensure that every > test invocation will have the data. > > Change-Id: I83dcf7f460b6fbd1d4c23616d972510712019148 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568896 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Chan Li <chanli@chromium.org> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#861612} Bug: 1191087 Change-Id: I767fcbfb295723444902cfae27e25398df98b5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785124 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#866323}
blueboxd
pushed a commit
that referenced
this issue
Sep 29, 2022
This reverts commit aaaa0e3. Reason for revert: crbug.com/1354945 Original change's description: > [Dr-Dc] Add more devices to be blocklisted. > > Add more devices to be blocklisted here in chrome code since adding it > via finch is very slow. > > (cherry picked from commit 50a85fa) > > Bug: 1340054 > Change-Id: I3343d67ede012765fbfe36d6feb34a505d1a389e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842363 > Auto-Submit: vikas soni <vikassoni@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Original-Commit-Position: refs/heads/main@{#1037178} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840823 > Reviewed-by: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/branch-heads/5249@{#4} > Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826} Bug: 1340054 Change-Id: I20133a4a07dd9d389172a53585e39765cfbf8e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848921 Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5249@{#34} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd
pushed a commit
that referenced
this issue
Oct 7, 2022
This reverts commit b121781. Reason for revert: breaks asan see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/106685/test-results ================================================================= ==7990==ERROR: AddressSanitizer: heap-use-after-free on address 0x61500014a3c8 at pc 0x55bcdbc9090d bp 0x7ffe8c468ab0 sp 0x7ffe8c468aa8 READ of size 8 at 0x61500014a3c8 thread T0 (browser_tests) #0 0x55bcdbc9090c in begin buildtools/third_party/libc++/trunk/include/vector:1374:33 #1 0x55bcdbc9090c in begin<std::Cr::vector<base::internal::UncheckedObserverAdapter, std::Cr::allocator<base::internal::UncheckedObserverAdapter> > &> base/ranges/ranges.h:44:37 #2 0x55bcdbc9090c in begin<std::Cr::vector<base::internal::UncheckedObserverAdapter, std::Cr::allocator<base::internal::UncheckedObserverAdapter> > &> base/ranges/ranges.h:105:10 #3 0x55bcdbc9090c in find_if<std::Cr::vector<base::internal::UncheckedObserverAdapter, std::Cr::allocator<base::internal::UncheckedObserverAdapter> > &, (lambda at ../../base/observer_list.h:287:21), base::identity, std::Cr::random_access_iterator_tag> base/ranges/algorithm.h:483:26 #4 0x55bcdbc9090c in base::ObserverList<permissions::PermissionRequestManager::Observer, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(permissions::PermissionRequestManager::Observer const*) base/observer_list.h:286:21 #5 0x55bcdf91c380 in Reset base/scoped_observation.h:86:7 #6 0x55bcdf91c380 in ~ScopedObservation base/scoped_observation.h:70:26 #7 0x55bcdf91c380 in permissions::PermissionRequestObserver::~PermissionRequestObserver() components/permissions/test/permission_request_observer.cc:14:55 #8 0x55bccbcd2629 in PermissionRequestChipGestureSensitiveBrowserTest_ShouldUpdateActiverPRMAndObservations_Test::RunTestOnMainThread() chrome/browser/ui/views/permissions/permission_request_chip_browsertest.cc:294:1 #9 0x55bce299402f in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:883:7 #10 0x55bce299accf in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> base/functional/bind_internal.h:643:12 #11 0x55bce299accf in MakeItSo<void (content::BrowserTestBase::*)(), std::Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::RawPtrBanDanglingIfSupported> > > base/functional/bind_internal.h:822:12 #12 0x55bce299accf in RunImpl<void (content::BrowserTestBase::*)(), std::Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::RawPtrBanDanglingIfSupported> >, 0UL> base/functional/bind_internal.h:916:12 #13 0x55bce299accf in base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::RawPtrBanDanglingIfSupported>>, void ()>::RunOnce(base::internal::BindStateBase*) base/functional/bind_internal.h:867:12 Original change's description: > Make confirmation chip independent of request chip > > See design doc: go/confirmation-chip > > Bug: 1364276 > Change-Id: Iab08a5bb96271d45101ba68c0134751b921b7667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921717 > Commit-Queue: Florian Jacky <fjacky@chromium.org> > Reviewed-by: Illia Klimov <elklm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1055397} Bug: 1364276 Change-Id: Iecf56cfafaf15a2ab8329138f7508de8afd0a341 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937182 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Avi Drissman <avi@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055548}
blueboxd
pushed a commit
that referenced
this issue
Oct 7, 2022
Change-Id: Ib3aa7aba06934e138029d52c1fca013e735d818b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934559 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249_91@{#4} Cr-Branched-From: fa96d5f-refs/branch-heads/5249@{#707} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd
pushed a commit
that referenced
this issue
Oct 13, 2022
This CL is fixing the bucket for ShutdownType2 for process that do an early exit within BasicStartupComplete(...). These cases can be repro on Linux with these commands: 1) ./chrome --version 2) ./chrome --product-version 3) ./chrome --credits 4) ./chrome --diagnostics The ChromeMainDelegate must be robust for cases where the BasicStartupComplete is not fully executed due to an error (early exits). The chrome logging was assuming it was initialized. This CL is ensuring the code was initialized to call the corresponding shutdown code. [1004/174420.541708:FATAL:logging_chrome.cc(468)] Check failed: chrome_logging_initialized_. Attempted to clean up logging when it wasn't initialized. #0 0x55a6a8cf8952 base::debug::CollectStackTrace() #1 0x55a6a8be9cc3 base::debug::StackTrace::StackTrace() #2 0x55a6a8c0468f logging::LogMessage::~LogMessage() #3 0x55a6a8c0549e logging::LogMessage::~LogMessage() #4 0x55a6ab92495b logging::CleanupChromeLogging() #5 0x55a6a355f45b ChromeMainDelegate::ProcessExiting() #6 0x55a6a85ed50d content::ContentMainRunnerImpl::Shutdown() #7 0x55a6a85eaddb content::ContentMainRunnerImpl::~ContentMainRunnerImpl() #8 0x55a6a85eaf1e content::ContentMainRunnerImpl::~ContentMainRunnerImpl() #9 0x55a6a85e8bb0 content::ContentMain() #10 0x55a6a355d236 ChromeMain #11 0x7fc168e4781d __libc_start_main #12 0x55a6a355d02a _start Change-Id: I51c9d7b18535f69d6733a8d0b88d0a80111bdcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931775 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058086}
blueboxd
pushed a commit
that referenced
this issue
Oct 21, 2022
`char16_t` (which `UChar` is defined as) cannot be used to alias general memory.
Yet we try to use it to read a `blink::QualifiedName::QualifiedNameImpl` among other things.
This is UB, and gcc -O2 misoptimizes it. When chromium is compiled with allocator shim, this manifests as an immediate crash:
* frame #0: 0x0000556e1280927b electron`FreelistCorruptionDetected [inlined] operator() at partition_freelist_entry.h:31
frame #1: 0x0000556e1280927a electron`FreelistCorruptionDetected(extra=48) at partition_freelist_entry.h:31
frame #2: 0x0000556e129dd167 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(partition_alloc::PartitionRoot<true>*, unsigned int, unsigned long, unsigned long, bool*) at partition_freelist_entry.h:303
frame #3: 0x0000556e129dd162 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(partition_alloc::PartitionRoot<true>*, unsigned int, unsigned long, unsigned long, bool*) [inlined] partition_alloc::internal::PartitionFreelistEntry::GetNext(unsigned long) const at partition_freelist_entry.h:328
frame #4: 0x0000556e129dd162 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(partition_alloc::PartitionRoot<true>*, unsigned int, unsigned long, unsigned long, bool*) [inlined] partition_alloc::internal::SlotSpanMetadata<true>::PopForAlloc(unsigned long) at partition_page.h:739
frame #5: 0x0000556e129dd162 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(this=0x0000556e19292598, root=0x0000556e19292500, flags=33, raw_size=<unavailable>, slot_span_alignment=48, is_already_zeroed=0x00007ffe8f1196f7) at partition_bucket.cc:1354
frame #6: 0x0000556e129ddbc0 electron`partition_alloc::ThreadCache::FillBucket(unsigned long) at partition_root.h:1076
frame #7: 0x0000556e129ddbbb electron`partition_alloc::ThreadCache::FillBucket(this=<unavailable>, bucket_index=5755259732000) at thread_cache.cc:607
frame #8: 0x0000556e129dfd3a electron`base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*) at thread_cache.h:525
frame #9: 0x0000556e129dfd18 electron`base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*) at partition_root.h:1742
frame #10: 0x0000556e129dfb18 electron`base::internal::PartitionMalloc((null)=<unavailable>, size=40, context=<unavailable>) at allocator_shim_default_dispatch_to_partition_alloc.cc:304
frame #11: 0x0000556e128dbe43 electron`::malloc(unsigned long) at allocator_shim.cc:201:37
frame #12: 0x0000556e128dbe30 electron`::malloc(size=40) at allocator_shim_override_libc_symbols.h:35:20
frame #13: 0x0000556e16c0f6e6 electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) [inlined] WTF::RefCounted<blink::QualifiedName::QualifiedNameImpl, WTF::DefaultRefCountedTraits<blink::QualifiedName::QualifiedNameImpl>>::operator new(unsigned long) at ref_counted.h:44
frame #14: 0x0000556e16c0f6e1 electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) [inlined] blink::QualifiedName::QualifiedNameImpl::Create((null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>) at qualified_name.h:62
frame #15: 0x0000556e16c0f6dd electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) at qualified_name.cc:69
frame #16: 0x0000556e16c0f6ba electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) [inlined] void WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>::Translate<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedNameData&, blink::QualifiedNameData>(blink::QualifiedName::QualifiedNameImpl*&, blink::QualifiedNameData&, blink::QualifiedNameData const&, unsigned int) at hash_set.h:184
frame #17: 0x0000556e16c0f6ba electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>((null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>) (.constprop.0) at hash_table.h:1481
frame #18: 0x0000556e1492f9cf electron`blink::QualifiedName::QualifiedName(WTF::AtomicString const&, WTF::AtomicString const&, WTF::AtomicString const&) [inlined] WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashSet<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::AddWithTranslator<blink::QNameComponentsTranslator, blink::QualifiedNameData&>(blink::QualifiedNameData&) at hash_set.h:307
frame #19: 0x0000556e1492f9ca electron`blink::QualifiedName::QualifiedName((null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>) at qualified_name.cc:81
When chromium is compiled with system malloc, this manifests as graphical glitches, followed by a crash much later on.
It is worth noting that this exact code snippet was discussed on the GCC bugtracker in 2014
(predating the forking of Chromium from WebKit):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60546#c21
The corresponding code no longer exists in WebKit.
Attached patch makes the HashMemory function type-safe without changing the API for other users of StringHasher.
Bug: 819294
Change-Id: Iac11ec77501c2f1d6d01db85d5b9d544adeaf71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3968507
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Cr-Commit-Position: refs/heads/main@{#1061939}
blueboxd
pushed a commit
that referenced
this issue
Oct 23, 2022
A11y is moved to the end of the document lifecycle, where it can occur in parallel with other tasks. Parts of the code that used to force layout updates in order to update the AX tree now call UpdateAXForAllDocuments(), a new method introduced in the previous CL, which first updates the lifecycle and then manually updates the AX tree. Additional code cleanups in AXObjectCacheImpl related to popups were also now possible. Test changes: * Changes to css-display-expected-win.txt and content-editable-notifications.html were due to a subtle change in event ordering, but are still correct. Follow-ups: * Try DCHECK(!IsFrozen()) inside of UpdateAXForAllDocuments(). * Update SCOPED_DISALLOW_LIFECYCLE_TRANSITION to use document_ and popup_document_ and remove the argument. Bug: None Change-Id: If01ee1b43672e58be5a120eaa7cc9572170f6257 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3964415 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062392}
blueboxd
pushed a commit
that referenced
this issue
Oct 29, 2022
It is not practical to revert each CL individually, so I have created this CL to bundle all the reverts together. da5d2ff 4463d9a 2278ce2 97778ef 27716a2 76b1d09 faed33f 14c61af 962d5db b18739d 4066dd6 crrev.com/c/3964415 crrev.com/c/3970603 crrev.com/c/3974832 crrev.com/c/3976209 crrev.com/c/3971173 crrev.com/c/3972090 crrev.com/c/3970627 crrev.com/c/3970885 crrev.com/c/3976391 crrev.com/c/3978892 crrev.com/c/3975164 Revert "Move a11y to post-lifecycle steps (iteration #4)" This reverts commit da5d2ff. Revert "AXObjectCache is still dirty if tree updates are paused" This reverts commit 4463d9a. Revert "Remove extra call to ProcessDeferredAccessibilityEvents()" This reverts commit 2278ce2. Revert "More robust handling of aria-activedescendant invalidations" This reverts commit 97778ef. Revert "Avoid redundant calls to UpdateAXForAllDocuments()" This reverts commit 27716a2. Revert "Restore popup guard" This reverts commit 76b1d09. Revert "Use DCHECKs to prevent recursive calls in AXObjectCacheImpl" This reverts commit faed33f. Revert "Avoid raw pointer in WebAXObjectProxyList" This reverts commit 14c61af. Revert "Clean up load logic so that it's easier to understand" This reverts commit 962d5db. Revert "Deflake web tests that create the root ax object" This reverts commit b18739d. Revert "Do not create orphaned AXObjects for whitespace text" This reverts commit 4066dd6. Bug: 1376991 Change-Id: I9869417a9b9333fdf3a6b5796f94eabf9ac168e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3990067 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Owners-Override: Leo Zhang <googleo@google.com> Reviewed-by: Colin Kincaid <ckincaid@chromium.org> Cr-Commit-Position: refs/heads/main@{#1064718}
blueboxd
pushed a commit
that referenced
this issue
Nov 1, 2022
Fixes HTTPTransport tests that fail with:
Uninitialized bytes in __interceptor_fopen64 at offset 0 inside [0x70200001ce60, 25)
==3342==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7f115b1ef5d9 in BIO_new_file ??:0:0
#1 0x7f115b22117d in COMP_CTX_get_type ??:?
#2 0x7f115b22278c in CONF_modules_load_file ??:0:0
#3 0x7f115b222a4f in OPENSSL_config ??:?
#4 0x7f115b2b94f3 in HMAC_CTX_get_md ??:?
#5 0x7f115ed084de in __pthread_once_slow ??:0:0
#6 0x7f115b324aac in CRYPTO_THREAD_run_once ??:0:0
#7 0x7f115b2b9b77 in OPENSSL_init_crypto ??:0:0
#8 0x7f115dfa3574 in OPENSSL_init_ssl ??:0:0
R=thestig
Change-Id: Ie6aa3223df4d50dedcc59c2f757de62ff35ac1aa
Bug: 1260217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3993372
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1065765}
blueboxd
pushed a commit
that referenced
this issue
Nov 6, 2022
This class removes the friend classes of ProfileDestroyer as they were calling internal methods that bypassed the creation of ProfileDestroyer objects and called DestroyOffTheRecordProfileNow directly, which has led to crashes in the past (https://crbug.com/1337388#c11). Note: This CL changes the behavior of ProfileDestroyer when destroying an off-the-record profile immediately via ProfileDestroyer::DestroyOTRProfileImmediately(). With the new implementation, the CHECK in ~ProfileDestroyer() will trigger and we may see an increase of crashes with this signature. Before this CL, the app will still crash, but in a different code location (see test), with the stack trace below: [456919:456919:FATAL:dependency_manager.cc(173)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again. #0 0x7fe99bc08932 base::debug::CollectStackTrace() #1 0x7fe99bb348a3 base::debug::StackTrace::StackTrace() #2 0x7fe99bb4fff3 logging::LogMessage::~LogMessage() #3 0x7fe99bb50e9e logging::LogMessage::~LogMessage() #4 0x7fe9992b7396 DependencyManager::AssertContextWasntDestroyed() #5 0x7fe996fe7e32 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x7fe9992b79af KeyedServiceFactory::GetServiceForContext() #7 0x55c217195682 extensions::ChromeContentBrowserClientExtensionsPart::SiteInstanceDeleting() #8 0x55c2162f1f9d ChromeContentBrowserClient::SiteInstanceDeleting() #9 0x7fe99a5bc5af content::SiteInstanceImpl::~SiteInstanceImpl() #10 0x7fe99a5bc6de content::SiteInstanceImpl::~SiteInstanceImpl() #11 0x55c21327864f ProfileDestroyerTest::~ProfileDestroyerTest() Bug: 1378254 Change-Id: Ib144ffe8d2344dc7efc7cd22360e8fce0b2beb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3978432 Reviewed-by: Alex Ilin <alexilin@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/main@{#1067599}
blueboxd
pushed a commit
that referenced
this issue
Nov 30, 2022
In View::HandleAccessibleAction, accessibility sends both a press and
release mouse event to the view instance.
Unfortunately, if the view deletes itself immediately after receiving
the mouse press event, the subsequent mouse release event causes a UAF.
e.g. for illustrative purposes, here's the flow:
bool HandleAccessibleAction(...) {
view->OnEvent(mouse_press);
// |view| is now deleted.
view->OnEvent(mouse_release);
// UAF.
}
Fix this by overriding HandleAccessibleAction in the self-deleting view.
Notes:
The deletion stack for the WindowCycleItemView is
#3 0x560338183db8 in operator() buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:49:5
#4 0x560338183db8 in reset buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:281:7
#5 0x560338183db8 in ~unique_ptr buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:247:75
#6 0x560338183db8 in views::View::DoRemoveChildView(views::View*, bool, bool, views::View*) ui/views/view.cc:2739:1
#7 0x560338183fe4 in views::View::RemoveAllChildViews() ui/views/view.cc:341:5
#8 0x560333f50cbb in ash::WindowCycleView::DestroyContents() ash/wm/window_cycle/window_cycle_view.cc:379:3
#9 0x560333f4b3e7 in ash::WindowCycleList::~WindowCycleList() ash/wm/window_cycle/window_cycle_list.cc:139:18
#10 0x560333f4b747 in ash::WindowCycleList::~WindowCycleList() ash/wm/window_cycle/window_cycle_list.cc:117:37
#11 0x560333f475e8 in operator() buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:49:5
#12 0x560333f475e8 in reset buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:281:7
#13 0x560333f475e8 in ash::WindowCycleController::StopCycling() ash/wm/window_cycle/window_cycle_controller.cc:421:22
#14 0x560333f5944c in ash::WindowCycleItemView::OnMousePressed(ui::MouseEvent const&) ash/wm/window_cycle/window_cycle_item_view.cc:53:44
#15 0x560338193ae2 in views::View::ProcessMousePressed(ui::MouseEvent const&) ui/views/view.cc:3109:23
#16 0x56033819362d in views::View::OnMouseEvent(ui::MouseEvent*) ui/views/view.cc:1492:11
Bug: 1380602
Change-Id: I2533dc299c0f5f5bb32efa130e6d564cb70d4613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4046647
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076637}
blueboxd
pushed a commit
that referenced
this issue
Nov 30, 2022
The previous fix[0] overlooked that number_of_payment_method_manifest_to_download_ could be synchronously reduced to 0 during the loop, as opposed to only in the last iteration. This CL corrects that, by pre-allocating number_of_payment_method_manifest_to_download_ ahead of the loop and decrementing it every loop iteration. As such, only the last iteration should be able to have it reduced to zero. [0]: https://chromium-review.googlesource.com/c/chromium/src/+/3920030 (cherry picked from commit c5c1f9c) (cherry picked from commit c8cf0673b7740f637ccbabb69e19cd7a413f6055) Bug: 1378286 Change-Id: Ia2857a0775dc12aca1a83b3f3087836c9caad168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3983012 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/main@{#1063872} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3982794 Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5383@{#4} Cr-Original-Branched-From: 4340068-refs/heads/main@{#1063734} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3983496 Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#364} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd
pushed a commit
that referenced
this issue
Dec 8, 2022
Change-Id: Ib6d339515515e5b97ffb82aa53bc77c5f6e6c8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4072449 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359_71@{#4} Cr-Branched-From: 1e0e386-refs/branch-heads/5359@{#1016} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd
pushed a commit
that referenced
this issue
Jan 23, 2023
Add a new line between learn more description #4 and #5. Bug: 1378703 Change-Id: I555428f62fe5e5c93085876843f49ed34b834ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4180728 Reviewed-by: Nicola Tommasi <tommasin@chromium.org> Auto-Submit: Olesia Marukhno <olesiamarukhno@google.com> Commit-Queue: Nicola Tommasi <tommasin@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/main@{#1095021}
blueboxd
pushed a commit
that referenced
this issue
Feb 8, 2023
(cherry picked from commit 9a081ad) Bug: 1401730 Change-Id: Idaf753d3fa8a620902905b92d650d808928014c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4111052 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Nicola Tommasi <tommasin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1084377} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114265 Owners-Override: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/branch-heads/5481@{#4} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd
pushed a commit
that referenced
this issue
Feb 21, 2023
…dows." This is a reland of commit 01d8e55 Original change's description: > [FSA] Update UNC path rejection to only local UNC path on Windows. > > The previous check `PathIsUNC()` was too broad and included both external/network UNC path as well as local UNC path (i.e. "\\LOCALHOST\c$\..."). As we want to avoid different variants of "local" UNC from bypassing the blocklist check (and that we currently do not have any blocklist on external path), external UNC path will be allowed again with this change. Unfortunately, there is no complete way to normalize different variations of Windows path, so we use some heuristics by checking (1) UNC root via `base::FilePath::IsNetwork()`, (2) hostname, which may represent local system and (3) `$` character in share name. > > Bug: 1326788, 1408321 > Change-Id: I030b2719781ac21a145ceb83ce53e7f129b4ce2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200953 > Reviewed-by: Austin Sullivan <asully@chromium.org> > Commit-Queue: Daseul Lee <dslee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1101673} (cherry picked from commit 403d13a) Bug: 1326788, 1408321 Change-Id: I329391304b9afd7ed0160c8bd3e41985e81f4a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4226252 Commit-Queue: Daseul Lee <dslee@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: James Forshaw <forshaw@chromium.org> Reviewed-by: Austin Sullivan <asully@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1101794} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240562 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5481_77@{#4} Cr-Branched-From: 65ed616-refs/branch-heads/5481@{#839} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd
pushed a commit
that referenced
this issue
Mar 7, 2023
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I8d820bda49b1da74e075b7a8bac86b295dcd851f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198969 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#4} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd
pushed a commit
that referenced
this issue
Apr 14, 2023
R=kuanhuang@google.com Change-Id: Ib5d5eda3c8b2672525558ff03b437fe1567f892b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4289430 Reviewed-by: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{#4} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd
pushed a commit
that referenced
this issue
Apr 14, 2023
https://chromium.googlesource.com/v8/v8.git/+log/cbae4e69312c..057195e26fc9 2023-04-03 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.2.214.11 2023-04-03 alexschulze@chromium.org [builtins][pgo] Add Win{32,64} instrumented builder config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-release-1 Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in v8 11.2: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m112: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md (cherry picked from commit 91b5a27) Bug: None Tbr: v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4d5732910c58d870bdde5e3d97f476d240cf4d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4391557 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5615@{#1067} Cr-Original-Branched-From: 9c6408e-refs/heads/main@{#1109224} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424093 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5615_51@{#4} Cr-Branched-From: 86d49da-refs/branch-heads/5615@{#938} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd
pushed a commit
that referenced
this issue
May 9, 2023
R=hypan@google.com Change-Id: I29c771ff9407fd6f2e0293d56204ee1304f88531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370718 Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5672@{#4} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd
pushed a commit
that referenced
this issue
May 9, 2023
Change-Id: I36b6a221d13ff79dd24d2ffe57f036a91716b19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503891 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672_63@{#4} Cr-Branched-From: 0e1a447-refs/branch-heads/5672@{#912} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd
pushed a commit
that referenced
this issue
May 27, 2023
R=sshrimp@google.com Change-Id: I8cc5c7fb9a95b43ca86075f3fce2a6328447fa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4480751 Reviewed-by: Struan Shrimpton <sshrimp@google.com> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{#4} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
blueboxd
pushed a commit
that referenced
this issue
Jun 8, 2023
If the user has reloaded a page asking for all subresources to be reloaded from network, we should extend this to FLEDGE resources, too. This required memorizing the reload mode in RenderFrameHostImpl, since it previously didn't survive past NavigationRequest. See report WICG/turtledove#499, issue #4 Bug: 1452127 Change-Id: If017a7b1e59155058cbe59e84341003e75604f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590272 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/main@{#1154577}
blueboxd
pushed a commit
that referenced
this issue
Jun 8, 2023
There are some credit card details retrieval flows like local cards, and VCN green path in which the user is not presented with any form of authentication challenge. With the Mandatory Reauth project, we change this, and give users the option to opt-in to be presented with the device authentication challenge in such cases. This change is a part of CLs that implement showing this prompt on a bottom sheet. Change #4: Add a delegate to relay the bottom sheet events to the native side. Implementation doc: http://shortn/_FNEm7HUEaa Low-Coverage-Reason: The delegate is tested in the module test. Bug: 1444556 Change-Id: I80d8aa73ddafea9a751210809838968917679fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4523083 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com> Cr-Commit-Position: refs/heads/main@{#1154628}
blueboxd
pushed a commit
that referenced
this issue
Jun 8, 2023
Change-Id: I1be03785c97d003e0d08f124d6816940bf7c72d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582333 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735_90@{#4} Cr-Branched-From: 386bc09-refs/branch-heads/5735@{#1052} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
blueboxd
pushed a commit
that referenced
this issue
Jul 22, 2023
Change-Id: I0a21925d9cd08ff1eb878ddeeb2c56464721906c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4688236 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790_90@{#4} Cr-Branched-From: 86fb9d0-refs/branch-heads/5790@{#1583} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
|
@Wowfunhappy I was taking a look at what it would take to get the unified titlebar style. Seems the issue was introduced with the native cocoa -> macviews redesign, as even on chrome 65, if you force enable macviews flag, then the titlebar is messed up. Take a particular look at https://bugs.chromium.org/p/chromium/issues/detail?id=425229 They have screenshots of the progress, and the one at It seems https://chromium.googlesource.com/chromium/src.git/+/fd0ea6990e2c25537ee0b708d1ce7eeafc61842a was the key change. However I don't see anything that would actually be 10.10 specific there, |
|
Aha I think it's https://source.chromium.org/chromium/chromium/src/+/3401663175b3a9803095bd43434d6886b6c2b378 and https://source.chromium.org/chromium/chromium/src/+/87ffcf9b935cc134c2dd8ecd4ebeb400eae03042 that broke it on 10.9? Particularly the use of Possibly a separate issue is also https://bugs.chromium.org/p/chromium/issues/detail?id=520373 although I don't think that is related to the issue since it was always gated on >= 10.11 |
blueboxd
pushed a commit
that referenced
this issue
Sep 17, 2023
Change-Id: Ifd823e42eb035b3429836aba938c57dcb056bd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864759 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938_62@{#4} Cr-Branched-From: 25a7172-refs/branch-heads/5938@{#1146} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
blueboxd
pushed a commit
that referenced
this issue
Dec 10, 2023
Change-Id: I38057354a73ff15ef9d29eb61e32f7ddb85d2506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5077765 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099_56@{#4} Cr-Branched-From: 6c113a6-refs/branch-heads/6099@{#1192} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey thanks for doing this project. I noticed the min/max/close buttons are missing and the full screen button is only partially shown. We had this same issue a while back with Pale Moon on Mac. Ended up having to revert the removal of the lion theme ( https://hg.mozilla.org/mozilla-central/rev/c3eb99e7b16d ) to get them back. Chrome code is alien to me, but i hope after looking at that link you might be able to make some sense of it on the chrome side, as it may be a similar issue.
The text was updated successfully, but these errors were encountered: