Crashing when download a file, OS X Lion 10.7.5 #6

Ciombenu · 2020-12-12T15:37:24Z

Hi, thank you again.

Starting with version 833979 - 89.0.4346.0 Chromium crashing when trying to download a file. As tried all the versions until the last one from this moment 836385 and the same error. I use a macbook 4.1, mac os x lion 10.7.5.

Regards

Chromium_2020-12-12-172103_Cristians-MacBook.crash.zip

blueboxd · 2020-12-14T17:24:07Z

Thank you so much for your report!
And sorry for the inconvenience.
Fixed at 836594.
Caused by removal of code for 10.10 again...

This change enables Chrome OS Chrome builds running on non-cros linux to work with Espeak-ng. On linux builds, dcheck always triggers an error in mojo. Consequently, in TtsService, where the service makes mojo calls on a Remote within the audio thread, a DCHECK was hit: 2021-01-11T22:46:32.666960Z FATAL chrome[2743839:2743847]: [sequence_checker.h(120)] Check failed: checker.CalledOnValidSequence(). #0 0x7f7ee68c681f base::debug::CollectStackTrace() #1 0x7f7ee665fd8a base::debug::StackTrace::StackTrace() #2 0x7f7ee665fd45 base::debug::StackTrace::StackTrace() #3 0x7f7ee66a9057 logging::LogMessage::~LogMessage() #4 0x7f7ee66a9769 logging::LogMessage::~LogMessage() #5 0x7f7ee6620c1b logging::CheckError::~CheckError() #6 0x7f7ee564e09c base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #7 0x7f7ee566c068 mojo::InterfaceEndpointClient::SendMessage() #8 0x7f7ee566c99f mojo::InterfaceEndpointClient::Accept() #9 0x565159b53c29 chromeos::tts::mojom::TtsEventObserverProxy::OnStart() #10 0x56515c4e3a5a chromeos::tts::TtsService::Render() #11 0x7f7ed8648f02 media::AudioOutputDeviceThreadCallback::Process() #12 0x7f7ed861fe9d media::AudioDeviceThread::ThreadMain() #13 0x7f7ee68fb1ab base::(anonymous namespace)::ThreadFunc() #14 0x7f7ea303fea7 start_thread #15 0x7f7ea2baad8f clone Fix this by queueing up already rendered audio buffers and processing them on the main thread's task runner. Test: manually on a linux chromeos build. Verify that web speech produces speech through Espeak. Change-Id: I4b1e5b0a6e72e4e571b5a26fde731acc57936894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621983 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842622}

This reverts commit 8aca3b4. Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview [ RUN ] WindowOpenApiTest.PopupBlockingExtension 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure Expected equality of these values: num_browsers Which is: 4 chrome::GetBrowserCount(browser->profile()) Which is: 2 Google Test trace: ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 Stack trace: #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #6 0x563646f2068c base::internal::Invoker<>::RunOnce() #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() #20 0x7fb5dc82a804 content::BrowserMain() #21 0x7fb5de9aae56 content::RunBrowserProcessMain() #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() #24 0x7fb5de9a9106 content::RunContentProcess() #25 0x7fb5de9a9a3d content::ContentMain() #26 0x563646f1cb13 content::BrowserTestBase::SetUp() #27 0x563645acb283 InProcessBrowserTest::SetUp() #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() Original change's description: > Support multiple receivers for Cros APIs. > > With this CL, most of Cros API starts to support multiple receivers. > AshChromeService and LacrosChromeService are exceptions. > > Bug: 1148448 > Test: Build and run Lacros on a DUT. > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842869} TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842943}

…vice" This reverts commit 85753b0. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() chromium#36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() chromium#39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() chromium#42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842980}

This reverts commit 640009e. Reason for revert: The original CL looks wrongly identified as a cause of test breakage. Even without this CL, the test is flaky. Original change's description: > Revert "Support multiple receivers for Cros APIs." > > This reverts commit 8aca3b4. > > Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview > > [ RUN ] WindowOpenApiTest.PopupBlockingExtension > 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. > 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag > 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. > 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user > 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. > 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. > 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry > 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. > 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found > 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files > 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als > 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. > 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files > 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure > Expected equality of these values: > num_browsers > Which is: 4 > chrome::GetBrowserCount(browser->profile()) > Which is: 2 > Google Test trace: > ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 > Stack trace: > #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() > #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() > #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() > #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() > #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #6 0x563646f2068c base::internal::Invoker<>::RunOnce() > #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv > #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() > #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() > #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() > #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() > #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() > #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv > #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() > #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() > #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() > #20 0x7fb5dc82a804 content::BrowserMain() > #21 0x7fb5de9aae56 content::RunBrowserProcessMain() > #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() > #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() > #24 0x7fb5de9a9106 content::RunContentProcess() > #25 0x7fb5de9a9a3d content::ContentMain() > #26 0x563646f1cb13 content::BrowserTestBase::SetUp() > #27 0x563645acb283 InProcessBrowserTest::SetUp() > #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() > #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() > #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() > > > > Original change's description: > > Support multiple receivers for Cros APIs. > > > > With this CL, most of Cros API starts to support multiple receivers. > > AshChromeService and LacrosChromeService are exceptions. > > > > Bug: 1148448 > > Test: Build and run Lacros on a DUT. > > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842869} > > TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1148448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842943} TBR=jamescook@chromium.org,hidehiko@chromium.org,kolos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148448 Change-Id: Ic2ec65fa476b9b67a705497aad1cf3f1bffa0da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633482 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844778}

In the attached bug, speech is triggered in a startup, fresh imaged environment. To replicate this, `rm -rf /home/chronos/*`, then trigger some tts after boot. The browser process hangs, e.g. gdb attach <browser_pid> ... bt ... #5 0x000058e02342da8f in TtsExtensionEngine::GetVoices(content::BrowserContext*, std::__1::vector<content::VoiceData, std::__1::allocator<content::VoiceData> >*) () #6 0x000058e021612615 in content::TtsControllerImpl::SpeakNow(std::__1::unique_ptr<content::TtsUtterance, std::__1::default_delete<content::TtsUtterance> >) () #7 0x000058e021612e8f in content::TtsControllerImpl::SpeakNextUtterance() () #8 0x000058e01ff769d4 in content::TtsControllerImpl::VoicesChanged() () #9 0x000058e02342eeb4 in ExtensionTtsEngineUpdateVoicesFunction::Run() () #10 0x000058e02185ebe2 in ExtensionFunction::RunWithValidation() () #11 0x000058e021860c5d in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int, base::RepeatingCallback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) () #12 0x000058e021860773 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int) () #13 0x000058e0218818ea in bool IPC::MessageT<ExtensionHostMsg_Request_Meta, std::__1::tuple<ExtensionHostMsg_Request_Params>, void>::Dispatch<extensions::ExtensionWebContentsObserver, extensions::ExtensionWebContentsObserver, content::RenderFrameHost, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)>(IPC::Message const*, extensions::ExtensionWebContentsObserver*, extensions::ExtensionWebContentsObserver*, content::RenderFrameHost*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)) () The hang: TtsControllerImpl::SpeakNextUtterance -> TtsControllerImpl::SpeakNow -> TtsControllerImpl::OnSpeakFinished -> enqueues the utterance back onto |utterance_list_| on failure. which occurs all while(... !utterance_list_.empty()), leading to a browser hang. Solution: The above utterance fails immediately because the voice is not yet ready. We fix this by never returning the voice in the first place, in TtsControllerImpl::GetVoices. Therefore, we never get to the point where an utterance matches against a not yet initialized voice, leading to an attempt to speak, then to an immediate failure, next to a re-enqueue, and finally a hang. Bug: 1161107 Change-Id: I2d88c0c6e86bf79ad9ac5dc5240825848daa40ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642746 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#845861}

This reverts commit d2adbc5. Reason for revert: causing ~600 html failures on tests Example stack trace STDERR: Received signal 11 SEGV_MAPERR 000000000099 STDERR: #0 0x56419ad17d39 base::debug::CollectStackTrace() STDERR: #1 0x56419ac8fc63 base::debug::StackTrace::StackTrace() STDERR: #2 0x56419ad178e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f96ed01d390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) STDERR: #4 0x56419c8a9228 WTF::StaticSingleton<>::StaticSingleton<>() STDERR: #5 0x56419c8a90cc blink::CounterStyleMap::GetUACounterStyleMap() STDERR: #6 0x56419c8da407 blink::StyleEngine::FindCounterStyleAcrossScopes() STDERR: #7 0x56419ce564a7 blink::ListMarker::GetCounterStyle() STDERR: #8 0x56419ce5640e blink::ListMarker::GetListStyleCategory() STDERR: #9 0x56419ce56d3e blink::ListMarker::InlineMarginsForInside() STDERR: #10 0x56419c8846ae blink::StyleAdjuster::AdjustComputedStyle() STDERR: #11 0x56419c877f3c blink::StyleResolver::PseudoStyleForElement() STDERR: #12 0x56419c964063 blink::Element::StyleForPseudoElement() STDERR: #13 0x56419c9a6bd9 blink::PseudoElement::CustomStyleForLayoutObject() STDERR: #14 0x56419c95b52f blink::Element::StyleForLayoutObject() etc see e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/22892/test-results Original change's description: > Refactor counter style updates > > Currently, counter style updates is a phase in UpdateActiveStyles. This > patch moves it out as a standalone phase of UpdateStyleAndLayoutTree, > so that we update counter styles only when needed. > > This patch also adds MarkCounterStylesNeedUpdate() to indicate whether > counter style updates are needed. > > Note: After refactoring, the framework of counter style updates looks > almost identical to font updates. This is intentional. We will try to > unify them in the future. > > Bug: 687225 > Change-Id: If07de2878ae5faa6800644a967029a569bef566a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846203} TBR=xiaochengh@chromium.org,futhark@chromium.org,andruud@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3c1e09dce14cd4edb366b911d3aaf5da66b2b100 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 687225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644742 Reviewed-by: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#846262}

This reverts commit 0eb6b1e. Reason for revert: Suspect causing ash_unittests failure on linux-chromeos-dbg Builder: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg First build failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22344 Sample stacktrace: [1/5610] AcceleratorCommandsTest.ToggleMinimized (1848 ms) [ RUN ] AcceleratorCommandsTest.ToggleMaximized [capture_mode_controller.cc(307)] Check failed: !message_center::MessageViewFactory::HasCustomNotificationViewFactory( kScreenCaptureNotificationType). #0 0x7f29bf492bbf base::debug::CollectStackTrace() #1 0x7f29bf22770a base::debug::StackTrace::StackTrace() #2 0x7f29bf2276c5 base::debug::StackTrace::StackTrace() #3 0x7f29bf270d17 logging::LogMessage::~LogMessage() #4 0x7f29bf271419 logging::LogMessage::~LogMessage() #5 0x7f29bf1e80bb logging::CheckError::~CheckError() #6 0x7f29c3a68b49 ash::CaptureModeController::CaptureModeController() #7 0x7f29c3e2eceb std::__Cr::make_unique<>() #8 0x7f29c3e1fa8b ash::Shell::Init() #9 0x7f29c3e1f5de ash::Shell::CreateInstance() #10 0x55fa098eea0e ash::AshTestHelper::SetUp() #11 0x55fa098ebdc8 ash::AshTestBase::SetUp() #12 0x55fa098ebc0e ash::AshTestBase::SetUp() Original change's description: > capture mode: implement customized image capture notification. > > Bug: 1159111 > Change-Id: I5a96480a929a05a7782f51ae6baea8ddc7c9df10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632390 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846957} TBR=estade@chromium.org,xdai@chromium.org,afakhry@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id535618e328a75dbc829d8b662c8dc99dfe25f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648987 Reviewed-by: Takashi Sakamoto <tasak@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#847060}

Use SequenceChecker::EnableStackLogging() to enable this logging. When DCHECK() fails for a ThreadChecker or SequenceChecker, if the error is not at the site of checking, it takes a great amount of knowledge and persistence to figure out where the erroroneous thread/sequence- attachment occurred. This is especially fun for a WeakPtr, which if checked on the wrong thread becomes bound to the thread. Then if the WeakPtrFactory is invalidated later, it's difficult to determine why it believes it is on the wrong thread. This adds a copy of the StackTrace in SequenceChecker and ThreadChecker that is set whenever they are bound to a thread/sequence. Then on failure the DCHECK() callers will get back a copy of the StackTrace and include it in the log message. WeakPtr calls the SequenceChecker manually instead of using the macros, since it has an additional condition so we also add the StackTrace to the message there. The StackTrace logging slows things down a bit, enough that we'd slow bots down without good reason, so the logging is optional. You may use SequenceChecker::EnableStackLogging() to enable this logging, or the equivalent alias ThreadChecker::EnableStackLogging(). Example output with stack logging enabled: [890744:1:1201/174351.878197:FATAL:weak_ptr.cc(23)] Check failed: sequence_checker_.CalledOnValidSequence(&bound_at) || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread as where they are bound. This was bound at: #0 0x7fd813c8d369 base::debug::CollectStackTrace() #1 0x7fd813b94103 base::debug::StackTrace::StackTrace() #2 0x7fd813c70aef base::ThreadCheckerImpl::ThreadCheckerImpl() #3 0x7fd813c02155 base::SequenceCheckerImpl::CalledOnValidSequence() #4 0x7fd813ba4f55 base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #5 0x7fd813bbfa4f base::internal::WeakReference::IsValid() #6 0x7fd80acd0f36 blink::FrameWidgetInputHandlerImpl::FrameWidgetInputHandlerImpl() [...] Check failed at: #0 0x7fd813c8d369 base::debug::CollectStackTrace() #1 0x7fd813b94103 base::debug::StackTrace::StackTrace() #2 0x7fd813bb3c53 logging::LogMessage::~LogMessage() #3 0x7fd813bb45ae logging::LogMessage::~LogMessage() #4 0x7fd813bbf91c base::internal::WeakReference::Flag::Invalidate() #5 0x7fd813bbfc8c base::internal::WeakReferenceOwner::Invalidate() #6 0x7fd80ca6eda7 blink::WebFrameWidgetImpl::Close() #7 0x7fd80ff22359 content::RenderWidget::Close() #8 0x7fd80ff21eff content::RenderWidget::CloseForFrame() [...] R=thakis@chromium.org Change-Id: Id89c12eaedfba9788b3cd2624447c6a1616f0afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568446 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#847805}

…by default" This reverts commit ba96414. Reason for revert: failing unit_tests on linux-chromeos-chrome with NOTREACHED(). Failing tests: MediaToolbarButtonControllerTest.DoesNotDisableButtonIfDialogIsOpen MediaToolbarButtonControllerTest.DoesNotHideIfMediaStartsPlayingWithinTimeout MediaToolbarButtonControllerTest.HidesAfterTimeoutAndShowsAgainOnPlay Example: RUN ] MediaToolbarButtonControllerTest.HidesAfterTimeoutAndShowsAgainOnPlay 2021-02-03T04:04:47.546579Z 564170770 ERROR unit_tests[2535:2535]: [pref_change_registrar.cc(40)] NOTREACHED() hit. Received signal 11 SEGV_MAPERR 000000000038 #0 0x5611b0dbfe29 base::debug::CollectStackTrace() #1 0x5611b0d2f4d3 base::debug::StackTrace::StackTrace() #2 0x5611b0dbf9d1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9eb128f390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x5611ac59c5fe std::__1::__hash_table<>::find<>() #5 0x5611b1c25762 PrefService::FindPreference() #6 0x5611b11a2169 media_router::GetCastAllowAllIPsPref() #7 0x5611b2fd159b media_router::CastMediaSinkService::CreateImpl() #8 0x5611b2fd138f media_router::CastMediaSinkService::Start() #9 0x5611b2fad704 media_router::DualMediaSinkService::DualMediaSinkService() #10 0x5611b2fad539 media_router::DualMediaSinkService::GetInstance() #11 0x5611b2f93b44 media_router::MediaRouterDesktop::MediaRouterDesktop() #12 0x5611b2f93030 media_router::ChromeMediaRouterFactory::BuildServiceInstanceFor() #13 0x5611b2bdb30f BrowserContextKeyedServiceFactory::BuildServiceInstanceFor() #14 0x5611b1cd2837 KeyedServiceFactory::GetServiceForContext() #15 0x5611b37297b6 CastMediaNotificationProvider::CastMediaNotificationProvider() #16 0x5611b372c274 MediaNotificationService::MediaNotificationService() #17 0x5611abdba814 MediaToolbarButtonControllerTest::SetUp() first failing build: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/11825/overview Original change's description: > Enable GlobalMediaControlsForCast and CastMediaRouteProvider by default > > The features were enabled via a config change in M87 (CastMRP on CrOS > will soon be enabled in M88). This change enables them by default. > > Bug: 1042330, 869214 > Change-Id: I111bd1f6d13bf70cf7557004205e7de1dc3e23ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631191 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: John Williams <jrw@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#849910} TBR=pkasting@chromium.org,mlamouri@chromium.org,takumif@chromium.org,jrw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I215a231257e91dd81348577221892fb6b297677d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042330 Bug: 869214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2671781 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#850027}

… Text" This reverts commit 87004c0941db2881991388cd6c72cf4a3d1f31c2. Reason for revert: As Sheriff, I'm reverting this change on suspicion of causing the MSan ChromeOS buildbot to think that we are referencing uninitialized memory. Failing build https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/22528/overview Flakiness Dashboard https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FSharesheetBubbleViewBrowserTest.InvokeUi_Default%2F0&testType=browser_tests Test failure: [ RUN ] All/SharesheetBubbleViewBrowserTest.InvokeUi_Default/0 2021-02-16T12:29:26.782807Z WARNING browser_tests[26720:26720]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-02-16T12:29:26.796127Z ERROR browser_tests[26720:26720]: [cras_audio_handler.cc(1628)] Failed to retrieve WBS mic deprioritized flag 2021-02-16T12:29:26.796914Z WARNING browser_tests[26720:26813]: [statistics_provider.cc(320)] Finished loading statistics. 2021-02-16T12:29:27.204718Z ERROR browser_tests[26720:26720]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-02-16T12:29:27.576009Z WARNING browser_tests[26720:26720]: [remote_commands_service.cc(183)] Client is not registered. 2021-02-16T12:29:27.621032Z WARNING browser_tests[26720:26720]: [wallpaper_controller_client.cc(376)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-02-16T12:29:28.217682Z ERROR browser_tests[26720:26720]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-02-16T12:29:28.404958Z ERROR browser_tests[26720:26720]: [account_manager_migrator.cc(268)] Could not find a refresh token for the Device Account. 2021-02-16T12:29:28.421207Z INFO browser_tests[26720:26720]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-02-16T12:29:28.421880Z INFO browser_tests[26720:26720]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-02-16T12:29:28.734078Z ERROR browser_tests[26720:26817]: [als_reader.cc(52)] Missing num of als 2021-02-16T12:29:28.742218Z ERROR browser_tests[26720:26817]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-02-16T12:29:28.841649Z WARNING browser_tests[26720:26720]: [drivefs_session.cc(62)] DriveFs mount failed with error: 3 2021-02-16T12:29:28.936983Z INFO browser_tests[26720:26720]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. ==26720==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5598549f2288 in views::NativeWidgetAura::CenterWindow(gfx::Size const&) ./../../ui/views/widget/native_widget_aura.cc:415:57 #1 0x5598549793f1 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:0:0 #2 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #3 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #4 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #5 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #6 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #7 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #8 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #9 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #10 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #11 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #12 0x559851c52f7a in Run ./../../base/callback.h:101:12 #13 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #14 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #15 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #16 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #17 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #18 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #19 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #20 0x559850dc31ed in Run ./../../base/callback.h:101:12 #21 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 #22 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18 #23 0x55983fce3e6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32 #24 0x5598460cf517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13 #25 0x5598475f80ac in Run ./../../base/callback.h:101:12 #26 0x5598475f80ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #27 0x5598460ca995 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:854:25 #28 0x5598460d6b64 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15 #29 0x5598460c37f2 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #30 0x55984a9b393f in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:517:10 #31 0x55984a9b7a37 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1001:10 #32 0x55984a9b68b0 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:876:12 #33 0x55984a9ae481 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #34 0x55984a9aebb0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #35 0x5598526f81ea in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:683:3 #36 0x5598506cda3f in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:348:20 #37 0x5598418d8c23 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x5598418d8c23 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:3 #39 0x5598418db9f9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #40 0x5598418dda84 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #41 0x559841907c54 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #42 0x559841906c4e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #43 0x559841906c4e in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #44 0x559850c79fd4 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #45 0x559850c79fd4 in base::TestSuite::Run() ./../../base/test/test_suite.cc:481:16 #46 0x5598506276e3 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:35:23 #47 0x5598527f8a74 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:376:31 #48 0x559850633db9 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:269:10 #49 0x5598506274ff in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:47:10 #50 0x7f9a676ee83f in __libc_start_main ??:0:0 #51 0x55983729bd49 in _start ??:0:0 Uninitialized value was stored to memory at #0 0x55985497952f in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40 #1 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #2 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #3 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #4 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #5 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #6 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #7 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #8 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #9 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #10 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #11 0x559851c52f7a in Run ./../../base/callback.h:101:12 #12 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #13 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #14 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #15 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #16 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #17 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #18 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #19 0x559850dc31ed in Run ./../../base/callback.h:101:12 #20 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 #21 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18 #22 0x55983fce3e6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32 #23 0x5598460cf517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13 #24 0x5598475f80ac in Run ./../../base/callback.h:101:12 #25 0x5598475f80ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 Uninitialized value was stored to memory at #0 0x5598546b68a3 in Rect ./../../ui/gfx/geometry/rect.h:43:47 #1 0x5598546b68a3 in views::BubbleBorder::GetBounds(gfx::Rect const&, gfx::Size const&) const ./../../ui/views/bubble/bubble_border.cc:90:15 #2 0x5598546d7ad3 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:186:26 #3 0x5598549b8119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23 #4 0x5598549b8119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10 #5 0x559854928c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10 #6 0x559854979468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40 #7 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #8 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #9 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #10 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #11 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #12 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #13 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #14 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #15 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #16 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #17 0x559851c52f7a in Run ./../../base/callback.h:101:12 #18 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #19 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #20 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #21 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #22 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #23 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #24 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #25 0x559850dc31ed in Run ./../../base/callback.h:101:12 #26 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 Uninitialized value was stored to memory at #0 0x5598546d7ae7 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:185:18 #1 0x5598549b8119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23 #2 0x5598549b8119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10 #3 0x559854928c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10 #4 0x559854979468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40 #5 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #6 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #7 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #8 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #9 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #10 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #11 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #12 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #13 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #14 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #15 0x559851c52f7a in Run ./../../base/callback.h:101:12 #16 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #17 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #18 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #19 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #20 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #21 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #22 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #23 0x559850dc31ed in Run ./../../base/callback.h:101:12 #24 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 #25 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18 Uninitialized value was created by an allocation of 'retval' in the stack frame of function '_ZNK5views15BubbleFrameView25GetFrameSizeForClientSizeERKN3gfx4SizeE' #0 0x5598546d7b2a in views::BubbleFrameView::GetFrameSizeForClientSize(gfx::Size const&) const ./../../ui/views/bubble/bubble_frame_view.cc:834:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/browser_tests+0x24ac3288) Exiting [ RUN ] All/SharesheetBubbleViewBrowserTest.InvokeUi_Default/0 2021-02-16T12:36:26.583543Z WARNING browser_tests[30386:30386]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-02-16T12:36:26.592586Z ERROR browser_tests[30386:30386]: [cras_audio_handler.cc(1628)] Failed to retrieve WBS mic deprioritized flag 2021-02-16T12:36:26.593289Z WARNING browser_tests[30386:30401]: [statistics_provider.cc(320)] Finished loading statistics. 2021-02-16T12:36:26.860265Z ERROR browser_tests[30386:30386]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-02-16T12:36:27.035171Z WARNING browser_tests[30386:30386]: [remote_commands_service.cc(183)] Client is not registered. 2021-02-16T12:36:27.064652Z WARNING browser_tests[30386:30386]: [wallpaper_controller_client.cc(376)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-02-16T12:36:27.364592Z ERROR browser_tests[30386:30386]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-02-16T12:36:27.421165Z ERROR browser_tests[30386:30386]: [account_manager_migrator.cc(268)] Could not find a refresh token for the Device Account. 2021-02-16T12:36:27.481536Z INFO browser_tests[30386:30386]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-02-16T12:36:27.484870Z INFO browser_tests[30386:30386]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-02-16T12:36:27.638922Z ERROR browser_tests[30386:30401]: [als_reader.cc(52)] Missing num of als 2021-02-16T12:36:27.638945Z WARNING browser_tests[30386:30386]: [drivefs_session.cc(62)] DriveFs mount failed with error: 3 2021-02-16T12:36:27.644456Z ERROR browser_tests[30386:30401]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-02-16T12:36:27.699898Z INFO browser_tests[30386:30386]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. ==30386==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x560b2e64a288 in views::NativeWidgetAura::CenterWindow(gfx::Size const&) ./../../ui/views/widget/native_widget_aura.cc:415:57 #1 0x560b2e5d13f1 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:0:0 #2 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #3 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #4 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #5 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #6 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #7 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #8 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #9 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #10 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #11 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #12 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12 #13 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #14 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #15 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #16 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #17 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #18 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #19 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #20 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12 #21 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 #22 0x560b2aa183c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18 #23 0x560b1993be6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32 #24 0x560b1fd27517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13 #25 0x560b212500ac in Run ./../../base/callback.h:101:12 #26 0x560b212500ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #27 0x560b1fd22995 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:854:25 #28 0x560b1fd2eb64 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15 #29 0x560b1fd1b7f2 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #30 0x560b2460b93f in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:517:10 #31 0x560b2460fa37 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1001:10 #32 0x560b2460e8b0 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:876:12 #33 0x560b24606481 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #34 0x560b24606bb0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #35 0x560b2c3501ea in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:683:3 #36 0x560b2a325a3f in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:348:20 #37 0x560b1b530c23 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x560b1b530c23 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:3 #39 0x560b1b5339f9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #40 0x560b1b535a84 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #41 0x560b1b55fc54 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #42 0x560b1b55ec4e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #43 0x560b1b55ec4e in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #44 0x560b2a8d1fd4 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #45 0x560b2a8d1fd4 in base::TestSuite::Run() ./../../base/test/test_suite.cc:481:16 #46 0x560b2a27f6e3 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:35:23 #47 0x560b2c450a74 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:376:31 #48 0x560b2a28bdb9 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:269:10 #49 0x560b2a27f4ff in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:47:10 #50 0x7f0d2d9dd83f in __libc_start_main ??:0:0 #51 0x560b10ef3d49 in _start ??:0:0 Uninitialized value was stored to memory at #0 0x560b2e5d152f in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40 #1 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #2 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #3 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #4 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #5 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #6 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #7 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #8 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #9 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #10 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #11 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12 #12 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #13 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #14 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #15 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #16 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #17 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #18 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #19 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12 #20 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 #21 0x560b2aa183c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18 #22 0x560b1993be6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32 #23 0x560b1fd27517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13 #24 0x560b212500ac in Run ./../../base/callback.h:101:12 #25 0x560b212500ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 Uninitialized value was stored to memory at #0 0x560b2e30e8a3 in Rect ./../../ui/gfx/geometry/rect.h:43:47 #1 0x560b2e30e8a3 in views::BubbleBorder::GetBounds(gfx::Rect const&, gfx::Size const&) const ./../../ui/views/bubble/bubble_border.cc:90:15 #2 0x560b2e32fad3 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:186:26 #3 0x560b2e610119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23 #4 0x560b2e610119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10 #5 0x560b2e580c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10 #6 0x560b2e5d1468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40 #7 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #8 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #9 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #10 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #11 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #12 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13 #13 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12 #14 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5 #15 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12 #16 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12 #17 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12 #18 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25 #19 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3 #20 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3 #21 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3 #22 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25 #23 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3 #24 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5 #25 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12 #26 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38 Uninitialized value was stored to memory at #0 0x560b2e32fae7 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:185:18 #1 0x560b2e610119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23 #2 0x560b2e610119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10 #3 0x560b2e580c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10 #4 0x560b2e5d1468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40 #5 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5 #6 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18 #7 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27 #8 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3 #9 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28 #10 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(shareshee…

This reverts commit 8cd3185. Reason for revert: suspect causing browser_tests failure on linux-chromeos-rel Failing tests: AccessibilityPolicyTest.AutoclickEnabled All/GestureNavigationScreenTest.ScreenSkippedWithAutoclickEnabled/1 AutoclickE2ETest.HighlightsRootWebAreaIfNotScrollable AutoclickE2ETest.RemovesAndAddsAutoclick ChromeOSInfoPrivateTest.TestGetAndSet First test failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/45848 Sample log: BrowserTestBase received signal: Segmentation fault. Backtrace: ... #3 0x7fa7483ba4c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5598f0b6ecce ash::CaptureModeController::IsActive() #5 0x5598f0d32b28 ash::CollisionDetectionUtils::AvoidObstacles() #6 0x5598f0d32296 ash::CollisionDetectionUtils::GetRestingPosition() #7 0x5598f0c73a68 ash::AutoclickMenuBubbleController::SetPosition() #8 0x5598f0d8c661 ash::WorkspaceLayoutManager::NotifySystemUiAreaChanged() Original change's description: > capture_mode: Capture bar does not intersect autoclick. > > Adds capture mode on the collision course for bubbles like PIP and > autoclick, and triggers repositioning of the autoclick on enter or exit > capture mode. > > Fixed: 1149758 > Test: manual > Change-Id: I800b2b265374627718cd944d39d76dc4e94be7fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597219 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#859045} Change-Id: I2ee7dbd24ed3006a494b59b8dd93cbef86b0353a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2730374 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#859248}

…m_gtests This CL moves the check that verifies readiness of x11::Connection to InitializeUI that should be sufficient to stop execution of the browser if it's not possible to connect to XDisplay. In own turn, this allows to run such tests as vr_pixeltests, which do not actually require XDisplay. Otherwise, the following callstack results in a crash (when vr_pixeltests run). [FATAL:ozone_platform_x11.cc(277)] Check failed: x11::Connection::Get()->Ready(). Missing X server or $DISPLAY #0 0x557d0bc225f9 base::debug::CollectStackTrace() #1 0x557d0bba3a53 base::debug::StackTrace::StackTrace() #2 0x557d0bbad33f logging::LogMessage::~LogMessage() #3 0x557d0bbadcee logging::LogMessage::~LogMessage() #4 0x557d0bb0d498 ui::(anonymous namespace)::OzonePlatformX11::InitializeCommon() #5 0x557d0bb0d2bc ui::(anonymous namespace)::OzonePlatformX11::InitializeGPU() #6 0x557d0c358dd6 gl::GLImageTestSupport::InitializeGL() Bug: 1177253 Change-Id: I435d03b4688e72b37c10f16d12ac2130cff90f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2700032 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#862870}

This reverts commit b2446a0 Reason for revert: Trying again w/ build fixes. The two issues we saw yesterday with reland attempt #5 were fixed in https://crrev.com/c/2768998 (remoting linux installer) https://crrev.com/c/2768998 (GLES test scripts) But the change wasn't in the tree for very long, so there may well be more. Let's try again to see. Bug: 1112471 Cq-Include-Trybots: luci.chromium.try:linux-angle-rel Cq-Include-Trybots: luci.chrome.try:linux-chrome Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#864372}

This reverts commit d9caee7. Reason for revert: I believe this causes failure on Builder win-chrome. First failure: https://ci.chromium.org/ui/p/chrome/builders/ci/win-chrome/19774/blamelist Original change's description: > Reland #6 of "Force Python 3 to be used in build." > > This reverts commit b2446a0 > > Reason for revert: Trying again w/ build fixes. > > The two issues we saw yesterday with reland attempt #5 > were fixed in > https://crrev.com/c/2768998 (remoting linux installer) > https://crrev.com/c/2768998 (GLES test scripts) > > But the change wasn't in the tree for very long, so there may > well be more. Let's try again to see. > > Bug: 1112471 > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > Cq-Include-Trybots: luci.chrome.try:linux-chrome > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#864372} Bug: 1112471 Change-Id: I1458c5a5ee5dbb8e1e6cfe367998ff378b29ba53 Cq-Include-Trybots: luci.chromium.try:linux-angle-rel Cq-Include-Trybots: luci.chrome.try:linux-chrome No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2774784 Auto-Submit: Owen Min <zmin@chromium.org> Owners-Override: Owen Min <zmin@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#864764}

This CL fixes a segfault when a WaylandScreen is created after a WaylandWindow.. Basically, when WaylandScreen is created, it gets the list of existing outputs, which it uses to create displays. In its own turn, it also checks what WaylandWindows are on those displays and calls WaylandWindow::UpdateBufferScale. This operation also results in SetBounds to be called, which calls to PlatformWindowDelegate::GetMinimumSizeForWindow, which requires ScreenOzone instance to have PlatformScreen (WaylandScreen in this case) to be set. But as long as creation of the screen, updating buffer scale, and setting updated bounds based on new scale value happens in the same sequence of calls, ScreenOzone just doesn't have the PlatformScreen set, and it results in a crash. See the stacktrace below - #3 0x7f9c30bba4c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x556900be4bad aura::ScreenOzone::GetPrimaryDisplay() #5 0x5568ff6aebff views::DesktopWindowTreeHostPlatform::GetRootTransform() #6 0x5568ff6af1ba views::DesktopWindowTreeHostPlatform::GetMinimumSizeForWindow() #7 0x5568faeb9aaf ui::WaylandWindow::SetBounds() #8 0x5568faeb961e ui::WaylandWindow::UpdateBufferScale() #9 0x5568faeb473d ui::WaylandScreen::AddOrUpdateDisplay() #10 0x5568faeb3023 ui::WaylandOutputManager::CreateWaylandScreen() #11 0x5568faec7fa2 ui::(anonymous namespace)::OzonePlatformWayland::CreateScreen() #12 0x556900be480a aura::ScreenOzone::ScreenOzone() #13 0x5568ff6aa10e views::DesktopScreenOzone::DesktopScreenOzone() This only happens in test environments (interactive_ui_tests, when Ozone is initialized, WaylandWindows are created, but the screen instance is created and set a bit later. Thus, make WaylandWindow use existing information about preferred outputs that it has. Bug: 1134495 Change-Id: I3f2f9349adc85684d5cf4f5e2bca8497c326bb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2773276 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#865569}

This is a reland of d9caee7. A number of fixes have landed in between then and now, and I think we're ready for another round. Original change's description: > Reland #6 of "Force Python 3 to be used in build." > > This reverts commit b2446a0 > > Reason for revert: Trying again w/ build fixes. > > The two issues we saw yesterday with reland attempt #5 > were fixed in > https://crrev.com/c/2768998 (remoting linux installer) > https://crrev.com/c/2768998 (GLES test scripts) > > But the change wasn't in the tree for very long, so there may > well be more. Let's try again to see. > > Bug: 1112471 > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > Cq-Include-Trybots: luci.chrome.try:linux-chrome > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#864372} Bug: 1112471 Change-Id: Iccef0aa5d92c28fee1ce67e446b9b15a7cc0745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 Commit-Queue: Dirk Pranke <dpranke@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#868187}

This reverts commit 0a70004. Reason for revert: https://crbug.com/1196930 Original change's description: > Reland #7 of "Force Python 3 to be used in build." > > This is a reland of d9caee7. > > A number of fixes have landed in between then and now, and I > think we're ready for another round. > > Original change's description: > > Reland #6 of "Force Python 3 to be used in build." > > > > This reverts commit b2446a0 > > > > Reason for revert: Trying again w/ build fixes. > > > > The two issues we saw yesterday with reland attempt #5 > > were fixed in > > https://crrev.com/c/2768998 (remoting linux installer) > > https://crrev.com/c/2768998 (GLES test scripts) > > > > But the change wasn't in the tree for very long, so there may > > well be more. Let's try again to see. > > > > Bug: 1112471 > > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > > Cq-Include-Trybots: luci.chrome.try:linux-chrome > > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#864372} > > Bug: 1112471 > Change-Id: Iccef0aa5d92c28fee1ce67e446b9b15a7cc0745a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#868187} Bug: 1112471, 1196930 Change-Id: I405a771ffc29ed40e74764008c9e0be1e4b9ef7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812719 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#870378}

This reverts commit c787d2a. Reason for revert: Causes flaky failures on some Linux bots, e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28Wayland%29 Example failure: browser_tests_wayland failed because of: ExtensionBackForwardCacheContentScriptDisabledBrowserTest.CSSDisallowed pattern of failures on this bot: https://screenshot.googleplex.com/87iSx5FiDVGZRmF Failure error is ../../chrome/browser/extensions/back_forward_cache_browsertest.cc:110: Failure Value of: delete_observer_rfh_a.deleted() Actual: false Expected: true Stack trace: #0 0x563563bb7efc extensions::ExtensionBackForwardCacheContentScriptDisabledBrowserTest_CSSDisallowed_Test::RunTestOnMainThread() #1 0x563567b440ce content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5635676da77d ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #3 0x5635676d9d54 ChromeBrowserMainParts::PreMainMessageLoopRun() #4 0x56356561f0df content::BrowserMainLoop::PreMainMessageLoopRun() #5 0x563565a4e6a3 content::StartupTaskRunner::RunAllTasksNow() #6 0x56356561ed5d content::BrowserMainLoop::CreateStartupTasks() #7 0x563565621228 content::BrowserMainRunnerImpl::Initialize() #8 0x56356561d610 content::BrowserMain() #9 0x563566297393 content::ContentMainRunnerImpl::RunBrowser() #10 0x563566296f1d content::ContentMainRunnerImpl::Run() #11 0x5635662944ad content::RunContentProcess() #12 0x563566294e4d content::ContentMain() #13 0x563567b43778 content::BrowserTestBase::SetUp() #14 0x563567587576 InProcessBrowserTest::SetUp() The same error appears on other bots when this fails too, e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28X11%29/29058 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8850497656556318928/+/steps/browser_tests_x11/0/logs/Deterministic_failure:_ExtensionBackForwardCacheContentScriptDisabledBrowserTest.CSSDisallowed__status_FAILURE_/0 Original change's description: > If an extension does a content injection disable bf cache. > > This code tracks whether a content injection (insertCSS, contentScript, > executeScript) has occurred for a WebFrame. If so then turn off > BFCache for the frame. > > BUG=1192785 > > Change-Id: I682a9efb247aae358023e3a591368c84d47001ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787195 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#870582} Bug: 1192785 Change-Id: Ib122b1d64155d85009038d961306ac620053564b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2816001 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#870681}

This reverts commit 38b6a9a. Reason for revert: The issues affecting the official win build and the swarming dev instance have been fixed, so hopefully it's safe to try Yet Again. Original change's description: > Revert "Reland #7 of "Force Python 3 to be used in build."" > > This reverts commit 0a70004. > > Reason for revert: > https://crbug.com/1196930 > > Original change's description: > > Reland #7 of "Force Python 3 to be used in build." > > > > This is a reland of d9caee7. > > > > A number of fixes have landed in between then and now, and I > > think we're ready for another round. > > > > Original change's description: > > > Reland #6 of "Force Python 3 to be used in build." > > > > > > This reverts commit b2446a0 > > > > > > Reason for revert: Trying again w/ build fixes. > > > > > > The two issues we saw yesterday with reland attempt #5 > > > were fixed in > > > https://crrev.com/c/2768998 (remoting linux installer) > > > https://crrev.com/c/2768998 (GLES test scripts) > > > > > > But the change wasn't in the tree for very long, so there may > > > well be more. Let's try again to see. > > > > > > Bug: 1112471 > > > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > > > Cq-Include-Trybots: luci.chrome.try:linux-chrome > > > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#864372} > > > > Bug: 1112471 > > Change-Id: Iccef0aa5d92c28fee1ce67e446b9b15a7cc0745a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#868187} > > Bug: 1112471, 1196930 > Change-Id: I405a771ffc29ed40e74764008c9e0be1e4b9ef7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812719 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#870378} Bug: 1112471 Bug: 1196930 Change-Id: Ia8caaf2f7f962e7e413fdba47f9acb46150f10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824170 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#872124}

This reverts commit 7ae3611. Reason for revert: cast_shell+browsertests failing on Cast [Audio] Linux First failure https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/103652/overview Example crash stack BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55bcce76b6a9 base::debug::CollectStackTrace() #1 0x55bcce6dfda3 base::debug::StackTrace::StackTrace() #2 0x55bcd0fb5cac content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fd872d664c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x55bcccba88b0 _ZNSt3__17find_ifINS_11__wrap_iterIPKN4base8internal24UncheckedObserverAdapterEEEZNS3_23ProjectedUnaryPredicateIZNKS2_12ObserverListIN3net16MDnsListenerImplELb0ELb1ES4_E11HasObserverEPKSB_EUlRKT_E_NS2_8identityEEEDaRSF_RT0_EUlOSF_E_EESF_SF_SF_SL_ #5 0x55bcccba889e _ZN4base6ranges7find_ifINSt3__111__wrap_iterIPKNS_8internal24UncheckedObserverAdapterEEEZNKS_12ObserverListIN3net16MDnsListenerImplELb0ELb1ES5_E11HasObserverEPKSB_EUlRKT_E_NS_8identityENS2_26random_access_iterator_tagEEEDaSF_SF_T0_T1_ #6 0x55bcccba6dca base::ObserverList<>::RemoveObserver() #7 0x55bccd28a44e chromecast::DisplayConfiguratorObserver::~DisplayConfiguratorObserver() #8 0x55bccd26fbcd chromecast::shell::CastBrowserMainParts::~CastBrowserMainParts() #9 0x55bccd26fc7c chromecast::shell::CastBrowserMainParts::~CastBrowserMainParts() #10 0x55bccd3a6836 content::BrowserMainLoop::~BrowserMainLoop() #11 0x55bccd3a6920 content::BrowserMainLoop::~BrowserMainLoop() #12 0x55bccd3a9c06 content::BrowserMainRunnerImpl::Shutdown() #13 0x55bccd3a65aa content::BrowserMain() #14 0x55bcce68bc80 content::RunBrowserProcessMain() #15 0x55bcce68c9a6 content::ContentMainRunnerImpl::RunBrowser() #16 0x55bcce68c62c content::ContentMainRunnerImpl::Run() #17 0x55bcce68ad93 content::RunContentProcess() #18 0x55bcce68b49a content::ContentMain() #19 0x55bcd0fb50e1 content::BrowserTestBase::SetUp() #20 0x55bccc9fdf90 chromecast::WebviewTest::SetUp() #21 0x55bcce69a89c testing::Test::Run() #22 0x55bcce69adb8 testing::TestInfo::Run() #23 0x55bcce69b27d testing::TestSuite::Run() #24 0x55bcce6a2233 testing::internal::UnitTestImpl::RunAllTests() #25 0x55bcce6a1f87 testing::UnitTest::Run() #26 0x55bcd0fa57ef base::TestSuite::Run() #27 0x55bccc9de2a4 chromecast::shell::CastTestLauncherDelegate::RunTestSuite() #28 0x55bcd0fb930e content::LaunchTests() #29 0x55bccc9de23c main #30 0x7fd872d51840 __libc_start_main #31 0x55bccc9de12a _start Original change's description: > Add display change observer. > > Centralize the logic to force a repaint post display changes in an > observer. This way the complexity of refreshing the display is > handled in the observer rather than in every piece of code that > needs to update the display state. > > Bug: b/180040068 > Test: Ran cast_shell on the desktop to verify there are no crashes > Change-Id: I022850322c8b9177463bdc0526121016ebf0f330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727577 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Shiv Sakhuja <shivsak@google.com> > Cr-Commit-Position: refs/heads/master@{#873512} Bug: b/180040068 Change-Id: Id01a6e537f2285a9c35ce90acc9eba81b0ea6c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2835019 Owners-Override: Olga Sharonova <olka@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#873746}

This reverts commit 59bae41. Reason for revert: Broken on Linux Chromium OS ASan LSan Tests (1) https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39927/ <div><pre>[ RUN ] PrerenderBrowserTest.PrerenderBlankIframe 2021-04-26T19:40:32.221868Z INFO content_browsertests[5132:5132]: [content_main_runner_impl.cc(1077)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:36659/devtools/browser/21b92715-e642-49fe-98ef-4b69eea3f8b2 2021-04-26T19:40:32.847975Z ERROR content_browsertests[5132:5132]: [browser_test_utils.cc(837)] No committed entry. 2021-04-26T19:40:34.078783Z WARNING content_browsertests[5132:5132]: [render_frame_host_impl.cc(977)] InterfaceRequest was dropped, the document is no longer active: blink.mojom.AppCacheBackend 2021-04-26T19:40:34.281683Z FATAL content_browsertests[5285:1]: [document.cc(8103)] Check failed: is_prerendering_. #0 0x55b148a133cb in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13 #1 0x55b1586bd249 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x55b1583f3f03 in StackTrace ./../../base/debug/stack_trace.cc:198:12 #3 0x55b1583f3f03 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:195:28 #4 0x55b158448eb2 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:589:29 #5 0x55b15844adde in logging::LogMessage::~LogMessage() ./../../base/logging.cc:583:27 #6 0x55b15e0d8fa6 in blink::Document::ActivateForPrerendering() ./../../third_party/blink/renderer/core/dom/document.cc:8103:3 #7 0x55b15392c60c in Run ./../../base/callback.h:101:12 #8 0x55b15392c60c in RunInternal ./../../third_party/blink/renderer/platform/wtf/functional.h:221:33 #9 0x55b15392c60c in WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void ()>, void ()>::Run() ./../../third_party/blink/renderer/platform/wtf/functional.h:206:12 #10 0x55b1585795fa in Run ./../../base/callback.h:101:12 #11 0x55b1585795fa in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:173:33 #12 0x55b1585e197a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:25 #13 0x55b1585e071f in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:264:36 #14 0x55b158468934 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:39:55 #15 0x55b1585e36d9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:460:12 #16 0x55b158503839 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #17 0x55b1671389dc in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:261:16 #18 0x55b15003c45a in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:572:14 #19 0x55b15003f244 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:958:10 #20 0x55b150039a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #21 0x55b150039f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #22 0x55b157438e9c in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:372:12 #23 0x55b1572a1d21 in main ./../../content/test/content_test_launcher.cc:91:10 #24 0x7f772d1ad840 in __libc_start_main ??:0:0 #25 0x55b1489dcaaa in _start ??:0:0 Task trace: #0 0x55b15ea7ff11 in blink::LocalFrame::ActivateForPrerendering() ./../../third_party/blink/renderer/core/frame/local_frame.cc:3766:18 #1 0x55b15780d116 in IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept(mojo::Message*) ./../../ipc/ipc_mojo_bootstrap.cc:904:13 IPC message handler context: 0xA60C9B35 Received signal 6 #0 0x55b148a133cb in backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4205:13 #1 0x55b1586bd249 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x55b1583f3f03 in StackTrace ./../../base/debug/stack_trace.cc:198:12 #3 0x55b1583f3f03 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:195:28 #4 0x55b1586bbd47 in base::debug::(anonymous namespace)::StackDumpSignalHandler(int, siginfo_t*, void*) ./../../base/debug/stack_trace_posix.cc:345:3 #5 0x7f7730097390 in __funlockfile ??:? #6 0x7f7730097390 in ?? ??:0 #7 0x7f772d1c2438 in raise ??:0:0 #8 0x7f772d1c403a in abort ??:0:0 #9 0x55b1586b9f6a in base::debug::BreakDebugger() ./../../base/debug/debugger_posix.cc:326:3 #10 0x55b158449863 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:891:7 #11 0x55b15844adde in logging::LogMessage::~LogMessage() ./../../base/logging.cc:583:27 #12 0x55b15e0d8fa6 in blink::Document::ActivateForPrerendering() ./../../third_party/blink/renderer/core/dom/document.cc:8103:3 #13 0x55b15392c60c in Run ./../../base/callback.h:101:12 #14 0x55b15392c60c in RunInternal ./../../third_party/blink/renderer/platform/wtf/functional.h:221:33 #15 0x55b15392c60c in WTF::ThreadCheckingCallbackWrapper<base::OnceCallback<void ()>, void ()>::Run() ./../../third_party/blink/renderer/platform/wtf/functional.h:206:12 #16 0x55b1585795fa in Run ./../../base/callback.h:101:12 #17 0x55b1585795fa in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:173:33 #18 0x55b1585e197a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:25 #19 0x55b1585e071f in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:264:36 #20 0x55b158468934 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:39:55 #21 0x55b1585e36d9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:460:12 #22 0x55b158503839 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #23 0x55b1671389dc in content::RendererMain(content::MainFunctionParams const&) ./../../content/renderer/renderer_main.cc:261:16 #24 0x55b15003c45a in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:572:14 #25 0x55b15003f244 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:958:10 #26 0x55b150039a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #27 0x55b150039f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #28 0x55b157438e9c in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:372:12 #29 0x55b1572a1d21 in main ./../../content/test/content_test_launcher.cc:91:10 #30 0x7f772d1ad840 in __libc_start_main ??:0:0 #31 0x55b1489dcaaa in _start ??:0:0 r8: 0000000000003000 r9: 00000feee51a2840 r10: 0000000000000008 r11: 0000000000000202 r12: 00000fef65260c00 r13: 00000feee5268e48 r14: 00007f7729347230 r15: 00007f77293472b0 di: 0000000000000001 si: 0000000000000001 bp: 00007ffcf0a97110 bx: 00007ffcf0a97120 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f772d1c2438 sp: 00007ffcf0a96fd8 ip: 00007f772d1c2438 efl: 0000000000000202 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(EXIT_FAILURE). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x556300884c70 in content::NoRendererCrashesAssertion::Observe(int, content::NotificationSource const&, content::NotificationDetails const&) ./../../content/public/test/no_renderer_crashes_assertion.cc:101:5 #1 0x5562fe8a511c in content::NotificationServiceImpl::Notify(int, content::NotificationSource const&, content::NotificationDetails const&) ./../../content/browser/notification_service_impl.cc:123:16 #2 0x5562fed854dc in content::RenderProcessHostImpl::ProcessDied(bool, content::ChildProcessTerminationInfo*) ./../../content/browser/renderer_host/render_process_host_impl.cc:4468:35 #3 0x5562fed84d46 in content::RenderProcessHostImpl::FastShutdownIfPossible(unsigned long, bool) ./../../content/browser/renderer_host/render_process_host_impl.cc:3480:3 #4 0x5563007096fd in content::ContentBrowserTest::PostRunTestOnMainThread() ./../../content/public/test/content_browser_test.cc:159:26 #5 0x55630081ddfd in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:833:3 #6 0x5562f23f595a in base::OnceCallback<void ()>::Run() && ./../../base/callback.h:101:12 #7 0x556300a86450 in content::ShellBrowserMainParts::PreMainMessageLoopRun() ./../../content/shell/browser/shell_browser_main_parts.cc:200:37 #8 0x5562fe06aed1 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:961:28 #9 0x5562f78e60d9 in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:101:12 #10 0x5562ff118ca5 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #11 0x5562fe06a59d in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:869:25 #12 0x5562fe0715f3 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:131:15 #13 0x5562fe066342 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #14 0x5562f94bb63d in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:598:10 #15 0x5562f94bded9 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1081:10 #16 0x5562f94bd258 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:956:12 #17 0x5562f94b7a30 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36 #18 0x5562f94b7f11 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10 #19 0x55630081c4bd in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:696:3 2021-04-26T19:40:34.692356Z WARNING content_browsertests[5132:5174]: [discardable_shared_memory_manager.cc(432)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [ FAILED ] PrerenderBrowserTest.PrerenderBlankIframe, where TypeParam = and GetParam() = (2830 ms) Original change's description: > Prerender: Enable PrerenderBrowserTest.PrerenderBlankIframe > > To sheriffs: Feel free to revert this CL if the test is flaky. > > The CL author tried to reproduce this on local environments but > failed. For further investigation, this CL enables the test again to see > how it works on the try bots. > > Bug: 1185965 > Change-Id: Ie7f65ef094a815e72b93091c8b3d0ab9b361e593 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2850329 > Reviewed-by: Lingqi Chi <lingqi@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#876111} Bug: 1185965 Change-Id: I245d5e5f2715c75ead3a50389cbd0e9a4ad49aed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2853351 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Owners-Override: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#876535}

This reverts commit cb50483. Reason for revert: fails on UBSAN bot https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/3981/overview Log is: [ RUN ] ReportClientTestSuite/ReportClientTest.CreatesReportQueue/1 ../../base/bind_internal.h:509:12: runtime error: member call on address 0x1eb2009c7e00 which does not point to an object of type 'StorageInitContext' 0x1eb2009c7e00: note: object has invalid vptr 00 00 00 00 00 00 1e b2 00 9c 7d 40 ff ff e1 4d ff 63 82 bf 20 0f 9b 01 b2 1e 00 00 80 e2 32 00 ^~~~~~~~~~~~~~~~~~~~~~~ invalid vptr #0 0x556cc82b0ebc in Invoke<void (StorageInitContext::*)(reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> >), StorageInitContext *, reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> > > base/bind_internal.h:509:12 #1 0x556cc82b0ebc in MakeItSo<void (StorageInitContext::*)(reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> >), StorageInitContext *, reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> > > base/bind_internal.h:648:12 #2 0x556cc82b0ebc in RunImpl<void (StorageInitContext::*)(reporting::StatusOr<std::unique_ptr<reporting::UploaderInterface> >), std::tuple<base::internal::UnretainedWrapper<StorageInitContext> >, 0> base/bind_internal.h:721:12 #3 0x556cc82b0ebc in base::internal::Invoker<base::internal::BindState<void (reporting::Storage::Create(reporting::StorageOptions const&, base::RepeatingCallback<void (reporting::Priority, bool, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>)>, scoped_refptr<reporting::EncryptionModuleInterface>, base::OnceCallback<void (reporting::StatusOr<scoped_refptr<reporting::Storage> >)>)::StorageInitContext::*)(reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), base::internal::UnretainedWrapper<reporting::Storage::Create(reporting::StorageOptions const&, base::RepeatingCallback<void (reporting::Priority, bool, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>)>, scoped_refptr<reporting::EncryptionModuleInterface>, base::OnceCallback<void (reporting::StatusOr<scoped_refptr<reporting::Storage> >)>)::StorageInitContext> >, void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>::RunOnce(base::internal::BindStateBase*, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >&&) base/bind_internal.h:690:12 #4 0x556cc82b087a in Run base/callback.h:101:12 #5 0x556cc82b087a in reporting::Storage::Create(reporting::StorageOptions const&, base::RepeatingCallback<void (reporting::Priority, bool, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>)>, scoped_refptr<reporting::EncryptionModuleInterface>, base::OnceCallback<void (reporting::StatusOr<scoped_refptr<reporting::Storage> >)>)::StorageInitContext::WrapInstantiatedKeyUploader(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >) components/reporting/storage/storage.cc:543:12 #6 0x556cc82b0f8b in void base::internal::FunctorTraits<void (*)(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), void>::Invoke<void (*)(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > > >(void (*&&)(reporting::Priority, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >), reporting::Priority&&, base::OnceCallback<void (reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >)>&&, reporting::StatusOr<std::__1::unique_ptr<reporting::UploaderInterface, std::__1::default_delete<reporting::UploaderInterface> > >&&) base/bind_internal.h:404:12 #7 0x556cc3c9dbaf in Run base/callback.h:101:12 #8 0x556cc3c9dbaf in reporting::ReportingClient::FlushAsyncStartUploaderQueue() chrome/browser/policy/messaging_layer/public/report_client.cc:407:44 Original change's description: > Fixed ReportClient > > Made encryption key delivery work. > Extended unit test to handle encrypted case. > Also modified the test to accept unique directory instead of "reporting" > > Bug: b:186460976 > Change-Id: Ibe0c4caad64b4e77c0d984138ce0a9ae027253a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2866305 > Commit-Queue: Leonid Baraz <lbaraz@chromium.org> > Reviewed-by: Zach Trudo <zatrudo@google.com> > Cr-Commit-Position: refs/heads/master@{#878713} Bug: b:186460976 Change-Id: I059d13e662679816d63b219269b6f25c7acfb23f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2871825 Auto-Submit: David Roger <droger@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: David Roger <droger@chromium.org> Owners-Override: David Roger <droger@google.com> Cr-Commit-Position: refs/heads/master@{#878809}

CL Chain -------- This is the 6th CL in a chain. The expected length of the *core* of the chain is 6-7 CLs. Extensions likely to follow. The first CL has a full explanation of the feature and an outline of the chain: https://chromium-review.googlesource.com/c/chromium/src/+/2887150/ Contents of this CL ------------------- * Reading the config is OT-gated. That means *reading* is limited to 0.5% of page loads. More details in go/capture-handle-ot. * For the LGTMed intent-to-experiment, see https://groups.google.com/a/chromium.org/g/blink-dev/c/RKONugfoGwM. Bug: 1200910 Change-Id: I62e15ebde8a4e8a1e3ed67729d9c09a55680e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896975 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#884524}

This CL addresses an issue where the map of View objects to AXNodeIDs in the AXAuraObjectCache gets populated with stale elements. When a View is destructed, we remove it from this cache, but if the View was focused, we incorrectly add a new entry back (see stack traces below). This causes issues if later on a View is created at the same address at this deleted view (manifesting as a flaky test failure on the linked bug). We fix this by having the AXViewObjWrapper remove the cache entry when the View is destroyed (OnViewIsDeleting). Stack trace for removing AXAuraObjCache entry #0 views::AXAuraObjCache::Remove() #1 views::AXAuraObjCache::RemoveViewSubtree() #2 views::Widget::NotifyWillRemoveView() #3 views::View::DoRemoveChildView() #4 views::View::~View() Stack trace for re-adding AXAuraObjCache entry #0 views::AXAuraObjCache::GetOrCreate() #1 AutomationManagerAura::OnViewEvent() #2 views::AXEventManager::NotifyViewEvent() #3 views::View::NotifyAccessibilityEvent() #4 views::View::SetVisible() #5 views::FocusRing::RefreshLayer() #6 views::View::Blur() #7 views::FocusManager::SetFocusedViewWithReason() #8 views::Widget::ViewHierarchyChanged() #9 views::internal::RootView::ViewHierarchyChanged() #10 views::View::ViewHierarchyChangedImpl() #11 views::View::PropagateRemoveNotifications() #12 views::View::DoRemoveChildView() #13 views::View::~View() AX-Relnotes: n/a. Bug: b/159074662 Change-Id: Iaf787af321da7de5448e88c036a556a3fc4e1032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2912232 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#886102}

…03 commits) https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator.git/+log/732a76d9d3c7..f67d7fa397e8 $ git log 732a76d9d..f67d7fa39 --date=short --no-merges --format='%ad %ae %s' 2021-06-10 pkasting Update Chromium-side files for upstream roll 2021-06-09 adam.sawicki Fixing Linux build on TravisCI (1) 2021-06-09 adam.sawicki Fix .gitignore to include binaries at new locations 2021-06-09 adam.sawicki Delete shader files 2021-06-09 adam.sawicki Delete binaries from old path 2021-06-09 adam.sawicki Deleted Premake 2021-06-09 adam.sawicki Regenerated documentation 2021-06-09 adam.sawicki Fixed link to include/vk_mem_alloc.h in README.md and Doxyfile 2021-06-09 adam.sawicki Moving Doxyfile to main directory 2021-06-09 adam.sawicki Added VmaVector::shrink_to_fit instead of freeMemory parameter in resize, clear, to fix compilation with VMA_USE_STL_CONTAINERS 2021-06-08 pkasting Fix clang -Wdeprecated-copy. 2021-06-02 johannesschneider Update README 2021-06-02 johannesschneider Add VMA_STATIC_VULKAN_FUNCTIONS and set VMA_DYNAMIC_VULKAN_FUNCTIONS to ON by default 2021-06-02 johannesschneider Remove macros which can be configured through CMake from VmaUsage.h 2021-06-02 johannesschneider Enable compiling with multiple processes for VmaReplay 2021-06-02 johannesschneider Add documentation of CMake options to README 2021-06-02 johannesschneider Correct README 2021-06-02 johannesschneider Link VulkanMemoryAllocator to Vulkan only if static linking is enabled 2021-06-02 johannesschneider Expose important VMA settings macros as CMake options 2021-05-31 johannesschneider Improve consistency in naming of targets and options 2021-05-31 johannesschneider Replace add_definitions with add_compile_definitions 2021-05-31 johannesschneider Move add_subdirectory for shaders and VmaReplay to the end of the file 2021-05-31 johannesschneider Only set VMA_EXAMPLE_SOURCE_FILES when building sample app 2021-05-31 johannesschneider Make target_include_directories a one line instruction 2021-05-31 johannesschneider Remove CMAKE_DISABLE_IN_SOURCE_BUILD 2021-05-31 johannesschneider Rename VmaShaders to VmaBuildExampleShaders 2021-05-31 johannesschneider Remove source_group instructions 2021-05-31 johannesschneider Show default values for CMake options in README's table 2021-05-31 johannesschneider Replace Ninja with Make as default build instruction on Linux 2021-05-28 johannesschneider Rename replay app target and shaders target 2021-05-28 johannesschneider Fix VmaReplay build 2021-05-28 adam.sawicki Fixed link in documentation 2021-05-28 johannesschneider Minor typo fixes in code comments 2021-05-28 johannesschneider Add CMake build instructions 2021-05-28 johannesschneider Fix VMA_BUILD_EXAMPLE_APP_SHADERS being ignored on Linux 2021-05-28 johannesschneider Fix missing Vulkan dependency of VmaExample 2021-05-28 johannesschneider Do not set CMAKE_RUNTIME_OUTPUT_DIRECTORY 2021-05-28 johannesschneider Make building shaders, VMA example application and VMA replay app optional 2021-05-28 johannesschneider Remove reference to MoltenVK issue 175 which is fixed now 2021-05-25 johannesschneider Add CMake support 2021-05-17 devnexen clang build warning fixes proposal 2021-05-06 petr_kraus Docs typo 2021-04-19 adam.sawicki Moved main file vk_mem_alloc.h to subdirectory include/ 2021-04-06 cwallez BUILD.gn: Make the vulkan-headers directory overridable. 2021-03-11 adam.sawicki Rebuilt binaries, regenerated documentation 2021-03-11 adam.sawicki Added parsing of command line parameters and GPU selection 2021-03-11 adam.sawicki Improved macros TEST, ERR_GUARD_VULKAN 2021-03-03 adam.sawicki Optimization: custom pools are on an intrusive double linked list not sorted vector 2021-03-03 adam.sawicki Fix for compilation on Linux 2021-03-03 adam.sawicki Optimization: dedicated allocations are on an intrusive double linked list not sorted vector (...) 2021-02-26 adam.sawicki Removed deprecated function vmaResizeAllocation 2021-02-26 adam.sawicki Sample app: Added printing information about available memory heaps nad types 2021-02-23 adam.sawicki Fixed budget management in VmaBlockVector::Allocate for cases when some of multi-page allocations fail 2021-02-23 adam.sawicki Fix in tests for AMD APU with DEVICE_LOCAL heap of only 256 MB 2021-02-22 adam.sawicki Fix for build on Linux #6 2021-02-22 adam.sawicki Fix for build on Linux #5 2021-02-22 adam.sawicki Fix for build on Linux #4 2021-02-22 adam.sawicki Fix for build on Linux #3 2021-02-22 adam.sawicki Fix for build on Linux #2 2021-02-22 adam.sawicki Fix for build on Linux 2021-02-19 adam.sawicki Internal improvement: Added counting total number of VkDeviceMemory blocks. 2021-02-19 adam.sawicki Trying to fix Travis-CI build 2021-02-18 adam.sawicki A fix in TestPool_Benchmark for GPUs with only 256 MB of DEVICE_LOCAL memory 2021-02-16 adam.sawicki Migrated Linux CI build from travis-ci.org to travis-ci.com - updated status icon in README.md 2021-02-16 adam.sawicki Updated copyright header to year 2021. 2021-02-16 adam.sawicki Minor update in README.md 2021-02-16 adam.sawicki Rebuilt binaries using Visual Studio 2019 2021-02-16 adam.sawicki Updated README.md - added RPCS3 to the list of known usages. 2021-02-15 karokidii mem_alloc: Optimize allocation conflict checking 2021-01-11 adam.sawicki Added support for VK_EXT_memory_priority 2020-12-02 ashkanaliabadi Refer to std string and stream with their fully qualified names. 2020-11-03 adam.sawicki Further improvements in documentation. 2020-11-03 adam.sawicki Improvements in documentation. 2020-11-03 adam.sawicki Fixes and clarifications in documentation 2020-10-28 rbarnes Drop trailing whitespace. 2020-10-28 rbarnes Make binary search overflow safe. 2020-10-15 adam.sawicki Minor formatting fix in documentation 2020-09-30 adam.sawicki Added Detroit: Become Human to the list of known software using this library 2020-09-30 adam.sawicki Fix std::min in VmaBlockVector::ProcessDefragmentations 2020-08-24 frank.richter Let VMA_SYSTEM_ALIGNED_FREE fall back to VMA_SYSTEM_FREE, if defined 2020-08-24 frank.richter Add vma_aligned_free() for symmetry 2020-08-24 frank.richter Make vma_aligned_alloc() functions static 2020-08-23 frank.richter Move preprocessor directives that may influence user code into implementation block 2020-08-21 ashkanaliabadi Fix misspellings. 2020-08-18 adam.sawicki Add test and documentation for resource aliasing (overlap). 2020-08-18 adam.sawicki Fix in documentation chapter "Finding out if memory is mappable" 2020-08-18 adam.sawicki Add "Atypical Games - proprietary game engine" to the list of software using this library 2020-08-10 stricmp Fix VMA_DYNAMIC_VULKAN_FUNCTIONS compilation errors when VK_NO_PROTOTYPES is defined 2020-07-27 d.korkmazturk Fix a typo in the explanation of VMA_ALLOCATION_CREATE_MAPPED_BIT 2020-07-16 adam.sawicki Fix compilation errors 2020-07-15 adam.sawicki Replace usage of old VK_LAYER_LUNARG_standard_validation and extension VK_EXT_debug_report with new VK_LAYER_KHRONOS_validation and extension VK_EXT_debug_utils also in VmaReplay 2020-07-15 adam.sawicki Replace usage of old layer VK_LAYER_LUNARG_standard_validation and extension VK_EXT_debug_report with new layer VK_LAYER_KHRONOS_validation and extension VK_EXT_debug_utils 2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK. 2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them. 2020-06-25 thakis Fix argument order for aligned_alloc on mac. 2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK. 2020-07-06 adam.sawicki Improvement in VmaAlignUp, VmaAlignDown 2020-07-03 greenfoxlight.42 Correct if in mapping example 2020-06-24 adam.sawicki Clarify documentation of VmaAllocationInfo::size 2020-06-24 adam.sawicki Add assert to check success of a CPU memory allocation Created with: roll-dep src/third_party/vulkan_memory_allocator Bug: 1213098 Change-Id: I5b8041c7286a84b1d298fd7c583bd6ec273f73e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952854 Reviewed-by: Evgenii Stepanov <eugenis@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#891671}

This will make compile step faster. Previously symbol_level=0 means no symbol. But llvm changed the behavior. Now it contains function names, which in general is fine for developers. This is the result for linux-lacros-rel: symbol_level=0: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/247920? The browser_tests shard 0 contains: ../../chrome/browser/profiles/profile_manager_browsertest.cc:616: Failure Expected equality of these values: 2U Which is: 2 chrome::GetTotalBrowserCount() Which is: 1 Stack trace: #0 0x56441415eea1 ProfileManagerBrowserTest_PRE_AddMultipleProfiles_Test::RunTestOnMainThread() #1 0x56441a1d278c content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x564413970763 chrome_service_worker_browser_test::ChromeServiceWorkerLinkFetchTest::ManifestCallbackAndRun() #3 0x5644199f3cce ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #4 0x5644199f3024 ChromeBrowserMainParts::PreMainMessageLoopRun() #5 0x564416e69bef content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x56441740a676 content::StartupTaskRunner::RunAllTasksNow() #7 0x564416e69855 content::BrowserMainLoop::CreateStartupTasks() #8 0x564416e6c10b content::BrowserMainRunnerImpl::Initialize() #9 0x564416e67dd7 content::BrowserMain() #10 0x564417d95478 content::ContentMainRunnerImpl::RunBrowser() #11 0x564417d94ec0 content::ContentMainRunnerImpl::Run() #12 0x564417d92d1c content::RunContentProcess() #13 0x564417d92ded content::ContentMain() #14 0x56441a1d1a78 content::BrowserTestBase::SetUp() #15 0x5644197edc5e InProcessBrowserTest::SetUp() symbol_level=1: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/248772 The browser_tests shard 0 contains: ../../chrome/browser/profiles/profile_manager_browsertest.cc:616: Failure Expected equality of these values: 2U Which is: 2 chrome::GetTotalBrowserCount() Which is: 1 Stack trace: #0 0x5565d9f0f621 ProfileManagerBrowserTest_PRE_AddMultipleProfiles_Test::RunTestOnMainThread() #1 0x5565dff88ebc content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5565d971fe93 chrome_service_worker_browser_test::ChromeServiceWorkerLinkFetchTest::ManifestCallbackAndRun() #3 0x5565df7aa9ce ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #4 0x5565df7a9d24 ChromeBrowserMainParts::PreMainMessageLoopRun() #5 0x5565dcc1fbdf content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x5565dd1c09c6 content::StartupTaskRunner::RunAllTasksNow() #7 0x5565dcc1f845 content::BrowserMainLoop::CreateStartupTasks() #8 0x5565dcc220fb content::BrowserMainRunnerImpl::Initialize() #9 0x5565dcc1ddc7 content::BrowserMain() #10 0x5565ddb4ce78 content::ContentMainRunnerImpl::RunBrowser() #11 0x5565ddb4c8c0 content::ContentMainRunnerImpl::Run() #12 0x5565ddb4a71c content::RunContentProcess() #13 0x5565ddb4a7ed content::ContentMain() #14 0x5565dff881a8 content::BrowserTestBase::SetUp() #15 0x5565df5a494e InProcessBrowserTest::SetUp() It's the same debug information. Bug: 1221324 Change-Id: I96a0768508cf9bd073a5522e792a4120606bddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965870 Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#893997}

…API support." This reverts commit 97e3106. Reason for revert: Crashing on DUT. Here's the stack trace: #0 0x5b1fdc2d8989 base::debug::CollectStackTrace() #1 0x5b1fdc1e9d53 base::debug::StackTrace::StackTrace() #2 0x5b1fdc2d84e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7a7b96fd29f0 (/lib64/libpthread-2.32.so+0x129ef) #4 0x5b1fdef55c2b _sys_cr_finisheddevice::UsbDeviceLinux::Open() #5 0x5b1fdef50b0f device::UsbServiceLinux::OnDeviceAdded() #6 0x5b1fdef52570 base::internal::FunctorTraits<>::Invoke<>() #7 0x5b1fdc263e50 base::TaskAnnotator::RunTask() #8 0x5b1fdc289291 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #9 0x5b1fdc28ace2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #10 0x5b1fdc36060b base::MessagePumpLibevent::Run() #11 0x5b1fdc28b226 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #12 0x5b1fdc2427b0 base::RunLoop::Run() #13 0x5b1fd94e4ce6 content::BrowserMainLoop::RunMainMessageLoop() #14 0x5b1fd94e6b92 content::BrowserMainRunnerImpl::Run() #15 0x5b1fd94e1df8 content::BrowserMain() #16 0x5b1fdc1b6810 content::ContentMainRunnerImpl::RunBrowser() #17 0x5b1fdc1b6173 content::ContentMainRunnerImpl::Run() #18 0x5b1fdc1b3d94 content::RunContentProcess() #19 0x5b1fdc1b3e6c content::ContentMain() #20 0x5b1fd7dafa1f ChromeMain #21 0x7a7b96861e05 __libc_start_main #22 0x5b1fd7daf8aa _start r8: 00007fffb9571db0 r9: 00007fffb9571dd8 r10: 0000000000000058 r11: 0000000000000293 r12: 00001de68aaf7460 r13: 00007fffb9571dd8 r14: 00007fffb9571db0 r15: 00007fffb9571d88 di: 0000000000000000 si: 00005b1fddf84260 bp: 00007fffb9571f50 bx: 00001de689a4ad20 dx: 00005b1fddf84210 ax: 00001de689f0cb00 cx: 00001de689f0cfc0 sp: 00007fffb9571d60 ip: 00005b1fdef55c2b efl: 0000000000010202 cgf: 002b000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000 Original change's description: > [Lacros] Enable WebUSB, WebSerial, chrome.usb, chrome.serial API support. > > This CL enables USB and Serial related API on Lacros, by applying the > broad stroke of switching Lacros to use code that was previously > Ash-only. More work might be needed later to iron out details. > > Bug: 1195247, 1195248 > Change-Id: I04579cf60ca263907407abdc12cf7a9d5f9d10c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2939830 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#893539} Bug: 1195247, 1195248 Change-Id: I57c7a0dabb64c1ac25a4569fea5559778fe3e547 Owners-Override: Theodore Olsauskas-Warren <sauski@google.com> Owners-Override: Tom Sepez <tsepez@chromium.org> Owners-Override: Reilly Grant <reillyg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972361 Reviewed-by: Samuel Huang <huangs@chromium.org> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#894279}

…led." This reverts commit 722256f. Reason for revert: Suspect of test failures (CheckTest.NotReached) https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/59287/overview Original change's description: > Log crash keys and other info when DumpWithoutCrashing is called. > > This CL should slightly improve development experience when debugging > scenarios where a DumpWithoutCrashing is called when running a test, or > when manually trying to repro a bug with a developer build of Chromium. > This CL logs the same information as LOG(FATAL) would (stack trace, > task trace, crash keys). > > This CL has been opportunistically put together when working on > https://crbug.com/1038996, but it should be useful in general. > This CL does *not* fix https://crbug.com/1038996. > > Example of how test output might look like when it > (accidentally/unexpectedly in this case) triggers a renderer kill: > > [838194:838194:0826/140420.024770:ERROR:bad_message.cc(20)] Terminating extension renderer for bad IPC message, reason 21 > [838194:838194:0826/140420.024971:ERROR:process_posix.cc(337)] Unable to terminate process 838300: Resource temporarily unavailable (11) > [838194:838194:0826/140420.158002:ERROR:dump_without_crashing.cc(74)] DumpWithoutCrashing: > #0 0x7f678a4593e2 base::debug::CollectStackTrace() > #1 0x7f678a34d5d3 base::debug::StackTrace::StackTrace() > #2 0x7f678a36b533 logging::LogMessage::AppendCrashInfoForDevBuilds() > #3 0x7f678a34cdae (anonymous namespace)::MaybeLogThatDumpWithoutCrashingHappened() > #4 0x7f678a34cf2b base::debug::DumpWithoutCrashing() > #5 0x7f6782feddc6 content::RenderProcessHostImpl::ShutdownForBadMessage() > #6 0x5645447dc5c4 extensions::bad_message::ReceivedBadMessage() > #7 0x5645448fd588 extensions::MessagingAPIMessageFilter::OnOpenChannelToExtension() > #8 0x5645448fcfa7 IPC::MessageT<>::Dispatch<>() > #9 0x5645448fccc0 extensions::MessagingAPIMessageFilter::OnMessageReceived() > #10 0x7f678254ccd5 content::BrowserMessageFilter::Internal::DispatchMessage() > ... > Task trace: > #0 0x7f678254ca73 content::BrowserMessageFilter::Internal::OnMessageReceived() > #1 0x7f6789a8adce mojo::SimpleWatcher::Context::Notify() > Crash keys: > "RPH.BadMessageKill-isolation_mode" = "spp " > "killed_process_origin_lock" = "{ chrome-extension://mbbkmcnhalmicnfjpiigcennjnmlcdja/ }" > "extension_bad_message_reason" = "21" > "ExternalConnectionInfo-source_url" = "chrome-extension://mbbkmcnhalmicnfjpiigcennjnmlcdja/background.js" > "ExternalConnectionInfo-source_origin" = "nullptr" > "MessagingSource-extension_id" = "mbbkmcnhalmicnfjpiigcennjnmlcdja" > "MessagingSource-type" = "Extension" > "ExternalConnectionInfo-target_id" = "mbbkmcnhalmicnfjpiigcennjnmlcdja" > "ui_scheduler_async_stack" = "0x7F678254CA73 0x7F6789A8ADCE" > "io_scheduler_async_stack" = "0x7F6789A8ADCE 0x0" > > Bug: 1038996 > Change-Id: I2172212a42b43f9272ecc86904aeb2ddb3c3b936 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857528 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1040542} Bug: 1038996, 1357846 Change-Id: I46a19030cdfbfa87dd6c4769d0a83be8280c84fb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863294 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Owners-Override: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#1040707}

This reverts commit 395b2b1. Reason for revert: the following test cases fail - MediaFoundationRendererIntegrationTest.BasicPlayback - MediaFoundationRendererIntegrationTest.BasicPlayback_MediaSource on Windows 10/Asan with the failure log: [ RUN ] MediaFoundationRendererIntegrationTest.BasicPlayback ================================================================= ==644==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000008 (pc 0x7ff6889a1e92 bp 0x00c26c4fe5f0 sp 0x00c26c4fe560 T0) ==644==The signal is caused by a READ memory access. ==644==Hint: address points to the zero page. ==644==*** WARNING: Failed to initialize DbgHelp! *** ==644==*** Most likely this means that the app is already *** ==644==*** using DbgHelp, possibly with incompatible flags. *** ==644==*** Due to technical reasons, symbolization might crash *** ==644==*** or produce wrong results. *** #0 0x7ff6889a1e91 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:263 #1 0x7ff6889a1e91 in media::MediaFoundationRenderer::RequestNextFrame(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:1022:23 #2 0x7ff68899bed8 in media::MediaFoundationRenderer::OnPlaying(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:838:3 #3 0x7ff68a04bb3a in base::OnceCallback<void ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #4 0x7ff68a04bb3a in base::TaskAnnotator::RunTaskImpl(struct base::PendingTask &) C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.cc:133:32 #5 0x7ff68ac91059 in base::TaskAnnotator::RunTask C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.h:72 #6 0x7ff68ac91059 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(class base::LazyNow *) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:422:21 #7 0x7ff68ac90046 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork(void) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:292:41 #8 0x7ff68acc53da in base::MessagePumpDefault::Run(class base::MessagePump::Delegate *) C:\b\s\w\ir\cache\builder\src\base\message_loop\message_pump_default.cc:39:55 #9 0x7ff68ac9316b in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, class base::TimeDelta) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:575:12 #10 0x7ff68960a00c in base::RunLoop::Run(class base::Location const &) C:\b\s\w\ir\cache\builder\src\base\run_loop.cc:141:14 #11 0x7ff68942c9a7 in media::PipelineIntegrationTestBase::RunUntilQuitOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:697:13 #12 0x7ff689424636 in media::PipelineIntegrationTestBase::RunUntilQuitOrEndedOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:709:3 #13 0x7ff689424449 in media::PipelineIntegrationTestBase::WaitUntilEndedOrError(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:226:5 #14 0x7ff689423ac4 in media::PipelineIntegrationTestBase::WaitUntilOnEnded(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:217:27 #15 0x7ff686ce4597 in media::MediaFoundationRendererIntegrationTest_BasicPlayback_Test::TestBody(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer_integration_test.cc:92:3 #16 0x7ff6870b0c77 in testing::Test::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2670:5 #17 0x7ff6870b2c3b in testing::TestInfo::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2849:11 #18 0x7ff6870b498e in testing::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:3008:30 #19 0x7ff6870d772f in testing::internal::UnitTestImpl::RunAllTests(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5866:44 #20 0x7ff6870d6bd5 in testing::UnitTest::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5440:10 #21 0x7ff6896d7a69 in RUN_ALL_TESTS C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2284 #22 0x7ff6896d7a69 in base::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\base\test\test_suite.cc:463:16 #23 0x7ff6896dc4ed in base::OnceCallback<int ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #24 0x7ff6896dc4ed in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:181:38 #25 0x7ff6896dc0ba in base::LaunchUnitTests(int, char **, class base::OnceCallback<(void)>, unsigned __int64) C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:272:10 #26 0x7ff686dcc7f9 in main C:\b\s\w\ir\cache\builder\src\media\test\run_all_unittests.cc:52:10 #27 0x7ff68c67712b in invoke_main d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78 #28 0x7ff68c67712b in __scrt_common_main_seh d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 #29 0x7fff384a2773 (C:\Windows\System32\KERNEL32.DLL+0x180012773) #30 0x7fff386e0d50 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: access-violation C:\b\s\w\ir\cache\builder\src\base\callback.h:263 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run ==644==ABORTING Original change's description: > [MediaFoundation] Request next frame during onPlaying event > > OS: Win10, Win11 > > During OnPlaying event, a frame request should be called to get > the first frame to output at the earliest possible time. This > is the earliest time when a frame is available. Current > implementation waits for render to be called, while > StartPlayingFrom's call for RequestNextFrameBetweenTimestamps > may not output a result if the media engine is not yet ready > to output a frame. > > Bug: 1355520 > Change-Id: Ice60ac41ca4b8cae9b0687626e93017d0a4406f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852409 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Daoyuan Li <daoyuanli@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1041097} Bug: 1355520 Change-Id: Ic483e314ce14e3f187691df772515eacea387cb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863075 Commit-Queue: Asami Doi <asamidoi@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1041256}

Change-Id: I5048f6048c45cbba638905739ce8a135c58b20be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781545 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5195@{#6} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}

Enabling ozone_unittests on linux bots revealed some problems with downcasting. In particular, linux-ubsan-vptr bot started to fail with the following error message - ./../ui/ozone/platform/wayland/host/wayland_data_drag_controller.cc:515:10: runtime error: downcast of address 0x2ccc00349e00 which does not point to an object of type 'const WaylandExchangeDataProvider' 0x2ccc00349e00: note: object is of type 'ui::OSExchangeDataProviderNonBacked' 00 00 00 00 28 3b f6 e3 f0 55 00 00 01 00 00 00 00 00 00 00 20 b1 26 00 cc 2c 00 00 28 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'ui::OSExchangeDataProviderNonBacked' #0 0x55f0e331831c in GetOfferedExchangeDataProvider ui/ozone/platform/wayland/host/wayland_data_drag_controller.cc:515:10 #1 0x55f0e331831c in ui::WaylandDataDragController::StartSession(ui::OSExchangeData const&, int, ui::mojom::DragEventSource) ui/ozone/platform/wayland/host/wayland_data_drag_controller.cc:133:23 #2 0x55f0e3366bbc in ui::WaylandWindow::StartDrag(ui::OSExchangeData const&, int, ui::mojom::DragEventSource, ui::Cursor, bool, base::OnceCallback<void (ui::mojom::DragOperation)>, ui::WmDragHandler::LocationDelegate*) ui/ozone/platform/wayland/host/wayland_window.cc:227:45 #3 0x55f0e2b28c32 in ui::WaylandDataDragControllerTest_AsyncNoopStartDrag_Test::TestBody() ui/ozone/platform/wayland/host/wayland_data_drag_controller_unittest.cc:973:28 #4 0x55f0e2e26ab1 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2670:5 #5 0x55f0e2e28046 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2849:11 #6 0x55f0e2e29beb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3008:30 #7 0x55f0e2e3fafe in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5866:44 #8 0x55f0e2e3e604 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5440:10 #9 0x55f0e34276d1 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #10 0x55f0e34276d1 in base::TestSuite::Run() base/test/test_suite.cc:463:16 #11 0x55f0e342b9dc in Run base/callback.h:145:12 #12 0x55f0e342b9dc in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::RepeatingCallback<void ()>, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:181:38 #13 0x55f0e342b877 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) base/test/launcher/unit_test_launcher.cc:272:10 #14 0x55f0e2acc2cc in main mojo/core/test/run_all_unittests.cc:69:10 #15 0x7ff7560d4082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16 #16 0x55f0e2ab4169 in _start (/home/msisov/code/chromium/src/out/asan/ozone_unittests+0xb13169) (BuildId: 77bfee5b71bd92da) It turned out that WaylandDataDragController was getting a non-backed provider as a Wayland one wasn't set (it's set during OzonePlatformWayland initialization in production). As a result, downcasting to WaylandExchangeDataProvider was illegal in tests. It's unknown why tests didn't fail. Probably, the result of the WaylandDataDragController::GetOfferedExchangeDataProvider was never used. And the problem with downcasting was only caught with this new bot. Bug: 1358123 Change-Id: I4c8deb16a57b485de1fabd91fdcaab136d5da639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3865512 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/main@{#1041976}

Patch: This patch adds an OpenscreenRpcDispatcher implementation based on the openscreen::cast::SenderSessionMessenger. For more context, see the reference patch that includes this plus other changes: https://chromium-review.googlesource.com/c/chromium/src/+/3868508. Coming up next: 1. Backing code to allow getting the audio encoder's bitrate will be added to the audio RTP stream. 2. A new class called OpenscreenSessionHost will be added to wrap an openscreen::cast::SenderSession. 3. Metrics need to be added to make sure we don't introduce major regressions. 4. Once these pieces are in place, extensive manual testing and improving of the automated test suite needs to occur. Overall feature: Libcast-In-Chrome is a project with the goal of having libcast be the backing implementation of cast streaming in Chrome. Bug: 1318499, b/159352836 Change-Id: I31697d1f3c0f23ab3bdea5d8da070d0229d9ab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3867701 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/main@{#1045311}

https://webrtc.googlesource.com/src.git/+log/b555e83395a2..1adcde9dfe0c 2022-09-19 samvi@google.com Use active ICE controller in P2PTransportChannel with an adapter (#6/n) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7454e109bce1bfbf0b91fe3039360753d89ede1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904521 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1048578}

Adds FirstRunPageDelegate.canUseLandscapeLayout method that returns false if FRE is shown within TabbedModeFirstRunActivity (which is shown in a dialog that always has the portrait orientation) or true if FRE is shown within FirstRunActivity (which is shown in fullscreen mode and thus can have landscape orientation). This method is then used to suppress the usage of signin_first_run_landscape_view when FRE is shown in a dialog. (cherry picked from commit 0f60b0e) Bug: 1350917 Change-Id: I55a67d32eb12bd726f31bb4320e71a36dc313048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840395 Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1037066} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840432 Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249@{#6} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}

This reverts commit b121781. Reason for revert: breaks asan see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/106685/test-results ================================================================= ==7990==ERROR: AddressSanitizer: heap-use-after-free on address 0x61500014a3c8 at pc 0x55bcdbc9090d bp 0x7ffe8c468ab0 sp 0x7ffe8c468aa8 READ of size 8 at 0x61500014a3c8 thread T0 (browser_tests) #0 0x55bcdbc9090c in begin buildtools/third_party/libc++/trunk/include/vector:1374:33 #1 0x55bcdbc9090c in begin<std::Cr::vector<base::internal::UncheckedObserverAdapter, std::Cr::allocator<base::internal::UncheckedObserverAdapter> > &> base/ranges/ranges.h:44:37 #2 0x55bcdbc9090c in begin<std::Cr::vector<base::internal::UncheckedObserverAdapter, std::Cr::allocator<base::internal::UncheckedObserverAdapter> > &> base/ranges/ranges.h:105:10 #3 0x55bcdbc9090c in find_if<std::Cr::vector<base::internal::UncheckedObserverAdapter, std::Cr::allocator<base::internal::UncheckedObserverAdapter> > &, (lambda at ../../base/observer_list.h:287:21), base::identity, std::Cr::random_access_iterator_tag> base/ranges/algorithm.h:483:26 #4 0x55bcdbc9090c in base::ObserverList<permissions::PermissionRequestManager::Observer, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(permissions::PermissionRequestManager::Observer const*) base/observer_list.h:286:21 #5 0x55bcdf91c380 in Reset base/scoped_observation.h:86:7 #6 0x55bcdf91c380 in ~ScopedObservation base/scoped_observation.h:70:26 #7 0x55bcdf91c380 in permissions::PermissionRequestObserver::~PermissionRequestObserver() components/permissions/test/permission_request_observer.cc:14:55 #8 0x55bccbcd2629 in PermissionRequestChipGestureSensitiveBrowserTest_ShouldUpdateActiverPRMAndObservations_Test::RunTestOnMainThread() chrome/browser/ui/views/permissions/permission_request_chip_browsertest.cc:294:1 #9 0x55bce299402f in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:883:7 #10 0x55bce299accf in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> base/functional/bind_internal.h:643:12 #11 0x55bce299accf in MakeItSo<void (content::BrowserTestBase::*)(), std::Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::RawPtrBanDanglingIfSupported> > > base/functional/bind_internal.h:822:12 #12 0x55bce299accf in RunImpl<void (content::BrowserTestBase::*)(), std::Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::RawPtrBanDanglingIfSupported> >, 0UL> base/functional/bind_internal.h:916:12 #13 0x55bce299accf in base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::RawPtrBanDanglingIfSupported>>, void ()>::RunOnce(base::internal::BindStateBase*) base/functional/bind_internal.h:867:12 Original change's description: > Make confirmation chip independent of request chip > > See design doc: go/confirmation-chip > > Bug: 1364276 > Change-Id: Iab08a5bb96271d45101ba68c0134751b921b7667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921717 > Commit-Queue: Florian Jacky <fjacky@chromium.org> > Reviewed-by: Illia Klimov <elklm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1055397} Bug: 1364276 Change-Id: Iecf56cfafaf15a2ab8329138f7508de8afd0a341 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937182 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Avi Drissman <avi@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055548}

Change-Id: I462dea6835a939d2872bbd70eb4fd306cf4359e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3928155 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249_91@{#6} Cr-Branched-From: fa96d5f-refs/branch-heads/5249@{#707} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}

This CL is fixing the bucket for ShutdownType2 for process that do an early exit within BasicStartupComplete(...). These cases can be repro on Linux with these commands: 1) ./chrome --version 2) ./chrome --product-version 3) ./chrome --credits 4) ./chrome --diagnostics The ChromeMainDelegate must be robust for cases where the BasicStartupComplete is not fully executed due to an error (early exits). The chrome logging was assuming it was initialized. This CL is ensuring the code was initialized to call the corresponding shutdown code. [1004/174420.541708:FATAL:logging_chrome.cc(468)] Check failed: chrome_logging_initialized_. Attempted to clean up logging when it wasn't initialized. #0 0x55a6a8cf8952 base::debug::CollectStackTrace() #1 0x55a6a8be9cc3 base::debug::StackTrace::StackTrace() #2 0x55a6a8c0468f logging::LogMessage::~LogMessage() #3 0x55a6a8c0549e logging::LogMessage::~LogMessage() #4 0x55a6ab92495b logging::CleanupChromeLogging() #5 0x55a6a355f45b ChromeMainDelegate::ProcessExiting() #6 0x55a6a85ed50d content::ContentMainRunnerImpl::Shutdown() #7 0x55a6a85eaddb content::ContentMainRunnerImpl::~ContentMainRunnerImpl() #8 0x55a6a85eaf1e content::ContentMainRunnerImpl::~ContentMainRunnerImpl() #9 0x55a6a85e8bb0 content::ContentMain() #10 0x55a6a355d236 ChromeMain #11 0x7fc168e4781d __libc_start_main #12 0x55a6a355d02a _start Change-Id: I51c9d7b18535f69d6733a8d0b88d0a80111bdcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931775 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058086}

`char16_t` (which `UChar` is defined as) cannot be used to alias general memory. Yet we try to use it to read a `blink::QualifiedName::QualifiedNameImpl` among other things. This is UB, and gcc -O2 misoptimizes it. When chromium is compiled with allocator shim, this manifests as an immediate crash: * frame #0: 0x0000556e1280927b electron`FreelistCorruptionDetected [inlined] operator() at partition_freelist_entry.h:31 frame #1: 0x0000556e1280927a electron`FreelistCorruptionDetected(extra=48) at partition_freelist_entry.h:31 frame #2: 0x0000556e129dd167 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(partition_alloc::PartitionRoot<true>*, unsigned int, unsigned long, unsigned long, bool*) at partition_freelist_entry.h:303 frame #3: 0x0000556e129dd162 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(partition_alloc::PartitionRoot<true>*, unsigned int, unsigned long, unsigned long, bool*) [inlined] partition_alloc::internal::PartitionFreelistEntry::GetNext(unsigned long) const at partition_freelist_entry.h:328 frame #4: 0x0000556e129dd162 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(partition_alloc::PartitionRoot<true>*, unsigned int, unsigned long, unsigned long, bool*) [inlined] partition_alloc::internal::SlotSpanMetadata<true>::PopForAlloc(unsigned long) at partition_page.h:739 frame #5: 0x0000556e129dd162 electron`partition_alloc::internal::PartitionBucket<true>::SlowPathAlloc(this=0x0000556e19292598, root=0x0000556e19292500, flags=33, raw_size=<unavailable>, slot_span_alignment=48, is_already_zeroed=0x00007ffe8f1196f7) at partition_bucket.cc:1354 frame #6: 0x0000556e129ddbc0 electron`partition_alloc::ThreadCache::FillBucket(unsigned long) at partition_root.h:1076 frame #7: 0x0000556e129ddbbb electron`partition_alloc::ThreadCache::FillBucket(this=<unavailable>, bucket_index=5755259732000) at thread_cache.cc:607 frame #8: 0x0000556e129dfd3a electron`base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*) at thread_cache.h:525 frame #9: 0x0000556e129dfd18 electron`base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*) at partition_root.h:1742 frame #10: 0x0000556e129dfb18 electron`base::internal::PartitionMalloc((null)=<unavailable>, size=40, context=<unavailable>) at allocator_shim_default_dispatch_to_partition_alloc.cc:304 frame #11: 0x0000556e128dbe43 electron`::malloc(unsigned long) at allocator_shim.cc:201:37 frame #12: 0x0000556e128dbe30 electron`::malloc(size=40) at allocator_shim_override_libc_symbols.h:35:20 frame #13: 0x0000556e16c0f6e6 electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) [inlined] WTF::RefCounted<blink::QualifiedName::QualifiedNameImpl, WTF::DefaultRefCountedTraits<blink::QualifiedName::QualifiedNameImpl>>::operator new(unsigned long) at ref_counted.h:44 frame #14: 0x0000556e16c0f6e1 electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) [inlined] blink::QualifiedName::QualifiedNameImpl::Create((null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>) at qualified_name.h:62 frame #15: 0x0000556e16c0f6dd electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) at qualified_name.cc:69 frame #16: 0x0000556e16c0f6ba electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>(blink::QualifiedNameData&, blink::QualifiedNameData&) (.constprop.0) [inlined] void WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>::Translate<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedNameData&, blink::QualifiedNameData>(blink::QualifiedName::QualifiedNameImpl*&, blink::QualifiedNameData&, blink::QualifiedNameData const&, unsigned int) at hash_set.h:184 frame #17: 0x0000556e16c0f6ba electron`WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::InsertPassingHashCode<WTF::HashSetTranslatorAdapter<blink::QNameComponentsTranslator>, blink::QualifiedNameData&, blink::QualifiedNameData&>((null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>) (.constprop.0) at hash_table.h:1481 frame #18: 0x0000556e1492f9cf electron`blink::QualifiedName::QualifiedName(WTF::AtomicString const&, WTF::AtomicString const&, WTF::AtomicString const&) [inlined] WTF::HashTableAddResult<WTF::HashTable<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedName::QualifiedNameImpl*, WTF::IdentityExtractor, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>, blink::QualifiedName::QualifiedNameImpl*> WTF::HashSet<blink::QualifiedName::QualifiedNameImpl*, blink::QualifiedNameHash, WTF::HashTraits<blink::QualifiedName::QualifiedNameImpl*>, WTF::PartitionAllocator>::AddWithTranslator<blink::QNameComponentsTranslator, blink::QualifiedNameData&>(blink::QualifiedNameData&) at hash_set.h:307 frame #19: 0x0000556e1492f9ca electron`blink::QualifiedName::QualifiedName((null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>, (null)=<unavailable>) at qualified_name.cc:81 When chromium is compiled with system malloc, this manifests as graphical glitches, followed by a crash much later on. It is worth noting that this exact code snippet was discussed on the GCC bugtracker in 2014 (predating the forking of Chromium from WebKit): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60546#c21 The corresponding code no longer exists in WebKit. Attached patch makes the HashMemory function type-safe without changing the API for other users of StringHasher. Bug: 819294 Change-Id: Iac11ec77501c2f1d6d01db85d5b9d544adeaf71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3968507 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com> Cr-Commit-Position: refs/heads/main@{#1061939}

Fixes HTTPTransport tests that fail with: Uninitialized bytes in __interceptor_fopen64 at offset 0 inside [0x70200001ce60, 25) ==3342==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f115b1ef5d9 in BIO_new_file ??:0:0 #1 0x7f115b22117d in COMP_CTX_get_type ??:? #2 0x7f115b22278c in CONF_modules_load_file ??:0:0 #3 0x7f115b222a4f in OPENSSL_config ??:? #4 0x7f115b2b94f3 in HMAC_CTX_get_md ??:? #5 0x7f115ed084de in __pthread_once_slow ??:0:0 #6 0x7f115b324aac in CRYPTO_THREAD_run_once ??:0:0 #7 0x7f115b2b9b77 in OPENSSL_init_crypto ??:0:0 #8 0x7f115dfa3574 in OPENSSL_init_ssl ??:0:0 R=thestig Change-Id: Ie6aa3223df4d50dedcc59c2f757de62ff35ac1aa Bug: 1260217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3993372 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1065765}

This class removes the friend classes of ProfileDestroyer as they were calling internal methods that bypassed the creation of ProfileDestroyer objects and called DestroyOffTheRecordProfileNow directly, which has led to crashes in the past (https://crbug.com/1337388#c11). Note: This CL changes the behavior of ProfileDestroyer when destroying an off-the-record profile immediately via ProfileDestroyer::DestroyOTRProfileImmediately(). With the new implementation, the CHECK in ~ProfileDestroyer() will trigger and we may see an increase of crashes with this signature. Before this CL, the app will still crash, but in a different code location (see test), with the stack trace below: [456919:456919:FATAL:dependency_manager.cc(173)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again. #0 0x7fe99bc08932 base::debug::CollectStackTrace() #1 0x7fe99bb348a3 base::debug::StackTrace::StackTrace() #2 0x7fe99bb4fff3 logging::LogMessage::~LogMessage() #3 0x7fe99bb50e9e logging::LogMessage::~LogMessage() #4 0x7fe9992b7396 DependencyManager::AssertContextWasntDestroyed() #5 0x7fe996fe7e32 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x7fe9992b79af KeyedServiceFactory::GetServiceForContext() #7 0x55c217195682 extensions::ChromeContentBrowserClientExtensionsPart::SiteInstanceDeleting() #8 0x55c2162f1f9d ChromeContentBrowserClient::SiteInstanceDeleting() #9 0x7fe99a5bc5af content::SiteInstanceImpl::~SiteInstanceImpl() #10 0x7fe99a5bc6de content::SiteInstanceImpl::~SiteInstanceImpl() #11 0x55c21327864f ProfileDestroyerTest::~ProfileDestroyerTest() Bug: 1378254 Change-Id: Ib144ffe8d2344dc7efc7cd22360e8fce0b2beb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3978432 Reviewed-by: Alex Ilin <alexilin@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/main@{#1067599}

In View::HandleAccessibleAction, accessibility sends both a press and release mouse event to the view instance. Unfortunately, if the view deletes itself immediately after receiving the mouse press event, the subsequent mouse release event causes a UAF. e.g. for illustrative purposes, here's the flow: bool HandleAccessibleAction(...) { view->OnEvent(mouse_press); // |view| is now deleted. view->OnEvent(mouse_release); // UAF. } Fix this by overriding HandleAccessibleAction in the self-deleting view. Notes: The deletion stack for the WindowCycleItemView is #3 0x560338183db8 in operator() buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:49:5 #4 0x560338183db8 in reset buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:281:7 #5 0x560338183db8 in ~unique_ptr buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:247:75 #6 0x560338183db8 in views::View::DoRemoveChildView(views::View*, bool, bool, views::View*) ui/views/view.cc:2739:1 #7 0x560338183fe4 in views::View::RemoveAllChildViews() ui/views/view.cc:341:5 #8 0x560333f50cbb in ash::WindowCycleView::DestroyContents() ash/wm/window_cycle/window_cycle_view.cc:379:3 #9 0x560333f4b3e7 in ash::WindowCycleList::~WindowCycleList() ash/wm/window_cycle/window_cycle_list.cc:139:18 #10 0x560333f4b747 in ash::WindowCycleList::~WindowCycleList() ash/wm/window_cycle/window_cycle_list.cc:117:37 #11 0x560333f475e8 in operator() buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:49:5 #12 0x560333f475e8 in reset buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:281:7 #13 0x560333f475e8 in ash::WindowCycleController::StopCycling() ash/wm/window_cycle/window_cycle_controller.cc:421:22 #14 0x560333f5944c in ash::WindowCycleItemView::OnMousePressed(ui::MouseEvent const&) ash/wm/window_cycle/window_cycle_item_view.cc:53:44 #15 0x560338193ae2 in views::View::ProcessMousePressed(ui::MouseEvent const&) ui/views/view.cc:3109:23 #16 0x56033819362d in views::View::OnMouseEvent(ui::MouseEvent*) ui/views/view.cc:1492:11 Bug: 1380602 Change-Id: I2533dc299c0f5f5bb32efa130e6d564cb70d4613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4046647 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076637}

Change-Id: I812698c558c427a0c0e989e7e8e00cb96083e831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4072705 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359_71@{#6} Cr-Branched-From: 1e0e386-refs/branch-heads/5359@{#1016} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}

R=morawand@google.com Change-Id: I8fde4c18fc79d9a8fb555d71e4c24723b66609e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114007 Reviewed-by: Kuan Huang <kuanhuang@chromium.org> Reviewed-by: Xinan Lin <linxinan@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5481@{#6} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

https://chromium.googlesource.com/v8/v8.git/+log/03124b7d0c8c..616e3341011b 2023-02-10 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.0.226.15 2023-02-10 machenbach@chromium.org [bazel] Update prebuilt bazel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-release-1 Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in v8 11.0: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m110: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md (cherry picked from commit 50990ba) Bug: chromium:1410471 Tbr: v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iacad20748894d54f0f96c411333f3be786a25ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4239758 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5481@{#1075} Cr-Original-Branched-From: 130f3e4-refs/heads/main@{#1084008} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240371 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5481_77@{#6} Cr-Branched-From: 65ed616-refs/branch-heads/5481@{#839} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

Change-Id: I550de9034b70cb8373058076102e89b9acb84c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200886 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#6} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

Change-Id: I623fc7c681a7b9ce65d6a5ca34cf0eb53834131f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291795 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{#6} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

https://chromium.googlesource.com/v8/v8.git/+log/b52916fcce1c..7db8eae7e0af 2023-04-04 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.2.214.13 2023-04-04 alexschulze@chromium.org Whitespace change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-release-1 Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in v8 11.2: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m112: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md (cherry picked from commit f89bb7c) Bug: None Tbr: v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8252fb6cb57f4a0adcae7f7a72faba2438d708b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4397890 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5615@{#1095} Cr-Original-Branched-From: 9c6408e-refs/heads/main@{#1109224} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424417 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5615_51@{#6} Cr-Branched-From: 86d49da-refs/branch-heads/5615@{#938} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

Removing identity from IS_READY_TO_PAY turned out to break a native payment app. This was partially anticipated and we had a reverse Origin Trial to re-enable it to allow for breakages like this, however the implementation of it was wrong. Fixing the Origin Trial implementation is non-trivial (have to plumb data from each renderer through to the Android code), so this is a quick-fix to just re-enable identity to be merged back. (cherry picked from commit 388831e) Bug: 1427426, 1290492 Change-Id: Ief38b60174ff9172dd44bfcce0d6fc9e71d5082d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369599 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1121725} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369302 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/branch-heads/5672@{#6} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

Change-Id: Ied4ce357774efe1c1dc47e42db1fa9467b77b360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503629 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672_63@{#6} Cr-Branched-From: 0e1a447-refs/branch-heads/5672@{#912} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

Change-Id: I7707bd0459f9832861fcec6504eef70d0cc8155d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4480889 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#6} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

Change-Id: Ibc442c928a3ccc5c662613087172dc20ebe22f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584814 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735_90@{#6} Cr-Branched-From: 386bc09-refs/branch-heads/5735@{#1052} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

(cherry picked from commit 900a28b) (cherry picked from commit 5297663) Bug: 1456872 Change-Id: Ie6765521d676d5a0d4bb7580302c648f78840adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637050 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ankush Singh <ankushkush@google.com> Cr-Original-Original-Commit-Position: refs/heads/main@{#1161807} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4639974 Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5849@{#6} Cr-Original-Branched-From: ec13da3-refs/heads/main@{#1161677} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4642632 Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{#1146} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

Change-Id: I5c3320fa464cadb2fab20c0bca3075b772bfadbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4688237 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790_90@{#6} Cr-Branched-From: 86fb9d0-refs/branch-heads/5790@{#1583} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

This reverts commit e2c2265. Reason for revert: failing on: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/34119/test-results?sortby=&groupby= 2023-09-12T23:08:42.747041Z FATAL browser_tests[325873:325873]: [scalable_iph_browser_test_base.cc(114)] Check failed: !mock_delegate_. Mocks have already been set up. [...] #6 0x55e25ba19703 ash::ScalableIphBrowserTestBase::SetUpMocks() #7 0x55e25ba19661 ash::ScalableIphBrowserTestBase::SetUpOnMainThread() #8 0x55e2699e883b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() [...] Original change's description: > Add phone hub onboarding eligible condition > > - This CL adds x_CustomConditionPhoneHubOnboardingEligible. The > condition is true if feature status of Phone Hub is either > kEligiblePhoneButNotSetUp or kDisabled. > - This adds a dependency from ScalableIph to PhoneHubManager. > PhoneHubManager is expected to be initialized at a specific timing. > This CL makes sure that ScalableIph is initialized after > PhoneHubManager. > - This CL fixes an issue with our OOBE flow test in our browser tests. > - To fix the browser test, we had to change behavior of > LoggedInUserMixin. Previously LoggedInUserMixin has configured > LoginManagerMixin to skip post login screens by default. This CL > makes it optional. > - familiy_user_device_metrics_browsertest.cc was depending on the > default behavior. This CL updates the test. > > Bug: b:295369951 > Test: browser_tests --gtest_filter=*ScalableIph* > Change-Id: I361169d5ca7d531ed26f16cd94b3247be6edb94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845174 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Toni Barzic <tbarzic@chromium.org> > Reviewed-by: Courtney Wong <courtneywong@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Yuki Awano <yawano@google.com> > Cr-Commit-Position: refs/heads/main@{#1195612} Bug: b:295369951 Change-Id: I7bde487bc9268817bb1468c7db30d470e42de941 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4860192 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Owners-Override: Frank Liberato <liberato@google.com> Cr-Commit-Position: refs/heads/main@{#1195718}

Change-Id: I08f802e840c13a32dd253aca7e4eb5ddb2bf25a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863860 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938_62@{#6} Cr-Branched-From: 25a7172-refs/branch-heads/5938@{#1146} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Change-Id: I9576a6f54b71330cf4a0687dbbd01baccc81afdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5075276 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099_56@{#6} Cr-Branched-From: 6c113a6-refs/branch-heads/6099@{#1192} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

(cherry picked from commit a489816) (cherry picked from commit 77a61a7) Bug: b/315050843 Change-Id: I7f0542afa7324c8f3507debf5917e302ed9020b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096379 Commit-Queue: Emily Shack <emshack@chromium.org> Reviewed-by: David Pennington <dpenning@chromium.org> Auto-Submit: Emily Shack <emshack@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/main@{#1234206} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5101154 Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/6170@{#6} Cr-Original-Branched-From: 5c2db79-refs/heads/main@{#1234130} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191478 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/branch-heads/6167@{#1290} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

blueboxd added the bug Something isn't working label Dec 14, 2020

blueboxd closed this as completed Dec 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crashing when download a file, OS X Lion 10.7.5 #6

Crashing when download a file, OS X Lion 10.7.5 #6

Ciombenu commented Dec 12, 2020

blueboxd commented Dec 14, 2020

Crashing when download a file, OS X Lion 10.7.5 #6

Crashing when download a file, OS X Lion 10.7.5 #6

Comments

Ciombenu commented Dec 12, 2020

blueboxd commented Dec 14, 2020