Crashing on launch on OS X 10.9.5 #2

Wowfunhappy · 2020-09-16T15:58:39Z

First of all: Thank you so much for maintaining this!

Unfortunately, I cannot seem to get this to launch on OS X 10.9.5. It opens, bounces in the Dock for a few seconds, then crashes due to EXC_BAD_ACCESS. A full crash report is attached.

Note that—as you may notice in the log—I am running inside of a VM. While my host machine is also running OS X 10.9.5, as a matter of course I always test out new software in a VM before moving it to my main machine. VMWare Fusion is very good, and it has never caused problems in the past (outside of highly 3D-intensive software like games), but if you think this is the source of the crash, please let me know and I'll try on the real thing.

Thanks again!

Chromium_2020-09-16-085032_Jonathans-Mac.crash.zip

The text was updated successfully, but these errors were encountered:

New API related checks are some of our most valuable lint checks, as triggering an error causes a crash directly. This CL adds compile test targets to ensure that code with API level errors trigger lint warnings. This prevents lint being accidentally turned off. Also delete now obsolete //build/android/lint directory and remove some already-fixed suppressions from lint-suppressions.xml. This is a reland of 607f1b1 fixing the compile error in LintTest.java. Tbr: mheikal@chromium.org Bug: 1108309 Change-Id: Ibf8c262b3f85b9e0eca61c8e1ec57a8986f0458a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416778 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808059}

In the new UI layout, the PDF area can be resized in two ways 1) expanding/collapsing the sidenav 2) resizing the entire window Because of #1, the previous approach of listening for the Window's 'resize' event is no longer sufficient. Therefore a ResizeObserver is used which works for both #1 and #2. Bug: 1121351 Change-Id: I6fd895a55e4630f9562c8d8ea38dc7d4fc6ebb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391335 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808469}

This patch adds three UseCounters for measuring dark mode usage: 1. kForcedDarkMode which is set for pages loaded with forced dark mode. 2. kPreferredColorSchemeDark which is set when prefers-color-scheme media queries will match dark. 3. kPreferredColorSchemeDarkSetting which is set when the preferred color scheme dark setting is set (i.e., the system is in dark mode). This can differ from #2 in cases where the system is in dark mode and forced dark mode is enabled, resulting in prefers-color-scheme being "light" in some cases. Bug: 1131028 Change-Id: I85bc9db6ef30ce0dfc4f78c0c51d039bb04a100d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423168 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809477}

aeiouaeiouaeiouaeiouaeiouaeiou · 2020-09-22T22:11:42Z

Keeps crashing on 809500 build.

blueboxd · 2020-09-22T23:39:06Z

unfortunately, these chromium builds are not working on 10.9 for now.
It seems caused by the skia library and 10.9's system font framework, but the details of the cause are unknown.
I'll keep investigating, but I'm not sure if it can be resolved. sorry.

Paint worklet already works with custom property animation running on the compositor thread, the requirement is that we need “will-change: transform” for the paint worklet element. Without that, the custom property animation will run on the main thread, such as this example: https://output.jsbin.com/muwiyux/quiet. This CL makes changes such that a custom property animation will always be composited as long as it is used by paint worklet, even if the element doesn't have "will-change: transform". The change is actually small, there are only two things we need: 1. Start the animation on compositor. 2. Ensure the compositor ticks the animation. For #1, we add a "has_paint_worklet_with_custom_prop_anim" in the Animation::PreCommit, when it is true, we always composite the animation. For #2, we give a special ElementId which is uint64_t::max() to the paint worklet element, and on the CC side, once we see that element id, we know that the animation associated with that should be ticking even if the element id doesn't have anything associated on the property tree. Bug: 987969 Change-Id: Ia849640065470e529a2b8d23a4b7b74339831c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359370 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812056}

…gentSchedulingGroup" This reverts commit 84d8dbe. Reason for revert: Suspect causing blink_web_tests failures on WebKi_Linux_ASAN because of heap-use-after-free. First detected build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/18333 blink_web_tests failure: https://test-results.appspot.com/data/layout_results/WebKit_Linux_ASAN/18333/blink_web_tests/layout-test-results/results.html --- STDERR: ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0000065e8 at pc 0x562d5af2328d bp 0x7ffd61c33860 sp 0x7ffd61c33858 STDERR: READ of size 8 at 0x60d0000065e8 thread T0 (content_shell) STDERR: error: unknown argument '--demangle=True' STDERR: #0 0x562d5af2328c in content::AgentSchedulingGroup::RemoveRoute(int) ./../../content/renderer/agent_scheduling_group.cc:133 STDERR: #1 0x562d5af2328c in ?? ??:0 STDERR: #2 0x562d5af61740 in content::RenderFrameProxy::~RenderFrameProxy() ./../../content/renderer/render_frame_proxy.cc:248 STDERR: #3 0x562d5af61740 in ?? ??:0 STDERR: #4 0x562d5af61b7d in content::RenderFrameProxy::~RenderFrameProxy() ./../../content/renderer/render_frame_proxy.cc:246 STDERR: #5 0x562d5af61b7d in ?? ??:0 STDERR: #6 0x562d5af6712d in content::RenderFrameProxy::FrameDetached(blink::WebRemoteFrameClient::DetachType) ./../../content/renderer/render_frame_proxy.cc:620 STDERR: #7 0x562d5af6712d in ?? ??:0 --- Original change's description: > [MBI]: Use |render_thread_| instead of RenderThread::Get in AgentSchedulingGroup > > R=haraken@chromium.org, kouhei@chromium.org, talp@chromium.org > > Bug: 1111231 > Change-Id: Ia7151587a3459c5262edd5721c63dfec60870cc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438709 > Commit-Queue: Dominic Farolino <dom@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Tal Pressman <talp@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812463} TBR=haraken@chromium.org,kouhei@chromium.org,dom@chromium.org,talp@chromium.org Change-Id: I1cda1459c45d129c669fa2736a4ea4322533515c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442211 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#812553}

This reverts commit 635cbc1. Reason for revert: suspect causing views_unittests failure on Linux ChromiumOS MSan Tests --- BoxLayoutViewTest.NoLayoutInvalidationWhenPropertyUnchanged BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged --- First test failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20798 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867505219215733920/+/steps/views_unittests/0/logs/Deterministic_failure:_BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged__status_CRASH_/0 --- [ RUN ] BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged ==11171==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5570eca375a3 in testing::AssertionResult testing::internal::CmpHelperNE<int, int>(char const*, char const*, int const&, int const&) ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:1638 #1 0x5570eca375a3 in ?? ??:0 #2 0x5570ed05abfe in views::BoxLayoutViewTest_LayoutInvalidationWhenPropertyChanged_Test::TestBody() ./../../ui/views/layout/box_layout_view_unittest.cc:78 --- Original change's description: > Views: Add BoxLayoutView > > This CL adds class member getters and setters to the BoxLayout class > where needed for the BoxLayoutView properties. Adds a TODO to ensure > layout is invalidated when these members are set. > > Bug: None > Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561 > Reviewed-by: Wei Li <weili@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813351} TBR=weili@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I4683ac2a66b75c98da6adf20a80636fb6486aeef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448573 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#813619}

This create some issues in some tests, they fail with the following stack trace: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x56400bd836c9 base::debug::CollectStackTrace() #1 0x56400bcb90c3 base::debug::StackTrace::StackTrace() #2 0x56400b74b5e6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fdc5b8c84c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x564010b453b0 __llvm_profile_merge_from_buffer #5 0x564010b43705 writeFile #6 0x564010b43547 __llvm_profile_write_file #7 0x564010b43874 __llvm_profile_dump #8 0x56400bda6373 base::WriteClangProfilingProfile() #9 0x56400d8cb484 content::ChildProcess::~ChildProcess() #10 0x564010780118 content::RenderProcessImpl::~RenderProcessImpl() #11 0x564010688274 content::InProcessRendererThread::CleanUp() #12 0x56400bd6c2b8 base::Thread::ThreadMain() #13 0x56400bd9a8d9 base::(anonymous namespace)::ThreadFunc() #14 0x7fdc60fa16ba start_thread #15 0x7fdc5b99a4dd clone This call to base::WriteClangProfilingProfile has been recently[1] added to ChildProcess::~ChildProcess to ensure that the child utility processes properly flushed their profiling data at shutdown. This was an issue when running the PGO profiling scenarios as some child processes were terminated too aggressively and sometime didn't had a chance to fully write their profiling data. It doesn't seem to affect the coverage data (and this change brings the coverage build back to the state it was in before [1]). We should ideally also look at this crash and understand why it's happening, this CL really just prevent this crash from happening by not calling the problematic function when it's not needed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2378272 Bug: 1065485 Change-Id: I051ab0993216a887a38863070b554e02ba60bb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450332 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#813907}

Reason for reland: Original CL broke two classes of builders, and they have been fixed: 1. Third party projects, such as ANGLE, and the fix was landed in: https://chromium-review.googlesource.com/c/chromium/src/+/2427423 2. Code search builders, and the fix is in patchset #2. This CL is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/2416999. This CL supports also_build_ash_chrome arg to allow building ash-chrome in an alternate toolchain. A few other fixes are required to work, but they will be landed in separate CLs because they could affect existing builds, so landing them separately will make it easier to reason and detect potential breakages. Bug: 1129223 Change-Id: I5a29eef63a12a622d512f74d23098720aa9530aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425201 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#814429}

This reverts commit 333407c. Reason for revert: Re-landing with fixes. Specifically, this makes dependency_manager in catapult handle importing six directly, rather than relying on clients to do it. Also, this updates the .pydeps files to include six.py. Original change's description: > Revert "Roll catapult to 532e564 and update for changes in it." > > This reverts commit 9bdc5cc. > > Reason for revert: Reverting until I can fix the `import six` issues more cleanly. > > Original change's description: > > Roll catapult to 532e564 and update for changes in it. > > > > This CL rolls //third_party/catapult to > > 532e564f622742fc93a7f91dd3556d711e778a7e and picks up > > > > https://chromium-review.googlesource.com/c/catapult/+/2450450 > > > > which removes zipfile_2_7_13.py as a dependency. This CL > > also updates the corresponding Chromium .pydeps files that mentioned > > it. > > > > That change also added a dependency on `six`, which seems to be > > pervasively assumed in other parts of the catapult codebase as > > present in the environment; however, it isn't guaranteed to be > > there in the chromium compile-time python build, so this adds > > that as needed as well. > > > > TBR=bsheedy@chromium.org > > > > Bug: 1112471 > > Change-Id: I849355a5bdc18847dcbf39f3d3a9e9fbf428e3be > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449938 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#814062} > > TBR=dpranke@google.com,bsheedy@chromium.org,johnchen@chromium.org > > Change-Id: I8dc0ccc9819eb5cd7de6d9fab4ec9a23c485ca09 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112471, 1135502 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453150 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#814255} TBR=dpranke@google.com,bsheedy@chromium.org,johnchen@chromium.org, agrieve@chromium.org Bug: 1112471 Bug: 1135502 Change-Id: I20d0d0a876424aefded51772ad8dc088f1a9c158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453444 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#814499}

#1 Rather than assigning the atomic plane props and setting them on property_set, split the operation into 2 disctinct actions: 1. Assign the props into local properties pending to be committed. 2. Set the properties on the property_set. This means, to set the plane props, we assign the properties in SetPlaneData then SetPlaneProps on property_set right before we're about to atomically commit. (operations can happen at 2 different times) #2. Also. always set fence_fd even if the value is invalid as long as the prop ID is valid. BUG=1082882 TEST=planes are visible on displays. Change-Id: If12b15025e3fcabb72d26959a77c695f63a6388b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481523 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#818602}

1) Tests were failing on pie-rel bots because swarmed builds do not include API keys. I've updated the tests to set a flag to ignore these missing keys. 2) Tests were still flaking quite a bit due to batching and state not being cleared between runs. I've tried a couple things (enabling extensive clearing, opening new tabs and closing tabs after tests) but the only way I've been able to get them to run without flakes is by disabling batching. I'll need to dig into translate internals to determine what the right fix is here. 3) Tests were failing the network_service_out_of_process_chrome_public_test_apk phase because, while the network monitor _says_ it has a connection to the internet during these tests, tests run under this configuration will actually refuse to resolve any DNS requests. I've added early returns for when the network service is out of process, but longer term I've opened crbug/1134812 to track the removal of the internet dependency. Similar to #2 this will take digging into Translate internals to make them more testable. BUG=1141160 Change-Id: I4cac8deed71235c2e2da6a6a690edbbaed047b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461711 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by: Megan Jablonski <megjablon@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#819660}

This reverts commit 27e795c. Reason for revert: Sorry for another revert, but this is still causing flake. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9353 . Specifically: ../../content/public/test/browser_test_base.cc:702: Failure Failed RunLoop::Run() timed out. Stack trace: #0 0x56324b6c5e50 base::internal::Invoker<>::Run() #1 0x56324b623b4f base::(anonymous namespace)::OnRunLoopTimeout() #2 0x56324b6249e3 base::internal::Invoker<>::RunOnce() #3 0x5632492266ab base::internal::CancelableCallbackImpl<>::ForwardOnce<>() #4 0x56324b63bc46 base::TaskAnnotator::RunTask() #5 0x56324b64c845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #6 0x56324b64c588 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #7 0x56324b69fb29 base::MessagePumpLibevent::Run() #8 0x56324b64cf9a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #9 0x56324b62363e base::RunLoop::Run() #10 0x5632483f1f23 chromeos::EduCoexistenceLoginBrowserTest::WaitForScreenExit() #11 0x563248402206 chromeos::ParentalHandoffScreenBrowserTest_RegularUserLogin_Test::RunTestOnMainThread() #12 0x56324bae8dd1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #13 0x56324b6fff04 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #14 0x56324b6ff3b9 ChromeBrowserMainParts::PreMainMessageLoopRun() #15 0x563248bf574e chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #16 0x563249bdf3b0 content::BrowserMainLoop::PreMainMessageLoopRun() #17 0x563249f3668a content::StartupTaskRunner::RunAllTasksNow() #18 0x563249bde45b content::BrowserMainLoop::CreateStartupTasks() #19 0x563249be0bba content::BrowserMainRunnerImpl::Initialize() #20 0x563249bdcbd2 content::BrowserMain() #21 0x56324b198740 content::RunBrowserProcessMain() #22 0x56324b1995d1 content::ContentMainRunnerImpl::RunServiceManager() #23 0x56324b199234 content::ContentMainRunnerImpl::Run() #24 0x56324a5c8687 content::RunContentProcess() #25 0x56324a5c8c16 content::ContentMain() #26 0x56324bae8a00 content::BrowserTestBase::SetUp() #27 0x56324b5d8620 InProcessBrowserTest::SetUp() Original change's description: > Reland "Adds parental handoff login screen in oobe." > > This is a reland of dca1afe > > This is an interesting failure point due to the difference between > official builds and non official builds. In official builds, the > Sync Consent screen is shown and it will not exit until we interact > with it. The waiters timeout waiting for the Parental Handoff Screen > to be shown. > > Original change's description: > > > Adds parental handoff login screen in oobe. > > > > The description and mock can be seen in the comments in the bug report. > > > > Bug: 1134567 > > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 > > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > > Reviewed-by: Aga Wronska <agawronska@chromium.org> > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819158} > > Bug: 1134567 > Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820388} TBR=jwd@chromium.org,rsorokin@chromium.org,agawronska@chromium.org,yilkal@chromium.org Change-Id: I6febf7f06a0d5d7a072be1e50aaa9cc2a4d3c217 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495423 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820489}

…_chromium=true This reverts commit 85773e5. Reason for reland: * Fixed data deps * _BuildWithChromium() handles missing key Original change's description: > Revert "Reland "Android: Use locally-build devil deps only when build_with_chromium=true"" > > This reverts commit f8b7ec2. > > Reason for revert: Causing all builds to fail on android-pixel2-perf failing > > Original change's description: > > Reland "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > This reverts commit b47e9c8. > > > > Reason for reland: Updated more .pydeps files. > > > > Original change's description: > > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > > > This reverts commit 49fdeca. > > > > > > Reason for revert: Breaking presubmit due to stale .pydeps file: > > > android_webview/tools/run_cts.pydeps > > > > > > Original change's description: > > > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > > > > > Bug: 1120190 > > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#819489} > > > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1120190 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#819668} > > > > TBR=agrieve # reland > > > > Bug: 1120190 > > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819810} > > TBR=agrieve@chromium.org,bpastene@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1120190, 1141891 > Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820355} Bug: 1120190 Bug: 1141891 Change-Id: Ic7a398fcd8cb5f45a03c20acbd4e9c7300442f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497153 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823651}

…ild_with_chromium=true" This reverts commit 8e2b321. Reason for revert: Breaks angle_unittests on emulator Original change's description: > Reland #2: Android: Use locally-build devil deps only when build_with_chromium=true > > This reverts commit 85773e5. > > Reason for reland: > * Fixed data deps > * _BuildWithChromium() handles missing key > > Original change's description: > > Revert "Reland "Android: Use locally-build devil deps only when build_with_chromium=true"" > > > > This reverts commit f8b7ec2. > > > > Reason for revert: Causing all builds to fail on android-pixel2-perf failing > > > > Original change's description: > > > Reland "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > > > This reverts commit b47e9c8. > > > > > > Reason for reland: Updated more .pydeps files. > > > > > > Original change's description: > > > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > > > > > This reverts commit 49fdeca. > > > > > > > > Reason for revert: Breaking presubmit due to stale .pydeps file: > > > > android_webview/tools/run_cts.pydeps > > > > > > > > Original change's description: > > > > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > > > > > > > Bug: 1120190 > > > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#819489} > > > > > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > > > > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 1120190 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#819668} > > > > > > TBR=agrieve # reland > > > > > > Bug: 1120190 > > > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#819810} > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1120190, 1141891 > > Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335 > > Reviewed-by: John Chen <johnchen@chromium.org> > > Commit-Queue: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820355} > > Bug: 1120190 > Bug: 1141891 > Change-Id: Ic7a398fcd8cb5f45a03c20acbd4e9c7300442f38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497153 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823651} TBR=agrieve@chromium.org,bpastene@chromium.org Change-Id: Ia586b0d8f68795e493074ba6b00ac36c529eb1ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120190 Bug: 1145570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519425 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824002}

This reverts commit dde3def. Reason for revert: browser_tests on linux-lacros-tester-rel consistently fail after this landed in https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4381 Failures are: MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys MediaKeysListenerManagerImplTest.PressPlayPauseKey MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController They all crash: [ RUN ] MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys DevTools listening on ws://127.0.0.1:37255/devtools/browser/5be580d5-fcf2-46b2-8f43-033ac20657af [22277:22277:1109/134807.593313:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55ec232b31d9 base::debug::CollectStackTrace() #1 0x55ec2322bc63 base::debug::StackTrace::StackTrace() #2 0x55ec22e77786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f5f63b034c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x55ec20957235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x55ec22e76577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x55ec22f20fde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x55ec226b9896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x55ec22b09c33 content::StartupTaskRunner::RunAllTasksNow() #9 0x55ec226b8877 content::BrowserMainLoop::CreateStartupTasks() #10 0x55ec226bb278 content::BrowserMainRunnerImpl::Initialize() #11 0x55ec226b6f68 content::BrowserMain() #12 0x55ec218feeb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x55ec218feaa6 content::ContentMainRunnerImpl::Run() #14 0x55ec218fbf54 content::RunContentProcess() #15 0x55ec218fc8dc content::ContentMain() #16 0x55ec22e75f8c content::BrowserTestBase::SetUp() #17 0x55ec21670678 testing::Test::Run() #18 0x55ec2167150f testing::TestInfo::Run() #19 0x55ec21671ef7 testing::TestSuite::Run() #20 0x55ec2167f677 testing::internal::UnitTestImpl::RunAllTests() #21 0x55ec2167efdf testing::UnitTest::Run() #22 0x55ec22ebf284 base::TestSuite::Run() #23 0x55ec22e48027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x55ec22e9a871 content::LaunchTests() #25 0x55ec22e47fe0 main #26 0x7f5f63aee840 __libc_start_main #27 0x55ec1fce43ea _start [ RUN ] MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController DevTools listening on ws://127.0.0.1:37481/devtools/browser/4cec391a-3d7f-4854-bdcf-7c8abf8b0cbe BrowserTestBase received signal: Segmentation fault. Backtrace: [25621:25621:1109/134831.864948:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. #0 0x5636f5a041d9 base::debug::CollectStackTrace() #1 0x5636f597cc63 base::debug::StackTrace::StackTrace() #2 0x5636f55c8786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fbfcb8e44c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5636f30a8235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x5636f55c7577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x5636f5671fde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x5636f4e0a896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x5636f525ac33 content::StartupTaskRunner::RunAllTasksNow() #9 0x5636f4e09877 content::BrowserMainLoop::CreateStartupTasks() #10 0x5636f4e0c278 content::BrowserMainRunnerImpl::Initialize() #11 0x5636f4e07f68 content::BrowserMain() #12 0x5636f404feb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x5636f404faa6 content::ContentMainRunnerImpl::Run() #14 0x5636f404cf54 content::RunContentProcess() #15 0x5636f404d8dc content::ContentMain() #16 0x5636f55c6f8c content::BrowserTestBase::SetUp() #17 0x5636f3dc1678 testing::Test::Run() #18 0x5636f3dc250f testing::TestInfo::Run() #19 0x5636f3dc2ef7 testing::TestSuite::Run() #20 0x5636f3dd0677 testing::internal::UnitTestImpl::RunAllTests() #21 0x5636f3dcffdf testing::UnitTest::Run() #22 0x5636f5610284 base::TestSuite::Run() #23 0x5636f5599027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x5636f55eb871 content::LaunchTests() #25 0x5636f5598fe0 main #26 0x7fbfcb8cf840 __libc_start_main #27 0x5636f24353ea _start [ RUN ] MediaKeysListenerManagerImplTest.PressPlayPauseKey DevTools listening on ws://127.0.0.1:36939/devtools/browser/4a443d13-30b6-430d-a4b3-503ecbbdc73e [4137:4137:1109/134809.976176:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x5647f92c11d9 base::debug::CollectStackTrace() #1 0x5647f9239c63 base::debug::StackTrace::StackTrace() #2 0x5647f8e85786 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f6dac3524c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x5647f6965235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread() #5 0x5647f8e84577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x5647f8f2efde content::ShellBrowserMainParts::PreMainMessageLoopRun() #7 0x5647f86c7896 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x5647f8b17c33 content::StartupTaskRunner::RunAllTasksNow() #9 0x5647f86c6877 content::BrowserMainLoop::CreateStartupTasks() #10 0x5647f86c9278 content::BrowserMainRunnerImpl::Initialize() #11 0x5647f86c4f68 content::BrowserMain() #12 0x5647f790ceb3 content::ContentMainRunnerImpl::RunServiceManager() #13 0x5647f790caa6 content::ContentMainRunnerImpl::Run() #14 0x5647f7909f54 content::RunContentProcess() #15 0x5647f790a8dc content::ContentMain() #16 0x5647f8e83f8c content::BrowserTestBase::SetUp() #17 0x5647f767e678 testing::Test::Run() #18 0x5647f767f50f testing::TestInfo::Run() #19 0x5647f767fef7 testing::TestSuite::Run() #20 0x5647f768d677 testing::internal::UnitTestImpl::RunAllTests() #21 0x5647f768cfdf testing::UnitTest::Run() #22 0x5647f8ecd284 base::TestSuite::Run() #23 0x5647f8e56027 content::ContentTestLauncherDelegate::RunTestSuite() #24 0x5647f8ea8871 content::LaunchTests() #25 0x5647f8e55fe0 main #26 0x7f6dac33d840 __libc_start_main #27 0x5647f5cf23ea _start Original change's description: > Reland "[Media Session] Fix for Lacros" > > This is a reland of ddb531f > > There is a fix in media_session_service.cc to allow the tests to pass > when ash-chrome is not running. > > Original change's description: > > [Media Session] Fix for Lacros > > > > At the moment in Lacros there are two instances of the > > Media Session Service (MSS) one hosted in ash-chrome and > > the other in lacros-chrome. This means that sessions in > > either browser process cannot see sessions from the other. > > > > This changes it so when a client asks for lacros-chrome > > MSS instead of providing a locally hosted MSS it binds > > the MSS in ash-chrome. > > > > BUG=1140215 > > > > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825016} > > Bug: 1140215 > Change-Id: I64834d9be778998b42bf3447444a6955265215ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825439} TBR=avi@chromium.org,dcheng@chromium.org,erikchen@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I284aea77c32a39c8641df70d83baa5b2e09b8641 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528306 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825549}

https://skia.googlesource.com/skia.git/+log/008d63e23dab..1fe2b80dc782 2020-11-10 michaelludwig@google.com Revert "Reland "Draw image filters directly under non-axis-aligned transforms"" 2020-11-10 reed@google.com Recompute the last-move-to inside addPath() 2020-11-10 tdenniston@google.com [svg] Use new parsing for gradient classes 2020-11-10 michaelludwig@google.com Reland "Draw image filters directly under non-axis-aligned transforms" 2020-11-10 robertphillips@google.com Fix UMR (valgrind) bug in GrDrawingManager 2020-11-10 mtklein@google.com use SkFourByteTag to squelch warnings 2020-11-10 johnstiles@google.com Fix flipped array dimensions in SkSL. 2020-11-10 robertphillips@google.com Disable both preservefillrule _big and _little for the *ooprddl configs 2020-11-10 herb@google.com cull glyphs that have far out positions - try #2 2020-11-10 johnstiles@google.com Limit struct nesting depth to a maximum of eight levels. 2020-11-10 johnstiles@google.com Limit arrays to a maximum of eight dimensions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1134474 Tbr: jlavrova@google.com Change-Id: I49341ea87d3e31da8e91d8b03f7328b963198677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530247 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826081}

Context: Currently, "waitForUpdatedPaymentDetails" is used in the payment codebase to mean two things: (1) an action: whether show() should be blocked from showing the payment details until the merchant passes in the payment details with show()'s PaymentDetailsUpdate promise. (2) a state: whether the payment details is now pending for update - once the details is received, the state is reset to false. These two meanings makes it ambiguous for code readers. To clarify it, this CL create mIsShowWaitingForUpdatedPaymentDetails to make it clear when it represents a state (meaning #2). Also, "isShow" makes it easier to read when this variable appears out of the scope of show(), e.g., in PaymentUiService for example. This CL also renames initializeWithUpdatedDetails() as continueShow() to make the control logic explicit. Changes: * Renamed some waitForUpdatedPaymentDetails as isShowWaitingForUpdatedPaymentDetails when it means a state. * Renamed initializeWithUpdatedDetails as continueShow. * Documents about show()'s PaymentDetailsUpdate promise in updateWith(). Bug: 1131059 Change-Id: I6c6b99ce5149c22fc6d7d4327e1eae0dacd10e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529618 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826313}

Appears to be causing shard #2 to timeout consistently. Bug: 1147992 Change-Id: I3e680dc18499c261b013f8b2cb04911e7eee5daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533202 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826880}

Wowfunhappy · 2020-11-13T19:17:13Z

I don't really know how any of this code works, so this could be completely wrong. But I was looking at the set of changes you made to Skia for Lion and Mountain Lion.

It looks like you added some code which will specifically only run on Lion and Mountain Lion machines. https://github.com/blueboxd/skia/blob/6fdecbea70f1be7800a70c06734bdf54d41fec4b/src/ports/SkScalerContext_mac_ct.cpp#L423

(N.B. The isLion() / isMountainLion() functions are defined up here: https://github.com/blueboxd/skia/blob/6fdecbea70f1be7800a70c06734bdf54d41fec4b/src/ports/SkScalerContext_mac_ct.cpp#L112)

According to comments, this was done to work around a bug in CTFontGetBoundingRectsForGlyphs, which on 10.7/8 return a bad value for fonts "whose hhea::numberOfHMetrics is less than its maxp::numGlyphs."

If the bug is also present on Mavericks, perhaps this workaround just needs to be enabled there too! (Or, if this comes from old Google code, perhaps there's a similar Mavericks code path.) Notably, these seem to more-or-less align with the crash log, which is crashing on GetNumberOfGlyphs.

^{I would experiment myself if I could get Chromium to compile...}

blueboxd · 2020-11-13T20:47:52Z

Thank you very much for your cooperation for the analysis.

Yes, I ported the patch for Lion/Mountain Lion from the old Skia library, but the problem resolved by that patch is not a crashing issue. (Chromium still launching on 10.7/10.8 even without a patch...)
And 10.9 doesn't have that bug.

I looked into Skia sources for the latest version for 10.9(m65), but the code path to the crashed function and the parameter seems almost the same.
And I'm tracing debug build of the latest Chromium on 10.9, but still no hint is appeared for now.
Skia is seemed to call CoreText (CTFontDescriptorCopyAttribute or so) as normal, maybe same as version of m65.
So, the problem is the caller of skia library function... or wrong initialization?

I'll continue to investigate, so please wait for a while.
Sorry for the inconvenience.

^{Compiling patched Chromium for non-supported OSes is a bit tricky (need extra patches for compilation not committed to this repository), and Chromium compilation is super CPU-time consuming work (~40min with 14-core Xeon and two Ryzen 3950x machines), so I don't recommend to try...}

Wowfunhappy · 2020-11-13T21:02:43Z

Oh don't apologize, I'm just delighted you're maintaining this! Sorry that investigation wasn't helpful.

PartitionDirectMap and AllocNewSlotSpan have been reporting things inconsistently. After this CL, the metrics will have the following (consistent) meaning: 1. total_size_of_super_pages - total virtual address space for normal bucket super pages 2. total_size_of_direct_mapped_pages - total virtual address space for direct map regions 3. total_size_of_committed_pages - total committed pages for slots (doesn't include metadata, bitmaps, or any data outside or regions described in #1 and #2) Change-Id: I1ac1b3044d15b33dcbd506f133d1fe7fa322277f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532542 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827564}

This reverts commit f771327. Reason for revert: The added browser tests appear to be (flakily) crashing on various builders: For example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95504 with https://chromium-swarm.appspot.com/task?id=4fef1ab263264c10 [1303/1306] StartupBrowserWithWebAppTest.PRE_PRE_LastUsedProfilesWithWebApp (1571 ms) [ RUN ] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp [11419:11462:1117/050706.931735:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.931814:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [11419:11462:1117/050706.932083:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.932300:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x558aecd46cd9 base::debug::CollectStackTrace() #1 0x558aeccb6753 base::debug::StackTrace::StackTrace() #2 0x558aed26b5f6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f26cd1224c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x558ae929f9a0 StartupBrowserWithWebAppTest_PRE_LastUsedProfilesWithWebApp_Test::RunTestOnMainThread() #5 0x558aed26a407 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x558aecde10ef ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #7 0x558aecddfed5 ChromeBrowserMainParts::PreMainMessageLoopRun() #8 0x558aeb16da36 content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x558aeb5c3b13 content::StartupTaskRunner::RunAllTasksNow() #10 0x558aeb16ca17 content::BrowserMainLoop::CreateStartupTasks() #11 0x558aeb16f638 content::BrowserMainRunnerImpl::Initialize() #12 0x558aeb16af68 content::BrowserMain() #13 0x558aebc439c3 content::ContentMainRunnerImpl::RunServiceManager() #14 0x558aebc435b6 content::ContentMainRunnerImpl::Run() #15 0x558aebc40a64 content::RunContentProcess() #16 0x558aebc413ec content::ContentMain() #17 0x558aed269f34 content::BrowserTestBase::SetUp() #18 0x558aecca3c51 InProcessBrowserTest::SetUp() #19 0x558aea228198 testing::Test::Run() #20 0x558aea22902f testing::TestInfo::Run() #21 0x558aea229a07 testing::TestSuite::Run() #22 0x558aea237207 testing::internal::UnitTestImpl::RunAllTests() #23 0x558aea236b6f testing::UnitTest::Run() #24 0x558aecd97f74 base::TestSuite::Run() #25 0x558aecc8d252 ChromeTestSuiteRunner::RunTestSuite() #26 0x558aed299357 content::LaunchTests() #27 0x558aecc8d522 LaunchChromeTests() #28 0x558aecc8ac54 main #29 0x7f26cd10d840 __libc_start_main #30 0x558ae864e0aa _start [1304/1306] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp (CRASHED) Similar crash also on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110376 (https://chromium-swarm.appspot.com/task?id=4feff52dc4172910) Original change's description: > Fix session restore after launching with PWA. > > The underlying issue is that the kProfilesLastActive pref gets > cleared when Chrome is launched with a specific profile, which > prevents Chrome from iterating over the last active profiles > and calling session restore on each of them. This CL stops > clearing the pref when launched with --app-id, and avoids > restoring sessions for the last active profiles > if launched with --app-id. Also, ignore browser opens and > closes if the browser window is for a web app, in order to prevent > kProfilesLastActive pref from getting overwritten. > > Bug: 1022795 > Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710 > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827876} TBR=droger@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Change-Id: Ib48b40d1c39911d9c5b1072fda35703a70be1f5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544744 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828247}

Per #2 from the linked bug, this could also be related to crbug.com/1138060. TBR=bsheedy@chromium.org Bug: 1149237 Change-Id: I753dfe6f364f93d9dd01314357cbb6ee8c67924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557906 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830585}

This reverts commit d4c88d4. Reason for reland: Fixed in 9ab29d6 Original change's description: > Revert "Reland "Android: Enable use_debug_fission for official builds"" > > This reverts commit 30f14e9. > > Reason for revert: official bot breaking > https://bugs.chromium.org/p/chromium/issues/detail?id=1144538#c8 > > Original change's description: > > Reland "Android: Enable use_debug_fission for official builds" > > > > This reverts commit 86befdd. > > > > Reason for reland: Bugs fixed in other CLs (see issue) > > > > Original change's description: > > > Revert "Android: Enable use_debug_fission for official builds" > > > > > > This reverts commit 9d3a461. > > > > > > Reason for revert: Official builds failing crbug.com/1144538 > > > > > > Original change's description: > > > > Android: Enable use_debug_fission for official builds > > > > > > > > Bug: 1122182 > > > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#822625} > > > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1122182,1144538 > > > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > > > Commit-Queue: Krishna Govind <govind@chromium.org> > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#823080} > > > > Bug: 1122182 > > Bug: 1144538 > > Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827946} > > TBR=agrieve@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1122182 > Bug: 1144538 > Change-Id: Iccd274ff85e12710206105c713a2f3dbc260f1a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558781 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830755} TBR=agrieve@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122182 Bug: 1144538 Change-Id: If770c3864f5c9bf6e90a25bd1985d358d42f2b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560912 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831414}

This reverts commit 56e6897. Reason for revert: Flake information no longer on the flake dashboard, need to re-enable to see what was actually going wrong. Original change's description: > Disable flaky test testSymbolizedMinidump on Android > > Per #2 from the linked bug, this could also be related to crbug.com/1138060. > > TBR=bsheedy@chromium.org > Bug: 1149237 > > Change-Id: I753dfe6f364f93d9dd01314357cbb6ee8c67924d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557906 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830585} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1149237 Change-Id: I0ec4a00efb6516988fb5264f469c550340eea426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564767 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#832430}

... until the respective XDG surface is initialized. The current call to WaylandToplevelWindow::InitializeAuraShell() is not effective on Exo. Basically, this method was being called prior to the respective XDG surface got properly initialized on Exo. Problem: 1) Lacros calls aura_surface_set_fullscreen_mode(), and Exo should processes the call like below: #1 exo::ShellSurfaceBase::SetUseImmersiveForFullscreen() #2 exo::Surface::SetUseImmersiveForFullscreen() #3 exo::wayland::AuraSurface::SetFullscreenMode() #4 exo::wayland::(anonymous namespace)::aura_surface_set_fullscreen_mode() 2) However, on frame #2, |exo::Surface::delegate_| was still NIL, and the call got bailed out. 3) |exo::Surface::delegate_| only gets assigned when Exo processes the call to xdg_wm_base_get_xdg_surface(), from the client side. #1 0x5563f0dbb100 exo::Surface::SetSurfaceDelegate() #2 0x5563f0dc1e33 exo::SurfaceTreeHost::SetRootSurface() #3 0x5563f0e02a23 exo::ShellSurfaceBase::ShellSurfaceBase() #4 0x5563f0dfdc65 exo::ShellSurface::ShellSurface() #5 0x5563f0e0f47f exo::XdgShellSurface::XdgShellSurface() #6 0x5563f0d95561 exo::Display::CreateXdgShellSurface() #7 0x5563ecbed19a exo::wayland::(anonymous namespace)::xdg_wm_base_get_xdg_surface() CL fixes this by making the call to InitializeAuraShell() only take place once the respective XDGSurface is initialized. This is a fixup! of https://crrev.com/c/2353116. BUG=1113900 R=msisov@igalia.com Change-Id: I4169d30545238abf2ad46eaef9677a846d58c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566346 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#832825}

On newer systems (Ubuntu 18.04 and gLinux), the default user config in ~/.pki/nssdb/pkcs11.txt contains: library=/usr/lib/x86_64-linux-gnu/nss/libnssckbi.so library=/usr/lib/x86_64-linux-gnu/onepin-opensc-pkcs11.so While the instrumented libraries have instrumented versions of these, NSS will dlopen() the libraries specified in the user config by absolute pathname. Mixing this MSAN and non-MSAN code leads to a crash: Uninitialized bytes in __interceptor_strcasecmp at offset 0 inside [0x7010000b99a0, 4) ==3981110==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f84ad162eb1 in scconf_find_blocks (/lib/x86_64-linux-gnu/libopensc.so.8+0x162eb1) (BuildId: 4de1f962c7a7a52686a1c7baa36e97f4b2c6508e) #1 0x7f84ad021b4c in sc_context_create (/lib/x86_64-linux-gnu/libopensc.so.8+0x21b4c) (BuildId: 4de1f962c7a7a52686a1c7baa36e97f4b2c6508e) #2 0x7f84ad8e152b in C_Initialize (/usr/lib/x86_64-linux-gnu/onepin-opensc-pkcs11.so+0xd52b) (BuildId: 54feb2432ce37108157601eefdf786df9d11236b) #3 0x7f85946aba8b in secmod_ModuleInit /home/dev/chromium_official/src/out/Instrumented-msan-chained-origins/gen/third_party/instrumented_libraries/focal/nss/nss-3.49.1/nss/lib/pk11wrap/pk11load.c:244:11 To workaround this, initialize NSS without cert DBs. Bug: 1260217 Change-Id: Iabccaf741d92c5a9bd8f9453bd57eeb7983494bd Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng,linux_chromium_msan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3991395 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#1067387}

This class removes the friend classes of ProfileDestroyer as they were calling internal methods that bypassed the creation of ProfileDestroyer objects and called DestroyOffTheRecordProfileNow directly, which has led to crashes in the past (https://crbug.com/1337388#c11). Note: This CL changes the behavior of ProfileDestroyer when destroying an off-the-record profile immediately via ProfileDestroyer::DestroyOTRProfileImmediately(). With the new implementation, the CHECK in ~ProfileDestroyer() will trigger and we may see an increase of crashes with this signature. Before this CL, the app will still crash, but in a different code location (see test), with the stack trace below: [456919:456919:FATAL:dependency_manager.cc(173)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again. #0 0x7fe99bc08932 base::debug::CollectStackTrace() #1 0x7fe99bb348a3 base::debug::StackTrace::StackTrace() #2 0x7fe99bb4fff3 logging::LogMessage::~LogMessage() #3 0x7fe99bb50e9e logging::LogMessage::~LogMessage() #4 0x7fe9992b7396 DependencyManager::AssertContextWasntDestroyed() #5 0x7fe996fe7e32 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x7fe9992b79af KeyedServiceFactory::GetServiceForContext() #7 0x55c217195682 extensions::ChromeContentBrowserClientExtensionsPart::SiteInstanceDeleting() #8 0x55c2162f1f9d ChromeContentBrowserClient::SiteInstanceDeleting() #9 0x7fe99a5bc5af content::SiteInstanceImpl::~SiteInstanceImpl() #10 0x7fe99a5bc6de content::SiteInstanceImpl::~SiteInstanceImpl() #11 0x55c21327864f ProfileDestroyerTest::~ProfileDestroyerTest() Bug: 1378254 Change-Id: Ib144ffe8d2344dc7efc7cd22360e8fce0b2beb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3978432 Reviewed-by: Alex Ilin <alexilin@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/main@{#1067599}

This CL fixes the below MSAN error. This issue is not triggered on the bots because they run on an older release of Ubuntu (Xenial) which lacks loadable vulkan modules (eg libvulkan_radeon.so and libvulkan_intel.so) which are present on newer systems like Ubuntu Focal and gLinux. The system modules cause the error because they are not instrumented with MSAN. Uninitialized bytes in __interceptor_strcmp at offset 0 inside [0x7fffffffa380, 8) [Detaching after fork from child process 2199490] #0 0x7fffee94014c in wsi_unsupported_instance_extension wsi.c #1 0x7fffee8c15f0 in loader_add_instance_extensions loader.c #2 0x7fffee8c0c77 in loader_get_icd_loader_instance_extensions third_party/vulkan-deps/vulkan-loader/src/loader/loader.c:1116:15 #3 0x7fffee8fbe2c in vkCreateInstance third_party/vulkan-deps/vulkan-loader/src/loader/trampoline.c:556:11 ... Change-Id: I2cfbd9404a0d31032b1c9b62929215eaf6b4ca26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4007275 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1068202}

This change fixes an issue where Dictation was not capitalizing committed text in an empty gmail compose field. The committed text also had a space erroneously prepended to it. There are two problems addressed in this change: 1. Dictation had a stale IME surroundingInfo object 2. Dictation wasn't capitalizing committed text if the current editable value was \n. This change addresses #1 by resetting surroundingInfo when Dictation toggles off to ensure that we don't carry stale surroundingInfo in between toggles. It addresses #2 by considering the \n case when performing capitalization logic. on empty gmail compose fields. AX-Relnotes: Fixes a Dictation capitalization and spacing issue Bug: 1382066 Change-Id: I1ef44d6387959c751de3776a109186aa980de851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4008786 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1069249}

…ose field" This reverts commit e40d082. Reason for revert: Suspect of causing Dictation browser test failures: crbug.com/1382944 Original change's description: > Dictation: Fix capitalization and spacing in empty gmail compose field > > This change fixes an issue where Dictation was not capitalizing > committed text in an empty gmail compose field. The committed text also > had a space erroneously prepended to it. > > There are two problems addressed in this change: > 1. Dictation had a stale IME surroundingInfo object > 2. Dictation wasn't capitalizing committed text if the current > editable value was \n. > > This change addresses #1 by resetting surroundingInfo when Dictation > toggles off to ensure that we don't carry stale surroundingInfo in > between toggles. It addresses #2 by considering the \n case when performing capitalization logic. > > on empty gmail compose fields. > > AX-Relnotes: Fixes a Dictation capitalization and spacing issue > Bug: 1382066 > Change-Id: I1ef44d6387959c751de3776a109186aa980de851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4008786 > Commit-Queue: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1069249} Bug: 1382066, 1382944 Change-Id: I5a67ef0116973d3b4afbde6395793727d5a5a04a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4019172 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1069428}

NOTE: This is attempt #2 to land this. The earlier CL (https://crrev.com/c/3988262) enabled RichAutocompletionAdditionalTextWithParenthesis since that's what's being launched via server-side config. But we want that to remain default disabled. The disabled state is the preferred UI long-term. The launch will be with parens through M108. I'll merge this to M109 and then when the launch config no longer controls the state, the no-parens state will roll out naturally with M109. V8 looked good and we're going for a 100% launch next. https://docs.google.com/document/d/1cotvA981Xoq4rRJw0ZKP5vgu5qG3rk1WjtXX-yYzaaE As a precursor to the 100% finch launch, this CL enables the config by default. Enables 2 features: - OmniboxRichAutocompletion - OmniboxShortcutExpanding Updates 4 params: - RichAutocompletionAutocompleteTitlesShortcutProvider: false -> true - RichAutocompletionAutocompleteTitlesMinChar: 0 -> 3 - RichAutocompletionAutocompleteShortcutText: false -> true - RichAutocompletionAutocompleteShortcutTextMinChar: 0 -> 3 Desktop only, mobile remains disabled. We'll run mobile experiments before enabling on mobile. Bug: 1383547 Change-Id: I91574a3686cef7b2bee668e6de514969bfe482e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4023398 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/main@{#1070479}

https://chromium.googlesource.com/v8/v8.git/+log/18865d6af040..3155b0d10c05 2022-12-01 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 10.8.168.21 2022-12-01 verwaest@chromium.org Merged: [parser] Fix eval tracking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-release-1 Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in v8 10.8: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m108: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1394403 Tbr: v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a167b3a29b1e6fa6e664b184aa7b2b760d620fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4072344 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5359_71@{#2} Cr-Branched-From: 1e0e386-refs/branch-heads/5359@{#1016} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}

…ols\unit\soft-context-menu.js This is the 1st of 3 CLs to update DevTools soft context default focus behavior: CL #1: disable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (current CL) CL #2: update DevTools soft context menu default focus behavior in chromium.devtools-frontend repo (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4066166). CL #3: update and re-enable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (https://chromium-review.googlesource.com/c/chromium/src/+/4071205). Bug: 1394898 Change-Id: Ic488a0c24efdc239938868c82b3756a2330910b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066995 Commit-Queue: Guangyue Xu <guangyue.xu@microsoft.com> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1078471}

The new interface conveys ICE controller events with blink data types that mirror the relevant webrtc native data structures, but appropriate to expose to JS and compatible with thread hops. Bug: 1369096, webrtc:14131 Change-Id: Ibf2171e28c9d5766228481a02c429fc6101c939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4065681 Commit-Queue: Sameer Vijaykar <samvi@google.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1078499}

update test results for third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js This is the 3rd of 3 CLs to update DevTools soft context default focus behavior: CL #1: disable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (https://chromium-review.googlesource.com/c/chromium/src/+/4066995) CL #2: update DevTools soft context menu default focus behavior in chromium.devtools-frontend repo (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4066166). CL #3: update and re-enable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (current CL). Bug: 1394898 Change-Id: If311f9d71c5575a84e75533ed25ae88309a8b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4071205 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Guangyue Xu <guangyue.xu@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1078661}

Change-Id: I8a4ed8c2e87029e04d8f51c73e5131cd916b3d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4111283 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5481@{#2} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

This CL makes both the installer and updater fail when run on an unsupported version of Windows, versions < Win10. (cherry picked from commit 9c677bc) Bug: 1385856 Change-Id: I0f5e4f28c313b18189f4f0f271087430a0c09892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134008 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: S Ganesh <ganesh@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1089317} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240558 Reviewed-by: Srinivas Sista <srinivassista@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5481_77@{#2} Cr-Branched-From: 65ed616-refs/branch-heads/5481@{#839} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

Change-Id: I4f1fc606f285976889a506ab49055b0d0371903d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4284797 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1109369}

This will be used to display cookies' partition key in the Response Cookies table in the DevTools Network panel frontend. The response cookies are built from parsing the Set-Cookie header in the site's response. Since Chrome, not the site's HTTP header, determines what the partition key is, we need to provide that table with the partition key. We can do so using the RequestWillBeSentExtraInfo interface which we already use to indicate when the site has cookies in another partition. (cherry picked from commit 3477a57) Bug: 1383233 Change-Id: I05923227866f3193a841d8b047cacedb710ecfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188582 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1097679} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4199419 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{#2} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

Change-Id: I08316d1cf8dbbbeb831573e1f8db4e1baf396a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4290647 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{#2} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

The stable release branch does not include the changes which make use of the new LoadPaperPrintableAreaUm() call. Without those this branch only incurs the overhead of the calls, which for some printer drivers becomes quite substantial. This is a partial revert of crrev.com/1099645, since there is no intention to pull the rest of that printing CL chain into stable at this time. This is done instead of a regular revert because there are several subsequent CLs that would also need to be reverted just to get back to the CL which has this expensive call. (cherry picked from commit c47658f) Bug: 1424368 Change-Id: I977f983d30191989a9c7aaa7a9e04ca786106d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412898 Reviewed-by: Andy Phan <andyphan@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/5615@{#1212} Cr-Original-Branched-From: 9c6408e-refs/heads/main@{#1109224} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424091 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5615_51@{#2} Cr-Branched-From: 86d49da-refs/branch-heads/5615@{#938} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

Change-Id: I6d0d67459cce8220b898e1f70f496506122e43ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368319 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672@{#2} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

…reation" This reverts commit 953f07e. Reason for revert: Introduces bug when feature flag is disabled Original change's description: > Fix: Set primary account after sign in interception profile creation > > After a new profile is created via sign in interception, we set the > primary account of that profile to the intercepted profile. This > was not done before and we relied on the SigninManager to do so. This > was problematic because the profile would not allow changing the > primary account even if it was empty because the management bit was > already set by then. > By setting the primary account before setting the management bit, we > ensure the profile ends up managed with a proper primary account. > > > > (cherry picked from commit c9a30ee) > > Bug: 1369982, b/274676801 > Change-Id: I2dd9689f671654565a5a1d81cd0e8c4ab06ec18c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4444007 > Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Yann Dago <ydago@chromium.org> > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Monica Basta <msalama@chromium.org> > Cr-Original-Commit-Position: refs/heads/main@{#1133806} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4475766 > Commit-Queue: Srinivas Sista <srinivassista@chromium.org> > Owners-Override: Srinivas Sista <srinivassista@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/branch-heads/5672@{#905} > Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455} Bug: 1369982, b/274676801 Change-Id: If978e63affd2bc4804c87728da314712150a65b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503934 Reviewed-by: Srinivas Sista <srinivassista@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5672_63@{#2} Cr-Branched-From: 0e1a447-refs/branch-heads/5672@{#912} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

Change-Id: I456f30d423e32f0d653ec452db003ba7c0261c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4478909 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#2} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

https://chromium.googlesource.com/v8/v8.git/+log/68903e142b1a..5e7531112fa5 2023-06-01 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.4.183.18 2023-06-01 ishell@chromium.org Merged: [lookup] Robustify LookupIterator against own lookups If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-11-4-chromium-m114 Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in v8 11.4: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m114: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md (cherry picked from commit 04b6b88) Bug: chromium:1447430 Tbr: v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4733a2128cbe09cda2211d34515766ff180c1d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4579288 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5735@{#1149} Cr-Original-Branched-From: 2f562e4-refs/heads/main@{#1135570} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584457 Owners-Override: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Srinivas Sista <srinivassista@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5735_90@{#2} Cr-Branched-From: 386bc09-refs/branch-heads/5735@{#1052} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

This CL fixes 2 sources of flakiness: Source #1: Ignoring events immediately after autofill popup is shown in AutofillPopupControllerImpl::AcceptSuggestion() Source #2: Flakiness in sending touch too early after showing popup. I didn't find the exact source but calling ListView#performItemClick() directly seems to eliminate it. BUG=1075791,1030559,1108241 Change-Id: Ia8a256108ac63761c6238e9fa246f00b20d54ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583531 Reviewed-by: Christoph Schwering <schwering@google.com> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1155089}

This CL fixes an issue where some HostStatusObservers were not receiving OnClientDisconnected events when an It2Me session was terminated. The root cause is that the It2MeHost registers itself as a HostStatusObserver and is the first in a chain of observers. When the P2P connection is terminated, there are two codepaths: 1.) It2MeHost unregisters itself as an observer and then deletes the ChromotingHost object 2.) The ChromotingHost notifies observers that the client disconnected Everything works fine in scenario #1 however for #2, the It2MeHost receives the OnClientDisconnected notification and then deletes the ChromotingHost which also causes the destruction of the other observers. This is a no-no per the contract in host_status_observer.h as the events are meant to be informational only. I read that as the receiver of the event can take an asynchronous action but can't tear things down while it is handling the event. Thus this CL posts the 'DisconnectOnNetworkThread' call so that tearing the ChromotingHost occurs outside of the observer notification loop and all observers now get a chance to handle the event. Bug: b:269343716 Change-Id: I0adeb29369eb7cac40a127992d6d7c9b698357f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602512 Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/main@{#1155217}

Change-Id: I928a7df319ce8820b3572e3730d01ba537071612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685156 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790_90@{#2} Cr-Branched-From: 86fb9d0-refs/branch-heads/5790@{#1583} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

Cherry-picked from crrev.com/c/4771880, with merge conflicts fixed. In late June the source indexing step on Windows builds went from taking about 15 minutes to taking several hours. This is because a rust toolchain directory was added and its files are not mapped in as a git repo. Therefore every one of these files that was referenced in the source information had "git log" run on it, and this command is slow, especially on non-existent files. Source indexing of chrome.dll went from 45 seconds to 4,500 s - 100x slower. Source indexing of gaia1_0.dll was similarly slowed. Nothing else seemed to be affected. The output and C++ toolchain directories are already excluded from source indexing because of this issue, so all we need to do is add another excluded directory. This time I'm adding a --excluded-dirs switch to make it generic and more obvious. I'm also making other changes: 1) The toolchain and output directories used to have to be specified as absolute paths. Passing a relative path would make the script take hours longer. The script should make them absolute, and should fail if the specified directory does not exist. 2) The lack of an encoding passed to subprocess was causing various decode exceptions that presumably caused information to be lost, and also cluttered the output. 3) Some Python 2/3 compatibility hacks can now be removed. 4) Since calling git log when a file doesn't exist is expensive this change adds a message whenever this happens. In my tests this message is never hit. If it starts showing up thousands of times then the cause of the slowdown will be obvious next time. While this CL does make this script handle relative paths, and does fix encoding exceptions, it does not by itself fix the performance issue. For that a change in how this script is called will be needed, after this CL lands. Test commands: #1: reproduce the problem and make sure no exclusion-dirs is handled: vpython3 tools/symsrc/source_index.py out\official_test\chrome.dll.pdb --build-dir=out\official_test --toolchain-dir=third_party\depot_tools\win_toolchain\vs_files\27370823e7 #2: use exclusion-dirs to get a 100x speedup: vpython3 tools/symsrc/source_index.py out\official_test\chrome.dll.pdb --build-dir=out\official_test --toolchain-dir=third_party\depot_tools\win_toolchain\vs_files\27370823e7 --exclusion-dirs=third_party\rust-toolchain #3: use exclusion-dirs with semi-colon separation to replace using --build-dir (still fast): vpython3 tools/symsrc/source_index.py out\official_test\chrome.dll.pdb --toolchain-dir=third_party\depot_tools\win_toolchain\vs_files\27370823e7 --exclusion-dirs=third_party\rust-toolchain;out\official_test A clean copy of chrome.dll.pdb is needed for each test. The freshly built DLL was copied elsewhere and then copied back before each test. See README.chromium for more testing ideas. (cherry picked from commit 139fc68) Bug: 1471723 Change-Id: I9d28a44ba2bed9d52258c42961e14ddf432ac4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4771880 Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1182418} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4794968 Reviewed-by: Xinan Lin <linxinan@chromium.org> Cr-Commit-Position: refs/branch-heads/5938@{#286} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

…tect inserting / updating CVCs behind a finch feature flag. CL #1 to merge: Use kAutofillEnableCvcStorageAndFilling in AddCreditCard and UpdateCreditCard for CVC Bug: 1478412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4828620 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Jiali Huang <jialihuang@google.com> Reviewed-by: Vinny Persky <vinnypersky@google.com> Reviewed-by: Florian Leimgruber <fleimgruber@google.com> Reviewed-by: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/main@{#1191535} (cherry picked from commit 157a0a0) CL #2 to merge: Insert CVC if it doesn't exist, and update CVC if it exists Problem: User have a existing card without CVC, then user update the card with a first CVC, Chrome will crash. Cause: When user update a credit card with or without new CVC, UpdateCreditCard function will be called and UpdateBuilder kLocalStoredCvcTable will be triggered. Since kLocalStoredCvcTable is empty because user never trigger InsertBuilder kLocalStoredCvcTable, triggering UpdateBuilder kLocalStoredCvcTable will make chrome crash. (cherry picked from commit d740199) Bug: 1478910 Change-Id: Ia2d5c2004ea8502e1b4c3775cc84d727d4937dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4781872 Reviewed-by: Florian Leimgruber <fleimgruber@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Sujie Zhu <sujiezhu@google.com> Reviewed-by: Siyu An <siyua@chromium.org> Commit-Queue: Jiali Huang <jialihuang@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1184881} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4843534 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Vinny Persky <vinnypersky@google.com> Cr-Commit-Position: refs/branch-heads/5938@{#1028} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Case #1: getComputedName/Role should update the tree via the normal process, and then return the resulting AXObject for the node. Case #2: HandleEventSubscriptionChanged() was calling DetermineAccessibilityRole() to determine whether the role will be changing. However, DetermineAccessibilityRole creates AXObjects in tables to help determine the table role as it looks up the parent chain. Defer this work until clean layout. R=chrishtr@chromium.org Fixed: 1480806 Change-Id: Iae28fe0c12decfa809321bb56a069fd0edc97e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852282 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1195467}

Change-Id: Ia79eca084ee622ba9ea5e33b2920cde273f1b769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864479 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938_62@{#2} Cr-Branched-From: 25a7172-refs/branch-heads/5938@{#1146} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Change-Id: I062cd1182087b595f169a395999b8c10f9b58cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5075975 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099_56@{#2} Cr-Branched-From: 6c113a6-refs/branch-heads/6099@{#1192} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

Change-Id: Ie76e90e3402f1450a0e95ef157ad68f547154452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530770 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367_201@{#2} Cr-Branched-From: 46cf136-refs/branch-heads/6367@{#1130} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

blueboxd added the bug Something isn't working label Sep 22, 2020

scrutinizer11 mentioned this issue Jan 25, 2024

Chromium UI Flickers, Movable Site Objects Not Moving on Reddit #204

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crashing on launch on OS X 10.9.5 #2

Crashing on launch on OS X 10.9.5 #2

Wowfunhappy commented Sep 16, 2020

aeiouaeiouaeiouaeiouaeiouaeiou commented Sep 22, 2020

blueboxd commented Sep 22, 2020

Wowfunhappy commented Nov 13, 2020 •

edited

Loading

blueboxd commented Nov 13, 2020 •

edited

Loading

Wowfunhappy commented Nov 13, 2020

Crashing on launch on OS X 10.9.5 #2

Crashing on launch on OS X 10.9.5 #2

Comments

Wowfunhappy commented Sep 16, 2020

aeiouaeiouaeiouaeiouaeiouaeiou commented Sep 22, 2020

blueboxd commented Sep 22, 2020

Wowfunhappy commented Nov 13, 2020 • edited Loading

blueboxd commented Nov 13, 2020 • edited Loading

Wowfunhappy commented Nov 13, 2020

Wowfunhappy commented Nov 13, 2020 •

edited

Loading

blueboxd commented Nov 13, 2020 •

edited

Loading