Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI doesn't support rendering on metal for MacOS #1405

Closed
2 tasks done
spydon opened this issue Jan 28, 2023 · 12 comments · Fixed by #1483
Closed
2 tasks done

GitHub CI doesn't support rendering on metal for MacOS #1405

spydon opened this issue Jan 28, 2023 · 12 comments · Fixed by #1483
Labels
bug platform-mac Affects the macos platform

Comments

@spydon
Copy link
Member

spydon commented Jan 28, 2023

Checklist

  • I read the troubleshooting guide before raising this issue
  • I made sure that the issue I am raising doesn't already exist

Current bug behaviour

This is not a bug from our side, but from GitHub CI.
They don't support rendering on metal for their MacOS CI hosts which makes it impossible to use Flutter 3.7.0, so currently we've had to pin the version to 3.3.10.

Expected behaviour

It should work with the 3.7.0, once GitHub CI has fixed that issue we should remove the version pinning here:
https://github.com/bluefireteam/audioplayers/pull/1399/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R186

Steps to

More information

actions/runner-images#1779 (comment)

@spydon spydon added the bug label Jan 28, 2023
@Gustl22
Copy link
Collaborator

Gustl22 commented Jan 28, 2023

@Gustl22 Gustl22 added the platform-mac Affects the macos platform label Jan 29, 2023
@Gustl22
Copy link
Collaborator

Gustl22 commented Jan 30, 2023

We may can get the tests running with latest Flutter on M1 mac as stated here:
flutter/flutter#118469 (comment)
Maybe Github supports metal graphics for these, or some other magic is happening.

@spydon
Copy link
Member Author

spydon commented Jan 30, 2023

We have no option of choosing to run on M1s on GitHub yet:
actions/runner-images#2187
github/roadmap#528

@Gustl22
Copy link
Collaborator

Gustl22 commented Jan 30, 2023

Ah that explains, why it worked. Of course self-hosted runners have GPU support.

@spydon
Copy link
Member Author

spydon commented Jan 30, 2023

If anyone would be keen to set up a MacOS runner on Codemagic maybe @erickzanardo would be willing to spend some of his credit on there, because if I remember correctly he won an insane amount of those credits on a hackathon 😅

@erickzanardo
Copy link
Member

Sure thing!

@Gustl22
Copy link
Collaborator

Gustl22 commented Jan 30, 2023

Maybe GH is doing something about it:
actions/runner-images#183 (comment)
We are not in a hurry, as I expect, support for Flutter 3.3.x will at least be a year or so. But then maybe it is time to switch.

@erickzanardo
Copy link
Member

Is there any other instances on GH that would allow that? If so, and if we want to keep all our actions running on a single CI service, we may be able to pay for it with Blue Fire's fund

@spydon
Copy link
Member Author

spydon commented Jan 30, 2023

Is there any other instances on GH that would allow that? If so, and if we want to keep all our actions running on a single CI service, we may be able to pay for it with Blue Fire's fund

There is not, possibly Q3 2023 according to their roadmap.

@erickzanardo
Copy link
Member

Got ya!

We can use codemagic then, the only thing is that, as you said, my insane amount of credits are tied to Cherry Bit's team, so I would need to put AP under that team instead of creating a Blue Fire team for example.

If you don't mind it, I am ok with it too

@Gustl22
Copy link
Collaborator

Gustl22 commented Jan 30, 2023

I would recommend waiting for like 2 to 3 month. Afterwards, Flutter reintroduces OpenGL support or GH has something up in their sleeve, and we would do the transfer / rewriting actions for nothing. Especially cause we have the time, flutter / flutter community not had the chance to react on it, and credits are also exhausted some day in the far future (?), although I would really appreciate this option, if there's no solution for GH.

@erickzanardo
Copy link
Member

Alright, makes sense IMO.

About the credits exhausted, indeed they will! But I am fine with spending part of the income that Blue Fire gets from Patreon and sponsors into something like this.

Anyway, lets wait then, but feel free to reach me if we decide to move to codemagic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug platform-mac Affects the macos platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants