Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix macos integration tests, remove unnecessary actions #1483

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Apr 25, 2023

Description

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs:, chore: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Apr 26, 2023

App tests don't start for some reason on macos-13 image for iOS, but logs are gone in GH CI.
image

@Gustl22 Gustl22 requested a review from spydon April 26, 2023 20:19
@spydon
Copy link
Member

spydon commented Apr 26, 2023

App tests don't start for some reason on macos-13 image for iOS, but logs are gone in GH CI. image

Looks like everything passed now?
We should check out the faster macos machines that they have on beta now.

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Apr 27, 2023

Looks like everything passed now? We should check out the faster macos machines that they have on beta now.

Yes, that's what I did for macOS and Android. iOS stucks on running tests on UI. But I don't have the capacities to debug it right now. We can do this later on.

@Gustl22 Gustl22 merged commit a342c06 into main Apr 27, 2023
@Gustl22 Gustl22 deleted the gustl22/macos-13 branch April 27, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub CI doesn't support rendering on metal for MacOS
2 participants