-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record: set MTX_SEGMENT_DURATION in runOnRecordSegmentComplete #3440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathDefaults:
recordPartDuration: 500ms
recordSegmentDuration: 1500ms
runOnRecordSegmentCreate: echo "path '$MTX_SEGMENT_PATH' duration '$MTX_SEGMENT_DURATION'"
runOnRecordSegmentComplete: echo "$MTX_SEGMENT_PATH $MTX_SEGMENT_DURATION"
|
moenodedev
changed the title
Set MTX_SEGMENT_DURATION in runOnRecordSegmentComplete
record: set MTX_SEGMENT_DURATION in runOnRecordSegmentComplete
Jun 9, 2024
The duration is also useful for monitoring mediamtx.yml pathDefaults:
runOnRecordSegmentComplete: sh notify.sh "$MTX_SEGMENT_PATH" "$MTX_SEGMENT_DURATION" notify.sh #!/bin/bash
PATH=$1
DURATION=$2
if [ -z "$DURATION" ]; then
echo "ERROR $PATH duration is blank"
exit 2
elif [ $(echo "$DURATION < 10.0" | /usr/bin/bc) -ne 0 ]; then
echo "WARNING $PATH duration is < 10.0"
exit 1
fi
echo "SUCCESS $PATH duration is >= 10.0"
exit 0 output
|
Hello, while the idea is good, this is implemented in a wrong way since |
replaced by #3456 |
Thank you! |
aler9
added a commit
that referenced
this pull request
Jun 11, 2024
This issue is mentioned in release v1.8.3 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
MTX_SEGMENT_DURATION
to the external command in therunOnRecordSegmentComplete
hook. The duration of individual segments is useful when creating an HLS playlist.Issue #2983