Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose MTX_SEGMENT_DURATION to runOnRecordSegmentComplete (#3440) (#2983) #3456

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 11, 2024

Replaces #3440
Fixes #2983

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 51.30435% with 56 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (3a2594d) to head (f1be886).

Files Patch % Lines
internal/record/format_mpegts.go 40.74% 47 Missing and 1 partial ⚠️
internal/record/format_fmp4.go 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
+ Coverage   56.25%   56.46%   +0.20%     
==========================================
  Files         190      190              
  Lines       19078    19120      +42     
==========================================
+ Hits        10733    10796      +63     
+ Misses       7521     7503      -18     
+ Partials      824      821       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 3eabe6a into main Jun 11, 2024
7 of 8 checks passed
@aler9 aler9 deleted the feature/mtx-seg-duration branch June 11, 2024 16:30
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DURATION param for runOnRecordSegmentComplete hook
1 participant