Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SCREEN from lightbox layout #6124

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Remove SCREEN from lightbox layout #6124

merged 12 commits into from
Nov 6, 2024

Commits on Nov 5, 2024

  1. Assign an ID to lightbox and use it as a key

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3673399 View commit details
    Browse the repository at this point in the history

  2. Consolidate lightbox props into an object

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8162501 View commit details
    Browse the repository at this point in the history

  3. Remove unused prop

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ef7eb8b View commit details
    Browse the repository at this point in the history

  4. Move SafeAreaView declaration

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f1d3540 View commit details
    Browse the repository at this point in the history

  5. Keep SafeAreaView always mounted 

    When exploring Android animation, I noticed its content jumps on the first frame. I think this should help prevent that.
    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1fb4859 View commit details
    Browse the repository at this point in the history

  6. Pass safe area down for measurement

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fadf813 View commit details
    Browse the repository at this point in the history

  7. Remove dependency on SCREEN in Android event handlers

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9329dca View commit details
    Browse the repository at this point in the history

  8. Remove dependency on SCREEN in iOS event handlers

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1577995 View commit details
    Browse the repository at this point in the history

  9. Remove dependency on SCREEN on iOS

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fbd0d05 View commit details
    Browse the repository at this point in the history

  10. Remove dependency on SCREEN on Android

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e47bb16 View commit details
    Browse the repository at this point in the history

  11. Remove dependency on JS calc in controls

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    901038a View commit details
    Browse the repository at this point in the history

  12. Use flex for iOS layout

    @gaearon
    gaearon committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e7db61e View commit details
    Browse the repository at this point in the history