Fix camera orientation on Android #6729
Merged
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
mozzius
force-pushed
the
fix-camera-orientation
branch
from
b61f13b to
1fb4c90
Compare
arcalinea
temporarily deployed
to
fix-camera-orientation - social-app PR #6729
Render
Destroyed
mozzius
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where using the camera button would produce a stretched image on Android. The issue was that the
width/heightwere misreported by not taking the EXIF tags into account. The iOS version does this correctly.Upstream PR: ivpusic/react-native-image-crop-picker#2110
Test Plan
Try taking a camera image in all orientations (landscape/rotate with both front/back camera), verify it appears correctly both before posting (in the composer preview) and after posting.