Fix openCamera reported dimensions for portrait photos on Android #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
gaearon
commented
Nov 25, 2024
| @@ -678,6 +679,15 @@ private WritableMap getImage(final Activity activity, String path) throws Except | |||
| throw new Exception("Cannot select remote files"); | |||
| } | |||
| BitmapFactory.Options original = validateImage(path); | |||
| ExifInterface originalExif = new ExifInterface(path); | |||
There was a problem hiding this comment.
it's fine to read just the original exif because the orientation tag gets carried forward in the compression step
|
thanks! |
|
Hello, @ivpusic, tell me please, when a new version with this fix will be released? |
|
released in 0.41.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're observing width/height being incorrectly reported by the library on Android with portrait photos. This fix, similar to the logic here, is to swap the reported width/height if the EXIF tag specifies a rotated orientation.
This aligns with the library's behavior on iOS where the width/height are swapped for photos with rotated EXIF.
Test Plan
Verify that portrait photos (I was using Samsung Galaxy A12) report flipped dimensions, just like the iOS version does.