Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add built documentation ZIP file artifact upload to docs workflow #282

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Nov 2, 2023

@prjemian prjemian added this to the v1.1 milestone Nov 2, 2023
@prjemian prjemian self-assigned this Nov 2, 2023
@prjemian
Copy link
Contributor Author

prjemian commented Nov 2, 2023

GHA suggests:

docs (3.9)
This action is deprecated and no longer maintained. Please use mamba-org/setup-micromamba instead. See https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba for a migration guide.

@prjemian
Copy link
Contributor Author

prjemian commented Nov 2, 2023

@mrakitin Ready for review.

@prjemian
Copy link
Contributor Author

prjemian commented Nov 2, 2023

Great idea! This works easily. NeXus will benefit, too.

This was referenced Nov 2, 2023
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's now easy to check the docs.

The only issue with the workflow can be that it may not pull enough commits/tags to version the docs properly. We can probably set those to non-default values (from https://github.com/actions/checkout):

    # Number of commits to fetch. 0 indicates all history for all branches and tags.
    # Default: 1
    fetch-depth: ''

    # Whether to fetch tags, even if fetch-depth > 0.
    # Default: false
    fetch-tags: ''

@prjemian prjemian merged commit b5fa72a into main Nov 3, 2023
8 checks passed
@prjemian prjemian deleted the 281-artifact branch November 3, 2023 00:18
@prjemian
Copy link
Contributor Author

prjemian commented Nov 3, 2023

Solves the problem with the wrong version posted in the web documentation! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload built documentation as artifact
2 participants