Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass pre-commit tests #286

Merged
merged 8 commits into from
Nov 3, 2023
Merged

pass pre-commit tests #286

merged 8 commits into from
Nov 3, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Nov 2, 2023

@prjemian prjemian added the task label Nov 2, 2023
@prjemian prjemian added this to the v1.1 milestone Nov 2, 2023
@prjemian prjemian self-assigned this Nov 2, 2023
@prjemian
Copy link
Contributor Author

prjemian commented Nov 2, 2023

In draft waiting on #282, #284, and #285.

@prjemian
Copy link
Contributor Author

prjemian commented Nov 3, 2023

Needs apischema in the environment files. That's coming from both PR #284 and #285.

@prjemian prjemian marked this pull request as ready for review November 3, 2023 14:35
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @prjemian!

Comment on lines +38 to +59
from .geometries import E4CH # noqa: F401, F402, E402
from .geometries import E4CV
from .geometries import E6C
from .geometries import K4CV
from .geometries import K6C
from .geometries import Petra3_p09_eh2
from .geometries import Petra3_p23_4c
from .geometries import Petra3_p23_6c
from .geometries import SimMixin
from .geometries import SimulatedE4CV
from .geometries import SimulatedE6C
from .geometries import SimulatedK4CV
from .geometries import SimulatedK6C
from .geometries import SoleilMars
from .geometries import SoleilNanoscopiumRobot
from .geometries import SoleilSiriusKappa
from .geometries import SoleilSiriusTurret
from .geometries import SoleilSixsMed1p2
from .geometries import SoleilSixsMed2p2
from .geometries import SoleilSixsMed2p3
from .geometries import SoleilSixsMed2p3v2
from .geometries import Zaxis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it what isort recommends doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an isort preference. https://github.com/bluesky/hklpy/blob/706295113424e2af54d8922df173c73d31baf8fc/pyproject.toml#L104C1-L105C1

[tool.isort]
profile = "black"
force_single_line  = "True"
line_length = 88
multi_line_output = "NOQA"
src_paths = ["hkl"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # noqa was not copied to the other lines. But still passes.

@prjemian prjemian merged commit 3d80788 into main Nov 3, 2023
8 checks passed
@prjemian prjemian deleted the 274-lint-and-style branch November 3, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass pre-commit checks
2 participants