pass pre-commit tests #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prjemian
commented
Nov 2, 2023
prjemian
commented
- close pass pre-commit checks #274
mrakitin
approved these changes
Nov 3, 2023
Comment on lines
+38
to
+59
| from .geometries import E4CH # noqa: F401, F402, E402 | ||
| from .geometries import E4CV | ||
| from .geometries import E6C | ||
| from .geometries import K4CV | ||
| from .geometries import K6C | ||
| from .geometries import Petra3_p09_eh2 | ||
| from .geometries import Petra3_p23_4c | ||
| from .geometries import Petra3_p23_6c | ||
| from .geometries import SimMixin | ||
| from .geometries import SimulatedE4CV | ||
| from .geometries import SimulatedE6C | ||
| from .geometries import SimulatedK4CV | ||
| from .geometries import SimulatedK6C | ||
| from .geometries import SoleilMars | ||
| from .geometries import SoleilNanoscopiumRobot | ||
| from .geometries import SoleilSiriusKappa | ||
| from .geometries import SoleilSiriusTurret | ||
| from .geometries import SoleilSixsMed1p2 | ||
| from .geometries import SoleilSixsMed2p2 | ||
| from .geometries import SoleilSixsMed2p3 | ||
| from .geometries import SoleilSixsMed2p3v2 | ||
| from .geometries import Zaxis |
There was a problem hiding this comment.
Is it what isort recommends doing?
There was a problem hiding this comment.
It's an isort preference. https://github.com/bluesky/hklpy/blob/706295113424e2af54d8922df173c73d31baf8fc/pyproject.toml#L104C1-L105C1
[tool.isort]
profile = "black"
force_single_line = "True"
line_length = 88
multi_line_output = "NOQA"
src_paths = ["hkl"]There was a problem hiding this comment.
The # noqa was not copied to the other lines. But still passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.