Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove directive comments for deno #69

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Remove directive comments for deno #69

merged 2 commits into from
Feb 21, 2025

Conversation

tsutoringo
Copy link
Contributor

@tsutoringo tsutoringo commented Feb 21, 2025

These directive comments are no longer needed due to the following PR

denoland/deno#27631
denoland/deno#28185

@bluwy
Copy link
Owner

bluwy commented Feb 21, 2025

Awesome! Does that mean the deno types in .jsx files can also be removed too?

// @deno-types="@types/react"
import { StrictMode } from 'react'
// @deno-types="@types/react-dom/client"
import { createRoot } from 'react-dom/client'

// @deno-types="@types/react"
import { useState } from 'react'

@tsutoringo
Copy link
Contributor Author

Seems to work!
image

Copy link
Owner

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy changed the title Remove any directive comments for deno 🎉 Remove directive comments for deno Feb 21, 2025
@bluwy bluwy merged commit d586cc4 into bluwy:master Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants