fix(lsp/check): don't resolve unknown media types to a .js extension
#27631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
approved these changes
Jan 11, 2025
Comment on lines
+17189
to
+17258
| assert_eq!(diagnostics.all().len(), 0); | ||
| } |
There was a problem hiding this comment.
Should we client.shutdown() here for consistency? Probably fine if we don't though
There was a problem hiding this comment.
I think we could remove all of those. I've also just been keeping up the song and dance when writing those tests lol
There was a problem hiding this comment.
We should probably be testing in at least one if the process ends itself upon shutdown, but I think in all of these we're just forcefully ending the process after sending the notification..
nathanwhit
force-pushed
the
unknown-not-js
branch
from
43b398c to
5f6b59e
Compare
This was referenced Jan 11, 2025
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2025
#27631) Fixes #25762. Note that some of the things in that issue are not resolved (vite/client types not working properly which has other root causes), but the wildcard module augmentation specifically is fixed by this. We were telling TSC that files with unknown media types had an extension of `.js`, so the ambient module declarations weren't applying. Instead, just don't resolve them, so the ambient declaration applies.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25762. Note that some of the things in that issue are not resolved (vite/client types not working properly which has other root causes), but the wildcard module augmentation specifically is fixed by this.
We were telling TSC that files with unknown media types had an extension of
.js, so the ambient module declarations weren't applying. Instead, just don't resolve them, so the ambient declaration applies.