Start removing non-VM path (#1747)

.github/workflows/bors.yml

@@ -29,28 +29,6 @@ jobs:
         with:
           command: test
           args: -v
-  test_vm_on_linux:
-    name: Tests on Linux with vm enabled
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2.4.0
-      - uses: actions-rs/toolchain@v1.0.7
-        with:
-          toolchain: stable
-          override: true
-          profile: minimal
-      - name: Cache cargo
-        uses: actions/cache@v2.1.7
-        with:
-          path: |
-            target
-            ~/.cargo/git
-            ~/.cargo/registry
-          key: ${{ runner.os }}-cargo-test-${{ hashFiles('**/Cargo.lock') }}
-      - uses: actions-rs/cargo@v1
-        with:
-          command: test
-          args: ---package Boa --lib --features=vm -- vm --nocapture
 
   test_on_windows:
     name: Tests on Windows

.github/workflows/rust.yml

@@ -33,28 +33,6 @@ jobs:
           args: --ignore-tests
       - name: Upload to codecov.io
         uses: codecov/codecov-action@v2.1.0
-  test_vm_on_linux:
-    name: Tests on Linux with vm enabled
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2.4.0
-      - uses: actions-rs/toolchain@v1.0.7
-        with:
-          toolchain: stable
-          override: true
-          profile: minimal
-      - name: Cache cargo
-        uses: actions/cache@v2.1.7
-        with:
-          path: |
-            target
-            ~/.cargo/git
-            ~/.cargo/registry
-          key: ${{ runner.os }}-cargo-test-${{ hashFiles('**/Cargo.lock') }}
-      - uses: actions-rs/cargo@v1
-        with:
-          command: test
-          args: ---package Boa --lib --features=vm -- vm --nocapture
 
   test_on_windows:
     name: Tests on Windows

.github/workflows/test262.yml

@@ -61,26 +61,6 @@ jobs:
           comment="${comment//$'\r'/'%0D'}"
           echo "::set-output name=comment::$comment"
 
-      - name: Run the test262 test suite for VM
-        run: |
-          cd boa
-          mkdir -p ../results
-          cargo run --release --features vm --bin boa_tester -- run -v -o ../results/test262/vm
-          cd ..
-
-      # Run the results comparison for VM
-      - name: Compare results for VM
-        if: github.event_name == 'pull_request'
-        id: compare-vm
-        shell: bash
-        run: |
-          cd boa
-          comment="$(./target/release/boa_tester compare ../gh-pages/test262/vm/refs/heads/main/latest.json ../results/test262/vm/pull/latest.json -m)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "::set-output name=comment::$comment"
-
       - name: Get the PR number
         if: github.event_name == 'pull_request'
         id: pr-number

.vscode/tasks.json

@@ -26,7 +26,7 @@
       "type": "process",
       "label": "Cargo Run (VM)",
       "command": "cargo",
-      "args": ["run", "--features", "vm", "--", "-t", "../tests/js/test.js"],
+      "args": ["run", "--", "-t", "../tests/js/test.js"],
       "group": {
         "kind": "build",
         "isDefault": true

boa/Cargo.toml

@@ -15,9 +15,6 @@ rust-version = "1.57"
 profiler = ["measureme"]
 deser = []
 
-# Enable Bytecode generation & execution instead of tree walking
-vm = []
-
 # Enable Boa's WHATWG console object implementation.
 console = []
 
@@ -59,14 +56,6 @@ crate-type = ["cdylib", "lib"]
 name = "boa"
 bench = false
 
-[[bench]]
-name = "parser"
-harness = false
-
-[[bench]]
-name = "exec"
-harness = false
-
 [[bench]]
 name = "full"
 harness = false

boa/benches/README.md

@@ -1,10 +1,10 @@
-# Boa Benchmarks.
+# Boa Benchmarks
 
-We divide the benchmarks in 3 sections:
+For each js script in the `bench_scripts` folder, we create three benchmarks:
 
-- Full engine benchmarks (lexing + parsing + realm creation + execution)
-- Execution benchmarks
-- Parsing benchmarks (lexing + parse - these are tightly coupled so must be benchmarked together)
+- Parser => lexing and parsing of the source code
+- Compiler => compilation of the parsed statement list into bytecode
+- Execution => execution of the bytecode in the vm
 
-The idea is to check the performance of Boa in different scenarios and dividing the Boa execution
-process in its different parts.
+The idea is to check the performance of Boa in different scenarios.
+Different parts of Boa are benchmarked separately to make the impact of local changes visible.