Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from time to Chrono #3

Closed
jasonwilliams opened this issue Oct 21, 2018 · 2 comments
Closed

Migrate from time to Chrono #3

jasonwilliams opened this issue Oct 21, 2018 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Oct 21, 2018 •
edited
Loading

the time crate is deprecated and Chrono seems to be the replacement. We should move to this

Time
https://crates.io/crates/time
https://docs.rs/time/0.1.40/time/

Chrono
https://crates.io/crates/chrono
https://docs.rs/chrono/0.4.6/chrono/

More Info
time-rs/time#136
@jasonwilliams jasonwilliams added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 27, 2018
@JasonShin
Copy link

I don't know Rust but I'm keen on helping it out

jasonwilliams added a commit that referenced this issue Mar 19, 2019
@jasonwilliams
Merge pull request #8 from AFRUITPIE/master
058a82e 
migrate from 'time' to 'chrono', fixes issue #3
@jasonwilliams
Copy link
Member Author

this has now been fixed thanks @AFRUITPIE !

Razican added a commit that referenced this issue May 11, 2020
@Razican
# This is a combination of 7 commits.
3494837 
# This is the 1st commit message:

The interpreter is now modular.

# The commit message #2 will be skipped:

# Moved array declarations to their own module

# The commit message #3 will be skipped:

# Added ArrowFunctionDecl

# The commit message #4 will be skipped:

# Removed the `Executor` trait, and added the `Assign` operator

# The commit message #5 will be skipped:

# Fixed documentation links

# The commit message #6 will be skipped:

# Added `BinOp` execution, and made operators `Copy`.

# The commit message #7 will be skipped:

# Moved `Node` executor to its own `Executable` implementation
bors bot pushed a commit that referenced this issue Nov 2, 2022
@addisoncrump
Implement AST Visitor pattern (attempt #3) (#2392)
b5b8cdf 
This Pull Request closes no specific issue, but allows for analysis and post-processing passes by both internal and external developers.

It changes the following:

- Adds a Visitor trait, to be implemented by visitors of a particular node type.
- Adds `Type`Visitor traits which offer access to private members of a node.
- Adds an example which demonstrates the use of Visitor traits by walking over an AST and printing its contents.

At this time, the PR is more of a demonstration of intent rather than a full PR. Once it's in a satisfactory state, I'll mark it as not a draft.


Co-authored-by: Addison Crump <addison.crump@cispa.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonwilliams @JasonShin