fixing decrementation and testing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added a commit
that referenced
this pull request
May 11, 2020
# This is the 1st commit message: The interpreter is now modular. # The commit message #2 will be skipped: # Moved array declarations to their own module # The commit message #3 will be skipped: # Added ArrowFunctionDecl # The commit message #4 will be skipped: # Removed the `Executor` trait, and added the `Assign` operator # The commit message #5 will be skipped: # Fixed documentation links # The commit message #6 will be skipped: # Added `BinOp` execution, and made operators `Copy`. # The commit message #7 will be skipped: # Moved `Node` executor to its own `Executable` implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@songzhi you might be interested to know i fixed a bug that was related to your PR, when the lexer comes across a
--it only advances 1 place, so it ends up lexing the second-.So the tokens end up being
[Dec, Sub]instead of just[Dec]this PR fixes it