Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Create benchmark for Array manipulation #428

Closed
jasonwilliams opened this issue May 31, 2020 · 1 comment · Fixed by #458
Closed

[Feature Request] - Create benchmark for Array manipulation #428

jasonwilliams opened this issue May 31, 2020 · 1 comment · Fixed by #458
Assignees
Labels
benchmark Issues and PRs related to the benchmark subsystem. E-Easy Easy good first issue Good for newcomers
Milestone

Comments

@jasonwilliams
Copy link
Member

In order to test the upcoming optimisation work we're doing around objects it would be good to have a benchmark for Arrays and manipulating them.

Example

Benchmarks live here
an array creation and access would be categorised under exec.

If exec benchmarks become too big we can compartmentalise them later on.

You can see the fibonacci benchmark here:
https://github.com/boa-dev/boa/blob/master/boa/benches/exec.rs#L49-L66

2 benchmarks could be made, 1 for accessing a value from an array, another for creating an array.
We could introduce more benchmarks here for various methods commonly used on arrays

in order to run the benchmarks you can run cargo bench in the root folder

Contributing

https://github.com/boa-dev/boa/blob/master/CONTRIBUTING.md
https://github.com/boa-dev/boa/blob/master/docs/debugging.md

@jasonwilliams jasonwilliams added good first issue Good for newcomers E-Easy Easy benchmark Issues and PRs related to the benchmark subsystem. labels May 31, 2020
@abhijeetbhagat
Copy link
Contributor

abhijeetbhagat commented May 31, 2020

I can take this up. Please assign it to me if no one else is working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. E-Easy Easy good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants