Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for array access, create and pop operations. #458

Merged
merged 18 commits into from
Jun 12, 2020
Merged

Add benchmarks for array access, create and pop operations. #458

merged 18 commits into from
Jun 12, 2020

Conversation

abhijeetbhagat
Copy link
Contributor

This Pull Request fixes/closes #428 .

It adds benchmarks for array access, create and pop operations.

@abhijeetbhagat
Find if reviver is a function
936eed2
@abhijeetbhagat
Initial version - translation of the polyfills impl
d063dc4
@abhijeetbhagat
Refactoring - remove unneccessary binding
a69dc13
@abhijeetbhagat
Merge remote-tracking branch 'upstream/master'
2c25865
@abhijeetbhagat
Check for a proper object now that null is an object
f09094b
@abhijeetbhagat
Remove unneccessary let binding
9085019
@abhijeetbhagat
Make clippy happy
d41ee41
@abhijeetbhagat
Remove clippy annotation related to cloning
0bf3a0f
@abhijeetbhagat
Fix bug - set_field doesn't update values created using from_json()
cacd8da
@abhijeetbhagat
Fix JSON.parse tests - Use interpreter instead of an executor
0e49528
@abhijeetbhagat
Fix test - use forward_val and assert on the value returned
8c2324c
@abhijeetbhagat
Merge branch 'master' of https://github.com/jasonwilliams/boa
1411490
@abhijeetbhagat
Merge branch 'master' of https://github.com/jasonwilliams/boa
bfa21e2
@abhijeetbhagat
Merge branch 'master' of https://github.com/jasonwilliams/boa
5065930
@abhijeetbhagat
Add benchmarks for array access, create and pop operations
0dafd88
@codecov
Copy link

codecov bot commented Jun 6, 2020 •
edited
Loading

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files         149      149           
  Lines        9541     9541           
=======================================
  Hits         6398     6398           
  Misses       3143     3143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a45ab5...2798e59. Read the comment docs.

@abhijeetbhagat abhijeetbhagat changed the base branch from master to concurrent_parser June 6, 2020 11:24
@abhijeetbhagat abhijeetbhagat changed the base branch from concurrent_parser to master June 6, 2020 11:24
@abhijeetbhagat
Copy link
Contributor Author

I am not sure why the older commits are included in this PR. I even tried changing the base to a different branch to force GH to only include the latest commit.

@abhijeetbhagat
Copy link
Contributor Author

@jasonwilliams review?

@Razican Razican mentioned this pull request Jun 6, 2020
Merged
@Razican
Copy link
Member

Razican commented Jun 6, 2020

I am not sure why the older commits are included in this PR. I even tried changing the base to a different branch to force GH to only include the latest commit.

No worries, we will squash + merge :)

@jasonwilliams review?

This depends partly on #431. But this can already be adapted to that. The idea is to use the syntax in that PR to only benchmark the execution, without benchmarking the lexing, parsing and realm creation.

@Razican Razican added enhancement New feature or request benchmark Issues and PRs related to the benchmark subsystem. labels Jun 6, 2020
@Razican Razican added this to the v0.9.0 milestone Jun 6, 2020
@abhijeetbhagat
Copy link
Contributor Author

Understood. I'll take the lexer out of the benchmarking equation by following the changes in the linked issue.

@Razican
Copy link
Member

Razican commented Jun 11, 2020

Let us know, @abhijeetbhagat, when this is ready :)

HalidOdat
HalidOdat approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

boa/benches/exec.rs Outdated Show resolved Hide resolved
@HalidOdat
Copy link
Member

The benchmarks are failing because of criterion-compate-action github action its fixed on master, rebasing should fix it :)

@abhijeetbhagat
Copy link
Contributor Author

I thought pop() was causing a problem. So i removed it in the latest push. Let me restore it and also fix the array formatting.

Razican
Razican approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks! let's merge :)

@Razican Razican merged commit a7a5862 into boa-dev:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Create benchmark for Array manipulation
3 participants
@abhijeetbhagat @Razican @HalidOdat