-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More panic fixes #1050
Merged
Merged
More panic fixes #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improved a bit the sytax in `Map`, but was unable to remove that double borrow.
Razican
added
bug
Something isn't working
test
Issues and PRs related to the tests.
builtins
PRs and Issues related to builtins/intrinsics
labels
Jan 9, 2021
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
- Coverage 58.31% 58.30% -0.02%
==========================================
Files 172 172
Lines 12007 12008 +1
==========================================
- Hits 7002 7001 -1
- Misses 5005 5007 +2
Continue to review full report at Codecov.
|
Benchmark for 80ed99fClick to view benchmark
|
Lan2u
approved these changes
Jan 9, 2021
RageKnify
approved these changes
Jan 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of panics when working with regular expressions. I also tried to fix a double-borrow in
Map
but I only got to a bit of a better syntax, without fixing the panic.